4:06 p.m.
Hi Damien,
I love your patch! Perhaps something to improve:
[auto build test WARNING on block/for-next]
[also build test WARNING on mkp-scsi/for-next scsi/for-next linus/master v5.14-rc5
next-20210811]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Damien-Le-Moal/Initial-support-f...
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: hexagon-randconfig-r041-20210810 (attached as .config)
compiler: clang version 12.0.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/2055ecb9ea719e82d4db70d303fdac48c...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Damien-Le-Moal/Initial-support-for-multi-actuator-HDDs/20210812-102824
git checkout 2055ecb9ea719e82d4db70d303fdac48c33acd47
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir
ARCH=hexagon SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> block/blk-cranges.c:111: warning: expecting prototype for
blk_register_cranges(). Prototype was for disk_register_cranges() instead
vim +111 block/blk-cranges.c
99
100 /**
101 * blk_register_cranges - register with sysfs a set of concurrent ranges
102 * @disk: Target disk
103 * @new_cranges: New set of concurrent ranges
104 *
105 * Register with sysfs a set of concurrent ranges for @disk. If @new_cranges
106 * is not NULL, this set of concurrent ranges is registered and the
107 * old set specified by q->cranges is unregistered. Otherwise, q->cranges
108 * is registered if it is not already.
109 */
110 int disk_register_cranges(struct gendisk *disk, struct blk_cranges *new_cranges)
111 {
112 struct request_queue *q = disk->queue;
113 struct blk_cranges *cranges;
114 int i, ret;
115
116 lockdep_assert_held(&q->sysfs_dir_lock);
117 lockdep_assert_held(&q->sysfs_lock);
118
119 /* If a new range set is specified, unregister the old one */
120 if (new_cranges) {
121 if (q->cranges)
122 disk_unregister_cranges(disk);
123 q->cranges = new_cranges;
124 }
125
126 cranges = q->cranges;
127 if (!cranges)
128 return 0;
129
130 /*
131 * At this point, cranges is the new set of sector ranges that needs
132 * to be registered with sysfs.
133 */
134 WARN_ON(cranges->sysfs_registered);
135 ret = kobject_init_and_add(&cranges->kobj, &blk_cranges_ktype,
136 &q->kobj, "%s", "cranges");
137 if (ret) {
138 q->cranges = NULL;
139 kfree(cranges);
140 return ret;
141 }
142
143 for (i = 0; i < cranges->nr_ranges; i++) {
144 cranges->ranges[i].queue = q;
145 ret = kobject_init_and_add(&cranges->ranges[i].kobj,
146 &blk_crange_ktype, &cranges->kobj,
147 "%d", i);
148 if (ret) {
149 while (--i >= 0)
150 kobject_del(&cranges->ranges[i].kobj);
151 kobject_del(&cranges->kobj);
152 kobject_put(&cranges->kobj);
153 return ret;
154 }
155 }
156
157 cranges->sysfs_registered = true;
158
159 return 0;
160 }
161
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org