1:02 p.m.
Hi Mihai,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linux/master]
[also build test ERROR on soc/for-next linus/master v5.11-rc7]
[cannot apply to char-misc/char-misc-testing next-20210211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Mihai-Carabas/misc-pvpanic-split...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
2ab38c17aac10bf55ab3efde4c4db3893d8691d2
config: x86_64-randconfig-r012-20210209 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project
c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
#
https://github.com/0day-ci/linux/commit/70eed71fbb1f23b28a401213c2dac3c27...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Mihai-Carabas/misc-pvpanic-split-up-generic-and-platform-dependent-code/20210213-043307
git checkout 70eed71fbb1f23b28a401213c2dac3c27fcae323
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/misc/pvpanic/pvpanic.c:62:5: warning: no previous prototype for function
'pvpanic_probe' [-Wmissing-prototypes]
int pvpanic_probe(void __iomem *pbase)
^
drivers/misc/pvpanic/pvpanic.c:62:1: note: declare 'static' if the function is
not intended to be used outside of this translation unit
int pvpanic_probe(void __iomem *pbase)
^
static
> drivers/misc/pvpanic/pvpanic.c:87:3: error: void function
'pvpanic_remove' should not return a value [-Wreturn-type]
return -EINVAL;
^ ~~~~~~~
drivers/misc/pvpanic/pvpanic.c:82:6: warning: no previous prototype for function
'pvpanic_remove' [-Wmissing-prototypes]
void pvpanic_remove(void __iomem *pbase)
^
drivers/misc/pvpanic/pvpanic.c:82:1: note: declare 'static' if the function is
not intended to be used outside of this translation unit
void pvpanic_remove(void __iomem *pbase)
^
static
2 warnings and 1 error generated.
vim +/pvpanic_remove +87 drivers/misc/pvpanic/pvpanic.c
61
62 int pvpanic_probe(void __iomem *pbase)
63 {
64 struct pvpanic_instance *pi;
65
66 if(!pbase)
67 return -EINVAL;
68
69 pi = kmalloc(sizeof(*pi), GFP_ATOMIC);
70 if (!pi)
71 return -ENOMEM;
72
73 pi->base = pbase;
74 spin_lock(&pvpanic_lock);
75 list_add(&pi->list, &pvpanic_list);
76 spin_unlock(&pvpanic_lock);
77
78 return 0;
79 }
80 EXPORT_SYMBOL_GPL(pvpanic_probe);
81
82 void pvpanic_remove(void __iomem *pbase)
83 {
84 struct pvpanic_instance *pi_cur, *pi_next;
85
86 if(!pbase)
87 return -EINVAL;
88
89 spin_lock(&pvpanic_lock);
90 list_for_each_entry_safe(pi_cur, pi_next, &pvpanic_list, list) {
91 if (pi_cur->base == pbase) {
92 list_del(&pi_cur->list);
93 kfree(pi_cur);
94 break;
95 }
96 }
97 spin_unlock(&pvpanic_lock);
98 }
99 EXPORT_SYMBOL_GPL(pvpanic_remove);
100
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org