[kbuild-all] [frank-w-bpi-r2-4.14:5.12-hnat 7/31] drivers/misc/mediatek/connectivity/common/conn_soc/mt7623/mtk_wcn_consys_hw.c:191:6: error: no previous prototype for 'mtk_wcn_consys_power_on'

tree: https://github.com/frank-w/BPI-R2-4.14 5.12-hnat head: bdac934d9a6605b4394115649bb730461d651dce commit: 5e8ba0cbbe3ba87e5e0dae451e4750b00a5594f4 [7/31] mt6625l: add changes outside driver dir config: arm-randconfig-r025-20210313 (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/frank-w/BPI-R2-4.14/commit/5e8ba0cbbe3ba87e5e0dae451e4... git remote add frank-w-bpi-r2-4.14 https://github.com/frank-w/BPI-R2-4.14 git fetch --no-tags frank-w-bpi-r2-4.14 5.12-hnat git checkout 5e8ba0cbbe3ba87e5e0dae451e4750b00a5594f4 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): 191 | VOID mtk_wcn_consys_power_on(VOID) | ^~~~~~~~~~~~~~~~~~~~~~~ 207 | VOID mtk_wcn_consys_power_off(VOID) | ^~~~~~~~~~~~~~~~~~~~~~~~ 224 | INT32 mtk_wcn_consys_hw_reg_ctrl(UINT32 on, UINT32 co_clock_type) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ 335 | INT32 mtk_wcn_consys_hw_gpio_ctrl(UINT32 on) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ 539 | INT32 mtk_wcn_consys_hw_restore(struct device *device) | ^~~~~~~~~~~~~~~~~~~~~~~~~ 592 | int reserve_memory_consys_fn(struct reserved_mem *rmem) | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/misc/mediatek/connectivity/common/conn_soc/mt7623/mtk_wcn_consys_hw.c: In function 'mtk_wcn_consys_get_pinctrl': 713 | struct pinctrl *mtk_wcn_consys_get_pinctrl() | ^~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors vim +/mtk_wcn_consys_power_on +191 drivers/misc/mediatek/connectivity/common/conn_soc/mt7623/mtk_wcn_consys_hw.c 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 190 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 @191 VOID mtk_wcn_consys_power_on(VOID) 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 192 { 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 193 INT32 iRet = -1; 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 194 iRet = pm_runtime_get_sync(&my_pdev->dev); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 195 if (iRet) 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 196 WMT_PLAT_ERR_FUNC("pm_runtime_get_sync() fail(%d)\n", iRet); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 197 else 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 198 WMT_PLAT_INFO_FUNC("pm_runtime_get_sync() CONSYS ok\n"); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 199 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 200 iRet = device_init_wakeup(&my_pdev->dev, true); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 201 if (iRet) 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 202 WMT_PLAT_ERR_FUNC("device_init_wakeup(true) fail.\n"); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 203 else 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 204 WMT_PLAT_INFO_FUNC("device_init_wakeup(true) CONSYS ok\n"); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 205 } 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 206 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 @207 VOID mtk_wcn_consys_power_off(VOID) 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 208 { 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 209 INT32 iRet = -1; 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 210 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 211 iRet = pm_runtime_put_sync(&my_pdev->dev); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 212 if (iRet) 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 213 WMT_PLAT_ERR_FUNC("pm_runtime_put_sync() fail.\n"); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 214 else 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 215 WMT_PLAT_INFO_FUNC("pm_runtime_put_sync() CONSYS ok\n"); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 216 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 217 iRet = device_init_wakeup(&my_pdev->dev, false); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 218 if (iRet) 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 219 WMT_PLAT_ERR_FUNC("device_init_wakeup(false) fail.\n"); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 220 else 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 221 WMT_PLAT_INFO_FUNC("device_init_wakeup(false) CONSYS ok\n"); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 222 } 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 223 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 @224 INT32 mtk_wcn_consys_hw_reg_ctrl(UINT32 on, UINT32 co_clock_type) 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 225 { 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 226 UINT32 retry = 10; 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 227 UINT32 consysHwChipId = 0; 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 228 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 229 WMT_PLAT_DBG_FUNC("CONSYS-HW-REG-CTRL(0x%08x),start\n", on); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 230 if (on) { 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 231 WMT_PLAT_DBG_FUNC("++\n"); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 232 /*need PMIC driver provide new API protocol */ 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 233 /*1.AP power on VCN_1V8 LDO (with PMIC_WRAP API) VCN_1V8 */ 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 234 regulator_set_mode(reg_VCN18, REGULATOR_MODE_STANDBY); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 235 /* VOL_DEFAULT, VOL_1200, VOL_1300, VOL_1500, VOL_1800... */ 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 236 if (reg_VCN18) { 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 237 regulator_set_voltage(reg_VCN18, 1800000, 1800000); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 238 if (regulator_enable(reg_VCN18)) 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 239 WMT_PLAT_ERR_FUNC("enable VCN18 fail\n"); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 240 else 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 241 WMT_PLAT_DBG_FUNC("enable VCN18 ok\n"); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 242 } 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 243 udelay(150); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 244 if (co_clock_type) { 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 245 /*step0,clk buf ctrl */ 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 246 WMT_PLAT_INFO_FUNC("co clock type(%d),turn on clk buf\n", co_clock_type); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 247 #if CONSYS_CLOCK_BUF_CTRL 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 248 clk_buf_ctrl(CLK_BUF_CONN, 1); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 249 #endif 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 250 /*if co-clock mode: */ 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 251 /*2.set VCN28 to SW control mode (with PMIC_WRAP API) */ 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 252 /*turn on VCN28 LDO only when FMSYS is activated" */ 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 253 regmap_update_bits(pmic_regmap, 0x41C, 0x1 << 14, 0x0 << 14);/*V28*/ 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 254 } else { 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 255 /*if NOT co-clock: */ 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 256 /*2.1.switch VCN28 to HW control mode (with PMIC_WRAP API) */ 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 257 regmap_update_bits(pmic_regmap, 0x41C, 0x1 << 14, 0x1 << 14);/*V28*/ 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 258 /*2.2.turn on VCN28 LDO (with PMIC_WRAP API)" */ 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 259 /*fix vcn28 not balance warning */ 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 260 if (reg_VCN28) { 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 261 regulator_set_voltage(reg_VCN28, 2800000, 2800000); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 262 if (regulator_enable(reg_VCN28)) 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 263 WMT_PLAT_ERR_FUNC("enable VCN_2V8 fail!\n"); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 264 else 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 265 WMT_PLAT_DBG_FUNC("enable VCN_2V8 ok\n"); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 266 } 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 267 } 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 268 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 269 /*3.assert CONNSYS CPU SW reset 0x10007018 "[12]=1'b1 [31:24]=8'h88 (key)" */ 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 270 reset_control_reset(rstc); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 271 mtk_wcn_consys_power_on(); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 272 /*11.26M is ready now, delay 10us for mem_pd de-assert */ 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 273 udelay(10); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 274 /*enable AP bus clock : connmcu_bus_pd API: enable_clock() ++?? */ 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 275 clk_prepare_enable(clk_infra_conn_main); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 276 WMT_PLAT_DBG_FUNC("[CCF]enable clk_infra_conn_main\n"); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 277 /*12.poll CONNSYS CHIP ID until chipid is returned 0x18070008 */ 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 278 while (retry-- > 0) { 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 279 consysHwChipId = CONSYS_REG_READ(conn_reg.mcu_base + CONSYS_CHIP_ID_OFFSET) - 0xf6d; 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 280 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 281 if ((consysHwChipId == 0x0321) || (consysHwChipId == 0x0335) || (consysHwChipId == 0x0337)) { 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 282 WMT_PLAT_INFO_FUNC("retry(%d)consys chipId(0x%08x)\n", retry, consysHwChipId); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 283 break; 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 284 } 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 285 if ((consysHwChipId == 0x8163) || (consysHwChipId == 0x8127) || (consysHwChipId == 0x7623)) { 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 286 WMT_PLAT_INFO_FUNC("retry(%d)consys chipId(0x%08x)\n", retry, consysHwChipId); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 287 break; 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 288 } 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 289 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 290 WMT_PLAT_ERR_FUNC("Read CONSYS chipId(0x%08x)", consysHwChipId); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 291 msleep(20); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 292 } 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 293 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 294 if ((0 == retry) || (0 == consysHwChipId)) 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 295 WMT_PLAT_ERR_FUNC("Maybe has a consys power on issue,(0x%08x)\n", consysHwChipId); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 296 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 297 msleep(40); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 298 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 299 } else { 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 300 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 301 clk_disable_unprepare(clk_infra_conn_main); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 302 WMT_PLAT_DBG_FUNC("[CCF] clk_disable_unprepare(clk_infra_conn_main) calling\n"); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 303 mtk_wcn_consys_power_off(); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 304 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 305 if (co_clock_type) { 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 306 /*VCN28 has been turned off by GPS OR FM */ 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 307 #if CONSYS_CLOCK_BUF_CTRL 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 308 clk_buf_ctrl(CLK_BUF_CONN, 0); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 309 #endif 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 310 } else { 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 311 regmap_update_bits(pmic_regmap, 0x41C, 0x1 << 14, 0x0 << 14);/*V28*/ 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 312 /*turn off VCN28 LDO (with PMIC_WRAP API)" */ 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 313 if (reg_VCN28) { 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 314 if (regulator_disable(reg_VCN28)) 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 315 WMT_PLAT_ERR_FUNC("disable VCN_2V8 fail!\n"); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 316 else 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 317 WMT_PLAT_DBG_FUNC("disable VCN_2V8 ok\n"); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 318 } 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 319 } 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 320 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 321 /*AP power off MT6625L VCN_1V8 LDO */ 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 322 regulator_set_mode(reg_VCN18, REGULATOR_MODE_STANDBY); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 323 if (reg_VCN18) { 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 324 if (regulator_disable(reg_VCN18)) 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 325 WMT_PLAT_ERR_FUNC("disable VCN_1V8 fail!\n"); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 326 else 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 327 WMT_PLAT_DBG_FUNC("disable VCN_1V8 ok\n"); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 328 } 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 329 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 330 } 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 331 WMT_PLAT_DBG_FUNC("CONSYS-HW-REG-CTRL(0x%08x),finish\n", on); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 332 return 0; 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 333 } 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 334 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 @335 INT32 mtk_wcn_consys_hw_gpio_ctrl(UINT32 on) 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 336 { 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 337 INT32 iRet = 0; 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 338 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 339 WMT_PLAT_DBG_FUNC("CONSYS-HW-GPIO-CTRL(0x%08x), start\n", on); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 340 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 341 if (on) { 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 342 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 343 /* TODO: [FixMe][GeorgeKuo] double check if BGF_INT is implemented ok */ 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 344 /* iRet += wmt_plat_gpio_ctrl(PIN_BGF_EINT, PIN_STA_MUX); */ 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 345 iRet += wmt_plat_eirq_ctrl(PIN_BGF_EINT, PIN_STA_INIT); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 346 iRet += wmt_plat_eirq_ctrl(PIN_BGF_EINT, PIN_STA_EINT_DIS); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 347 WMT_PLAT_DBG_FUNC("CONSYS-HW, BGF IRQ registered and disabled\n"); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 348 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 349 } else { 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 350 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 351 /* set bgf eint/all eint to deinit state, namely input low state */ 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 352 iRet += wmt_plat_eirq_ctrl(PIN_BGF_EINT, PIN_STA_EINT_DIS); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 353 iRet += wmt_plat_eirq_ctrl(PIN_BGF_EINT, PIN_STA_DEINIT); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 354 WMT_PLAT_DBG_FUNC("CONSYS-HW, BGF IRQ unregistered and disabled\n"); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 355 /* iRet += wmt_plat_gpio_ctrl(PIN_BGF_EINT, PIN_STA_DEINIT); */ 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 356 } 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 357 WMT_PLAT_DBG_FUNC("CONSYS-HW-GPIO-CTRL(0x%08x), finish\n", on); 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 358 return iRet; 93bfa34f9f0d09 Frank Wunderlich 2020-12-28 359 :::::: The code at line 191 was first introduced by commit :::::: 93bfa34f9f0d0974afd632e66e52744a6bc20bbf mt6625l: add driver from 5.11 :::::: TO: Frank Wunderlich <frank-w(a)public-files.de&gt; :::::: CC: Frank Wunderlich <frank-w(a)public-files.de&gt; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org