[kbuild-all] [pinchartl-media:imx8mp/for-marek 257/277] drivers/staging/media/imx/imx8-isi-pipe.c:1307:24: warning: variable 'f' set but not used

tree: git://linuxtv.org/pinchartl/media.git imx8mp/for-marek head: dd5edf150f9888ae51868655558ca393131a52a1 commit: 07054221290d22f8f02e0c5c5f6d4ef8f916fd63 [257/277] staging: media: imx: isi: Drop legacy format fields config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git remote add pinchartl-media git://linuxtv.org/pinchartl/media.git git fetch --no-tags pinchartl-media imx8mp/for-marek git checkout 07054221290d22f8f02e0c5c5f6d4ef8f916fd63 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): drivers/staging/media/imx/imx8-isi-pipe.c: In function 'mxc_isi_pipe_set_selection': 1307 | struct mxc_isi_frame *f = &pipe->formats[MXC_ISI_SD_PAD_SINK]; | ^ vim +/f +1307 drivers/staging/media/imx/imx8-isi-pipe.c b5b373a37727bb drivers/staging/media/imx/imx8-isi-cap.c Guoniu.zhou 2019-01-21 1301 9fdcc0f46347df drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-04-19 1302 static int mxc_isi_pipe_set_selection(struct v4l2_subdev *sd, b5b373a37727bb drivers/staging/media/imx/imx8-isi-cap.c Guoniu.zhou 2019-01-21 1303 struct v4l2_subdev_pad_config *cfg, b5b373a37727bb drivers/staging/media/imx/imx8-isi-cap.c Guoniu.zhou 2019-01-21 1304 struct v4l2_subdev_selection *sel) b5b373a37727bb drivers/staging/media/imx/imx8-isi-cap.c Guoniu.zhou 2019-01-21 1305 { 7180b8d137a989 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-04-19 1306 struct mxc_isi_pipe *pipe = v4l2_get_subdevdata(sd); c24b3c44b1d2c7 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-04-19 @1307 struct mxc_isi_frame *f = &pipe->formats[MXC_ISI_SD_PAD_SINK]; 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1308 struct v4l2_mbus_framefmt *format; 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1309 struct v4l2_rect *rect; b5b373a37727bb drivers/staging/media/imx/imx8-isi-cap.c Guoniu.zhou 2019-01-21 1310 unsigned long flags; 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1311 int ret = 0; b5b373a37727bb drivers/staging/media/imx/imx8-isi-cap.c Guoniu.zhou 2019-01-21 1312 7180b8d137a989 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-04-19 1313 mutex_lock(&pipe->lock); b5b373a37727bb drivers/staging/media/imx/imx8-isi-cap.c Guoniu.zhou 2019-01-21 1314 b5b373a37727bb drivers/staging/media/imx/imx8-isi-cap.c Guoniu.zhou 2019-01-21 1315 switch (sel->target) { b5b373a37727bb drivers/staging/media/imx/imx8-isi-cap.c Guoniu.zhou 2019-01-21 1316 case V4L2_SEL_TGT_CROP: 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1317 if (sel->pad != MXC_ISI_SD_PAD_SOURCE) { 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1318 /* The pipeline support cropping on the source only. */ 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1319 ret = -EINVAL; 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1320 break; 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1321 } 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1322 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1323 /* The source crop is bound by the sink compose. */ 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1324 rect = mxc_isi_pipe_get_pad_compose(pipe, cfg, sel->which, 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1325 MXC_ISI_SD_PAD_SINK); 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1326 sel->r.left = clamp_t(s32, sel->r.left, 0, rect->width - 1); 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1327 sel->r.top = clamp_t(s32, sel->r.top, 0, rect->height - 1); 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1328 sel->r.width = clamp(sel->r.width, MXC_ISI_MIN_WIDTH, 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1329 rect->width - sel->r.left); 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1330 sel->r.height = clamp(sel->r.height, MXC_ISI_MIN_HEIGHT, 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1331 rect->height - sel->r.top); 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1332 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1333 rect = mxc_isi_pipe_get_pad_crop(pipe, cfg, sel->which, 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1334 MXC_ISI_SD_PAD_SOURCE); 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1335 *rect = sel->r; 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1336 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1337 /* Propagate the crop rectangle to the source pad. */ 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1338 format = mxc_isi_pipe_get_pad_format(pipe, cfg, sel->which, 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1339 MXC_ISI_SD_PAD_SOURCE); 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1340 format->width = sel->r.width; 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1341 format->height = sel->r.height; b5b373a37727bb drivers/staging/media/imx/imx8-isi-cap.c Guoniu.zhou 2019-01-21 1342 break; 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1343 b5b373a37727bb drivers/staging/media/imx/imx8-isi-cap.c Guoniu.zhou 2019-01-21 1344 case V4L2_SEL_TGT_COMPOSE: 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1345 if (sel->pad != MXC_ISI_SD_PAD_SINK) { 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1346 /* Composing is supported on the sink only. */ 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1347 ret = -EINVAL; 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1348 break; 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1349 } 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1350 c24b3c44b1d2c7 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-04-19 1351 f = &pipe->formats[MXC_ISI_SD_PAD_SOURCE]; 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1352 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1353 /* The sink crop is bound by the sink format downscaling only). */ 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1354 format = mxc_isi_pipe_get_pad_format(pipe, cfg, sel->which, 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1355 MXC_ISI_SD_PAD_SINK); 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1356 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1357 sel->r.left = 0; 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1358 sel->r.top = 0; 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1359 sel->r.width = clamp(sel->r.width, MXC_ISI_MIN_WIDTH, 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1360 format->width); 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1361 sel->r.height = clamp(sel->r.height, MXC_ISI_MIN_HEIGHT, 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1362 format->height); 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1363 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1364 rect = mxc_isi_pipe_get_pad_compose(pipe, cfg, sel->which, 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1365 MXC_ISI_SD_PAD_SINK); 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1366 *rect = sel->r; 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1367 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1368 /* Propagate the compose rectangle to the source pad. */ 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1369 rect = mxc_isi_pipe_get_pad_crop(pipe, cfg, sel->which, 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1370 MXC_ISI_SD_PAD_SOURCE); 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1371 rect->left = 0; 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1372 rect->top = 0; 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1373 rect->width = sel->r.width; 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1374 rect->height = sel->r.height; 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1375 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1376 format = mxc_isi_pipe_get_pad_format(pipe, cfg, sel->which, 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1377 MXC_ISI_SD_PAD_SOURCE); 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1378 format->width = sel->r.width; 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1379 format->height = sel->r.height; b5b373a37727bb drivers/staging/media/imx/imx8-isi-cap.c Guoniu.zhou 2019-01-21 1380 break; 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1381 b5b373a37727bb drivers/staging/media/imx/imx8-isi-cap.c Guoniu.zhou 2019-01-21 1382 default: 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1383 ret = -EINVAL; 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1384 break; b5b373a37727bb drivers/staging/media/imx/imx8-isi-cap.c Guoniu.zhou 2019-01-21 1385 } b5b373a37727bb drivers/staging/media/imx/imx8-isi-cap.c Guoniu.zhou 2019-01-21 1386 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1387 mutex_unlock(&pipe->lock); 974e3749f89ef0 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1388 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1389 if (ret < 0) 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1390 return ret; 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1391 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1392 if (sel->which == V4L2_SUBDEV_FORMAT_ACTIVE) { 7180b8d137a989 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-04-19 1393 spin_lock_irqsave(&pipe->slock, flags); 07054221290d22 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1394 /* 07054221290d22 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1395 * FIXME: Support moving the crop rectangle when the pipeline 07054221290d22 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1396 * is streaming. 07054221290d22 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1397 */ 7180b8d137a989 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-04-19 1398 spin_unlock_irqrestore(&pipe->slock, flags); b5b373a37727bb drivers/staging/media/imx/imx8-isi-cap.c Guoniu.zhou 2019-01-21 1399 } b5b373a37727bb drivers/staging/media/imx/imx8-isi-cap.c Guoniu.zhou 2019-01-21 1400 7180b8d137a989 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-04-19 1401 dev_dbg(pipe->isi->dev, "%s, target %#x: (%d,%d)/%dx%d", __func__, 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1402 sel->target, sel->r.left, sel->r.top, sel->r.width, 6c1513c3a92617 drivers/staging/media/imx/imx8-isi-pipe.c Laurent Pinchart 2021-05-17 1403 sel->r.height); b5b373a37727bb drivers/staging/media/imx/imx8-isi-cap.c Guoniu.zhou 2019-01-21 1404 b5b373a37727bb drivers/staging/media/imx/imx8-isi-cap.c Guoniu.zhou 2019-01-21 1405 return 0; b5b373a37727bb drivers/staging/media/imx/imx8-isi-cap.c Guoniu.zhou 2019-01-21 1406 } b5b373a37727bb drivers/staging/media/imx/imx8-isi-cap.c Guoniu.zhou 2019-01-21 1407 :::::: The code at line 1307 was first introduced by commit :::::: c24b3c44b1d2c7e81b3fd6ef41afcfdbe76c05b8 staging: media: imx: isi: pipe: Store subdev formats in array :::::: TO: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com&gt; :::::: CC: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com&gt; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org