[kbuild-all] [iwlwifi-chromeos:chromeos-kernelupstream-5.14-rc6__master 1219/1223] drivers/media/pci/intel/ipu6/../ipu-isys-tpg.c:143:27: error: passing argument 2 of '__ipu_isys_get_ffmt' from incompatible pointer type

tree: https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/chromeos.git chromeos-kernelupstream-5.14-rc6__master head: 559fc6b20030249e9152cf36ab505d8d6a828ff2 commit: e56ec43c5d29d49e540a3883be0a5d2ffa441103 [1219/1223] FIXUP:media: v4l2-subdev: add subdev-wide state struct config: x86_64-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/chromeos.git/comm... git remote add iwlwifi-chromeos https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/chromeos.git git fetch --no-tags iwlwifi-chromeos chromeos-kernelupstream-5.14-rc6__master git checkout e56ec43c5d29d49e540a3883be0a5d2ffa441103 # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): drivers/media/pci/intel/ipu6/../ipu-isys-tpg.c: In function 'tpg_set_ffmt': 143 | *__ipu_isys_get_ffmt(sd, cfg, fmt->pad, fmt->which) = fmt->format; | ^~~ | | | struct v4l2_subdev_pad_config * In file included from drivers/media/pci/intel/ipu6/../ipu-isys-csi2.h:11, from drivers/media/pci/intel/ipu6/../ipu-isys.h:17, from drivers/media/pci/intel/ipu6/../ipu-isys-tpg.c:13: drivers/media/pci/intel/ipu6/../ipu-isys-subdev.h:92:28: note: expected 'struct v4l2_subdev_state *' but argument is of type 'struct v4l2_subdev_pad_config *' 92 | struct v4l2_mbus_framefmt *__ipu_isys_get_ffmt(struct v4l2_subdev *sd, | ^~~~~~~~~~~~~~~~~~~ drivers/media/pci/intel/ipu6/../ipu-isys-tpg.c: In function 'ipu_isys_tpg_set_ffmt': 157 | rval = __ipu_isys_subdev_set_ffmt(sd, cfg, fmt); | ^~~ | | | struct v4l2_subdev_pad_config * In file included from drivers/media/pci/intel/ipu6/../ipu-isys-csi2.h:11, from drivers/media/pci/intel/ipu6/../ipu-isys.h:17, from drivers/media/pci/intel/ipu6/../ipu-isys-tpg.c:13: drivers/media/pci/intel/ipu6/../ipu-isys-subdev.h:114:37: note: expected 'struct v4l2_subdev_state *' but argument is of type 'struct v4l2_subdev_pad_config *' 114 | struct v4l2_subdev_state *state, | ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~ drivers/media/pci/intel/ipu6/../ipu-isys-tpg.c: At top level: drivers/media/pci/intel/ipu6/../ipu-isys-tpg.c:189:13: error: initialization of 'int (*)(struct v4l2_subdev *, struct v4l2_subdev_state *, struct v4l2_subdev_format *)' from incompatible pointer type 'int (*)(struct v4l2_subdev *, struct v4l2_subdev_pad_config *, struct v4l2_subdev_format *)' [-Werror=incompatible-pointer-types] 189 | .set_fmt = ipu_isys_tpg_set_ffmt, | ^~~~~~~~~~~~~~~~~~~~~ drivers/media/pci/intel/ipu6/../ipu-isys-tpg.c:189:13: note: (near initialization for 'tpg_sd_pad_ops.set_fmt') drivers/media/pci/intel/ipu6/../ipu-isys-tpg.c: In function 'ipu_isys_tpg_init': drivers/media/pci/intel/ipu6/../ipu-isys-tpg.c:268:20: error: assignment to 'void (*)(struct v4l2_subdev *, struct v4l2_subdev_state *, struct v4l2_subdev_format *)' from incompatible pointer type 'void (*)(struct v4l2_subdev *, struct v4l2_subdev_pad_config *, struct v4l2_subdev_format *)' [-Werror=incompatible-pointer-types] 268 | tpg->asd.set_ffmt = tpg_set_ffmt; | ^ cc1: some warnings being treated as errors vim +/__ipu_isys_get_ffmt +143 drivers/media/pci/intel/ipu6/../ipu-isys-tpg.c 03193a44d18182 Tianshu Qiu 2021-07-16 137 03193a44d18182 Tianshu Qiu 2021-07-16 138 static void tpg_set_ffmt(struct v4l2_subdev *sd, 03193a44d18182 Tianshu Qiu 2021-07-16 139 struct v4l2_subdev_pad_config *cfg, 03193a44d18182 Tianshu Qiu 2021-07-16 140 struct v4l2_subdev_format *fmt) 03193a44d18182 Tianshu Qiu 2021-07-16 141 { 03193a44d18182 Tianshu Qiu 2021-07-16 142 fmt->format.field = V4L2_FIELD_NONE; 03193a44d18182 Tianshu Qiu 2021-07-16 @143 *__ipu_isys_get_ffmt(sd, cfg, fmt->pad, fmt->which) = fmt->format; 03193a44d18182 Tianshu Qiu 2021-07-16 144 } 03193a44d18182 Tianshu Qiu 2021-07-16 145 03193a44d18182 Tianshu Qiu 2021-07-16 146 static int ipu_isys_tpg_set_ffmt(struct v4l2_subdev *sd, 03193a44d18182 Tianshu Qiu 2021-07-16 147 struct v4l2_subdev_pad_config *cfg, 03193a44d18182 Tianshu Qiu 2021-07-16 148 struct v4l2_subdev_format *fmt) 03193a44d18182 Tianshu Qiu 2021-07-16 149 { 03193a44d18182 Tianshu Qiu 2021-07-16 150 struct ipu_isys_tpg *tpg = to_ipu_isys_tpg(sd); 03193a44d18182 Tianshu Qiu 2021-07-16 151 __u32 code = tpg->asd.ffmt[TPG_PAD_SOURCE].code; 03193a44d18182 Tianshu Qiu 2021-07-16 152 unsigned int bpp = ipu_isys_mbus_code_to_bpp(code); 03193a44d18182 Tianshu Qiu 2021-07-16 153 s64 tpg_rate = ipu_isys_tpg_rate(tpg, bpp); 03193a44d18182 Tianshu Qiu 2021-07-16 154 int rval; 03193a44d18182 Tianshu Qiu 2021-07-16 155 03193a44d18182 Tianshu Qiu 2021-07-16 156 mutex_lock(&tpg->asd.mutex); 03193a44d18182 Tianshu Qiu 2021-07-16 @157 rval = __ipu_isys_subdev_set_ffmt(sd, cfg, fmt); 03193a44d18182 Tianshu Qiu 2021-07-16 158 mutex_unlock(&tpg->asd.mutex); 03193a44d18182 Tianshu Qiu 2021-07-16 159 03193a44d18182 Tianshu Qiu 2021-07-16 160 if (rval || fmt->which != V4L2_SUBDEV_FORMAT_ACTIVE) 03193a44d18182 Tianshu Qiu 2021-07-16 161 return rval; 03193a44d18182 Tianshu Qiu 2021-07-16 162 03193a44d18182 Tianshu Qiu 2021-07-16 163 v4l2_ctrl_s_ctrl_int64(tpg->pixel_rate, tpg_rate); 03193a44d18182 Tianshu Qiu 2021-07-16 164 03193a44d18182 Tianshu Qiu 2021-07-16 165 return 0; 03193a44d18182 Tianshu Qiu 2021-07-16 166 } 03193a44d18182 Tianshu Qiu 2021-07-16 167 :::::: The code at line 143 was first introduced by commit :::::: 03193a44d181823be57cf5e6f70a668691c10173 CHROMIUM: media: intel-ipu6: copy IPU6 driver from v5.4 branch :::::: TO: Tianshu Qiu <tian.shu.qiu(a)intel.com&gt; :::::: CC: Google Cont Rebase <goog-rebase-dev(a)semihalf.com&gt; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org