[kbuild-all] Re: [PATCH] tty: Add MOXA NPort Real TTY Driver

Hi "Johnson, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tty/tty-testing] [also build test WARNING on v5.8-rc5 next-20200714] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Johnson-CH-Chen/tty-Add-MOXA-NPo... base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing config: sparc64-randconfig-s032-20200715 (attached as .config) compiler: sparc64-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.2-49-g707c5017-dirty # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=sparc64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; sparse warnings: (new ones prefixed by >>) drivers/tty/npreal2.c:1624:38: sparse: sparse: Using plain integer as NULL pointer drivers/tty/npreal2.c:1897:34: sparse: sparse: Using plain integer as NULL pointer drivers/tty/npreal2.c:1914:21: sparse: sparse: Using plain integer as NULL pointer drivers/tty/npreal2.c:1984:46: sparse: sparse: Using plain integer as NULL pointer drivers/tty/npreal2.c:2261:17: sparse: expected void const volatile [noderef] __user * drivers/tty/npreal2.c:2265:17: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __user * @@ got unsigned long * @@ drivers/tty/npreal2.c:2265:17: sparse: expected void const volatile [noderef] __user * drivers/tty/npreal2.c:2265:17: sparse: got unsigned long * drivers/tty/npreal2.c:2319:21: sparse: expected void const volatile [noderef] __user * drivers/tty/npreal2.c:2319:62: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __user * @@ got int * @@ drivers/tty/npreal2.c:2319:62: sparse: expected void const volatile [noderef] __user * drivers/tty/npreal2.c:2319:62: sparse: got int * drivers/tty/npreal2.c:2320:25: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __user * @@ got int * @@ drivers/tty/npreal2.c:2320:25: sparse: expected void const volatile [noderef] __user * drivers/tty/npreal2.c:2320:25: sparse: got int * drivers/tty/npreal2.c:2321:25: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __user * @@ got int * @@ drivers/tty/npreal2.c:2321:25: sparse: expected void const volatile [noderef] __user * drivers/tty/npreal2.c:2321:25: sparse: got int * drivers/tty/npreal2.c:2322:25: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __user * @@ got int * @@ drivers/tty/npreal2.c:2322:25: sparse: expected void const volatile [noderef] __user * drivers/tty/npreal2.c:2322:25: sparse: got int * drivers/tty/npreal2.c:2323:25: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __user * @@ got int * @@ drivers/tty/npreal2.c:2323:25: sparse: expected void const volatile [noderef] __user * drivers/tty/npreal2.c:2323:25: sparse: got int * drivers/tty/npreal2.c:2324:25: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __user * @@ got int * @@ drivers/tty/npreal2.c:2324:25: sparse: expected void const volatile [noderef] __user * drivers/tty/npreal2.c:2324:25: sparse: got int * drivers/tty/npreal2.c:2329:17: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __user * @@ got int * @@ drivers/tty/npreal2.c:2329:17: sparse: expected void const volatile [noderef] __user * drivers/tty/npreal2.c:2329:17: sparse: got int * drivers/tty/npreal2.c:2330:17: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __user * @@ got int * @@ drivers/tty/npreal2.c:2330:17: sparse: expected void const volatile [noderef] __user * drivers/tty/npreal2.c:2330:17: sparse: got int * drivers/tty/npreal2.c:2331:17: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __user * @@ got int * @@ drivers/tty/npreal2.c:2331:17: sparse: expected void const volatile [noderef] __user * drivers/tty/npreal2.c:2331:17: sparse: got int * drivers/tty/npreal2.c:2332:17: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const volatile [noderef] __user * @@ got int * @@ drivers/tty/npreal2.c:2332:17: sparse: expected void const volatile [noderef] __user * drivers/tty/npreal2.c:2332:17: sparse: got int * drivers/tty/npreal2.c:2570:35: sparse: expected void [noderef] __user *to drivers/tty/npreal2.c:2591:57: sparse: expected void const [noderef] __user *from drivers/tty/npreal2.c:2591:57: sparse: got void * drivers/tty/npreal2.c:2720:35: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] __user *to @@ got void * @@ drivers/tty/npreal2.c:2720:35: sparse: expected void [noderef] __user *to drivers/tty/npreal2.c:2720:35: sparse: got void * drivers/tty/npreal2.c:2734:56: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void const [noderef] __user *from @@ got void * @@ drivers/tty/npreal2.c:2734:56: sparse: expected void const [noderef] __user *from drivers/tty/npreal2.c:2734:56: sparse: got void * drivers/tty/npreal2.c:2803:34: sparse: expected void [noderef] __user *to drivers/tty/npreal2.c:2831:38: sparse: expected void [noderef] __user *to drivers/tty/npreal2.c:2899:38: sparse: expected void const [noderef] __user *from drivers/tty/npreal2.c:2951:23: sparse: got long ( * )( ... ) vim +1107 drivers/tty/npreal2.c 1089 1090 static int npreal_get_serial_info(struct npreal_struct *info, struct serial_struct *retinfo) 1091 { 1092 struct serial_struct tmp; 1093 1094 if (!retinfo) 1095 return -EFAULT; 1096 1097 memset(&tmp, 0, sizeof(tmp)); 1098 tmp.type = info->type; 1099 tmp.line = info->port; 1100 tmp.flags = info->flags; 1101 tmp.close_delay = info->close_delay; 1102 tmp.closing_wait = info->closing_wait; 1103 tmp.custom_divisor = info->custom_divisor; 1104 tmp.baud_base = info->baud_base; 1105 tmp.hub6 = 0; 1106 1108 return -EFAULT; 1109 else 1110 return 0; 1111 } 1112 1113 static int npreal_set_serial_info(struct npreal_struct *info, struct serial_struct *new_info) 1114 { 1115 struct serial_struct new_serial; 1116 int rsp_length = RSP_BUFFER_SIZE; 1117 int retval = 0; 1118 unsigned int flags; 1119 char rsp_buffer[RSP_BUFFER_SIZE]; 1120 1121 1123 return -EFAULT; 1124 1125 flags = info->flags & ASYNC_SPD_MASK; 1126 1127 if (!capable(CAP_SYS_ADMIN)) { 1128 if ((new_serial.close_delay != info->close_delay) || 1129 ((new_serial.flags & ~ASYNC_USR_MASK) != (info->flags & ~ASYNC_USR_MASK))) 1130 return -EPERM; 1131 1132 info->flags = ((info->flags & ~ASYNC_USR_MASK) | 1133 (new_serial.flags & ASYNC_USR_MASK)); 1134 } else { 1135 info->flags = ((info->flags & ~ASYNC_FLAGS) | (new_serial.flags & ASYNC_FLAGS)); 1136 info->close_delay = new_serial.close_delay * HZ / 100; 1137 1138 if (new_serial.closing_wait == ASYNC_CLOSING_WAIT_NONE) 1139 info->closing_wait = ASYNC_CLOSING_WAIT_NONE; 1140 else 1141 info->closing_wait = new_serial.closing_wait * HZ / 100; 1142 } 1143 1144 info->type = new_serial.type; 1145 set_common_xmit_fifo_size(info, info->net_node); 1146 1147 if (info->flags & ASYNC_INITIALIZED) { 1148 if (flags != (info->flags & ASYNC_SPD_MASK)) 1150 1151 if (info->net_node) 1152 npreal_set_tx_fifo_command_done(info, info->net_node, rsp_buffer, 1153 &rsp_length); 1154 1155 } 1156 1157 info->custom_divisor = new_serial.custom_divisor; 1158 1159 if (info->custom_divisor == 0) 1160 info->baud_base = 921600L; 1161 else 1162 info->baud_base = new_serial.baud_base; 1163 1164 return retval; 1165 } 1166 1167 /** 1168 * npreal_get_lsr_info() - get line status register info 1169 * 1170 * Let user call ioctl() to get info when the UART physically is emptied. 1171 * On bus types like RS485, the transmitter must release the bus after 1172 * transmitting. This must be done when the transmit shift register is 1173 * empty, not be done when the transmit holding register is empty. 1174 * This functionality allows an RS485 driver to be written in user space. 1175 * 1176 * Always return 0 when function is ended. 1177 */ 1178 static int npreal_get_lsr_info(struct npreal_struct *info, 1179 unsigned int *value) 1180 { 1181 unsigned int result = 0; 1182 1183 if (npreal_wait_oqueue(info, 0) == 0) 1184 result = TIOCSER_TEMT; 1185 1187 1188 return 0; 1189 } 1190 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org