On Wed 15-12-21 12:47:16, kernel test robot wrote:
Hi Michal,
I love your patch! Perhaps something to improve:
[auto build test WARNING on hnaz-mm/master]
url:
https://github.com/0day-ci/linux/commits/Michal-Hocko/mm-memory_hotplug-m...
base:
https://github.com/hnaz/linux-mm master
config: ia64-defconfig
(
https://download.01.org/0day-ci/archive/20211215/202112151219.xAI8NaQR-lk...)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/65c560a3ac2561750c1dc71213f042e66...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Michal-Hocko/mm-memory_hotplug-make-arch_alloc_nodedata-independent-on-CONFIG_MEMORY_HOTPLUG/20211214-190817
git checkout 65c560a3ac2561750c1dc71213f042e660b9bbc0
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir
ARCH=ia64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> WARNING: modpost: vmlinux.o(.text+0x566a2): Section mismatch in reference from
the function arch_alloc_nodedata() to the function .init.text:memblock_alloc_try_nid()
The function arch_alloc_nodedata() references
the function __init memblock_alloc_try_nid().
This is often because arch_alloc_nodedata lacks a __init
annotation or the annotation of memblock_alloc_try_nid is wrong.
Thanks for the report. This should do the trick. I will fold it into the
patch.
diff --git a/arch/ia64/mm/discontig.c b/arch/ia64/mm/discontig.c
index b4c46925792f..dd0cf4834eaa 100644
--- a/arch/ia64/mm/discontig.c
+++ b/arch/ia64/mm/discontig.c
@@ -608,7 +608,7 @@ void __init paging_init(void)
zero_page_memmap_ptr = virt_to_page(ia64_imva(empty_zero_page));
}
-pg_data_t *arch_alloc_nodedata(int nid)
+pg_data_t * __init arch_alloc_nodedata(int nid)
{
unsigned long size = compute_pernodesize(nid);
--
Michal Hocko
SUSE Labs