10:55 p.m.
Hi Roopa,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
[also build test ERROR on net/master kselftest/next sparc-next/master linus/master
v5.7-rc6 next-20200518]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Roopa-Prabhu/Support-for-fdb-ECM...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
5cdfe8306631b2224e3f81fc5a1e2721c7a1948b
config: sh-polaris_defconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from net/ipv4/ip_tunnel_core.c:38:
include/net/vxlan.h: In function 'vxlan_fdb_nh_path_select':
> include/net/vxlan.h:496:8: error: implicit declaration of
function 'nexthop_path_fdb_result' [-Werror=implicit-function-declaration]
496 | nhc = nexthop_path_fdb_result(nh, hash);
| ^~~~~~~~~~~~~~~~~~~~~~~
> include/net/vxlan.h:496:6: warning: assignment to 'struct
fib_nh_common *' from 'int' makes pointer from integer without a cast
[-Wint-conversion]
496 | nhc = nexthop_path_fdb_result(nh, hash);
| ^
cc1: some warnings being treated as errors
vim +/nexthop_path_fdb_result +496 include/net/vxlan.h
489
490 static inline bool vxlan_fdb_nh_path_select(struct nexthop *nh,
491 int hash,
492 struct vxlan_rdst *rdst)
493 {
494 struct fib_nh_common *nhc;
495
496 nhc = nexthop_path_fdb_result(nh, hash);
497 if
(unlikely(!nhc))
498 return false;
499
500 switch (nhc->nhc_gw_family) {
501 case AF_INET:
502 rdst->remote_ip.sin.sin_addr.s_addr = nhc->nhc_gw.ipv4;
503 rdst->remote_ip.sa.sa_family = AF_INET;
504 break;
505 case AF_INET6:
506 rdst->remote_ip.sin6.sin6_addr = nhc->nhc_gw.ipv6;
507 rdst->remote_ip.sa.sa_family = AF_INET6;
508 break;
509 }
510
511 return true;
512 }
513
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org