Hi All,
On 2/9/21 2:52 AM, kernel test robot wrote:
Hi Maximilian,
FYI, the error/warning still remains.
tree:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 61556703b610a104de324e4f061dc6cf7b218b46
commit: f23027ca3d48b6f93c5994069fb25b73539fdf34 platform/surface: Move Surface 3 WMI
driver to platform/surface
date: 4 months ago
config: i386-randconfig-r016-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
#
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout f23027ca3d48b6f93c5994069fb25b73539fdf34
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/platform/surface/surface3-wmi.c: In function 's3_wmi_query_block':
>> drivers/platform/surface/surface3-wmi.c:60:14: warning: variable 'status'
set but not used [-Wunused-but-set-variable]
60 | acpi_status status;
| ^~~~~~
There is a fix for this in pdx86/for-next, so this will be fixed in 5.12 .
Regards,
Hans
vim +/status +60 drivers/platform/surface/surface3-wmi.c
3dda3b3798f96d drivers/platform/x86/surface3-wmi.c Benjamin Tissoires 2016-11-25 56
3dda3b3798f96d drivers/platform/x86/surface3-wmi.c Benjamin Tissoires 2016-11-25 57
static int s3_wmi_query_block(const char *guid, int instance, int *ret)
3dda3b3798f96d drivers/platform/x86/surface3-wmi.c Benjamin Tissoires 2016-11-25 58 {
83da6b59919a71 drivers/platform/x86/surface3-wmi.c Andy Shevchenko 2016-12-15 59
struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL };
3dda3b3798f96d drivers/platform/x86/surface3-wmi.c Benjamin Tissoires 2016-11-25 @60
acpi_status status;
3dda3b3798f96d drivers/platform/x86/surface3-wmi.c Benjamin Tissoires 2016-11-25 61
union acpi_object *obj;
83da6b59919a71 drivers/platform/x86/surface3-wmi.c Andy Shevchenko 2016-12-15 62
int error = 0;
3dda3b3798f96d drivers/platform/x86/surface3-wmi.c Benjamin Tissoires 2016-11-25 63
3dda3b3798f96d drivers/platform/x86/surface3-wmi.c Benjamin Tissoires 2016-11-25 64
mutex_lock(&s3_wmi_lock);
3dda3b3798f96d drivers/platform/x86/surface3-wmi.c Benjamin Tissoires 2016-11-25 65
status = wmi_query_block(guid, instance, &output);
3dda3b3798f96d drivers/platform/x86/surface3-wmi.c Benjamin Tissoires 2016-11-25 66
3dda3b3798f96d drivers/platform/x86/surface3-wmi.c Benjamin Tissoires 2016-11-25 67
obj = output.pointer;
3dda3b3798f96d drivers/platform/x86/surface3-wmi.c Benjamin Tissoires 2016-11-25 68
3dda3b3798f96d drivers/platform/x86/surface3-wmi.c Benjamin Tissoires 2016-11-25 69 if
(!obj || obj->type != ACPI_TYPE_INTEGER) {
3dda3b3798f96d drivers/platform/x86/surface3-wmi.c Benjamin Tissoires 2016-11-25 70
if (obj) {
3dda3b3798f96d drivers/platform/x86/surface3-wmi.c Benjamin Tissoires 2016-11-25 71
pr_err("query block returned object type: %d - buffer length:%d\n",
3dda3b3798f96d drivers/platform/x86/surface3-wmi.c Benjamin Tissoires 2016-11-25 72
obj->type,
3dda3b3798f96d drivers/platform/x86/surface3-wmi.c Benjamin Tissoires 2016-11-25 73
obj->type == ACPI_TYPE_BUFFER ?
3dda3b3798f96d drivers/platform/x86/surface3-wmi.c Benjamin Tissoires 2016-11-25 74
obj->buffer.length : 0);
3dda3b3798f96d drivers/platform/x86/surface3-wmi.c Benjamin Tissoires 2016-11-25 75
}
83da6b59919a71 drivers/platform/x86/surface3-wmi.c Andy Shevchenko 2016-12-15 76
error = -EINVAL;
83da6b59919a71 drivers/platform/x86/surface3-wmi.c Andy Shevchenko 2016-12-15 77
goto out_free_unlock;
3dda3b3798f96d drivers/platform/x86/surface3-wmi.c Benjamin Tissoires 2016-11-25 78 }
3dda3b3798f96d drivers/platform/x86/surface3-wmi.c Benjamin Tissoires 2016-11-25 79
*ret = obj->integer.value;
83da6b59919a71 drivers/platform/x86/surface3-wmi.c Andy Shevchenko 2016-12-15 80
out_free_unlock:
3dda3b3798f96d drivers/platform/x86/surface3-wmi.c Benjamin Tissoires 2016-11-25 81
kfree(obj);
3dda3b3798f96d drivers/platform/x86/surface3-wmi.c Benjamin Tissoires 2016-11-25 82
mutex_unlock(&s3_wmi_lock);
83da6b59919a71 drivers/platform/x86/surface3-wmi.c Andy Shevchenko 2016-12-15 83
return error;
3dda3b3798f96d drivers/platform/x86/surface3-wmi.c Benjamin Tissoires 2016-11-25 84 }
3dda3b3798f96d drivers/platform/x86/surface3-wmi.c Benjamin Tissoires 2016-11-25 85
:::::: The code at line 60 was first introduced by commit
:::::: 3dda3b3798f96d2974b5f60811142d3e25547807 platform/x86: Add custom surface3
platform device for controlling LID
:::::: TO: Benjamin Tissoires <benjamin.tissoires(a)redhat.com>
:::::: CC: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org