[kbuild-all] Re: [PATCH net-next 2/4] net: phy: dp83869: Set opmode from straps

kbuild On 5/19/20 12:19 PM, kbuild test robot wrote: > Hi Dan, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on net-next/master] > [also build test WARNING on robh/for-next sparc-next/master net/master linus/master v5.7-rc6 next-20200518] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the system. BTW, we also suggest to use '--base' option to specify the > base tree in git format-patch, please see https://stackoverflow.com/a/37406982] > > url: https://github.com/0day-ci/linux/commits/Dan-Murphy/DP83869-Enhancements/... > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 5cdfe8306631b2224e3f81fc5a1e2721c7a1948b > config: sh-allmodconfig (attached as .config) > compiler: sh4-linux-gcc (GCC) 9.3.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kbuild test robot <lkp(a)intel.com&gt; > > All warnings (new ones prefixed by >>, old ones prefixed by <<): > > drivers/net/phy/dp83869.c: In function 'dp83869_set_strapped_mode': > > > drivers/net/phy/dp83869.c:171:10: warning: comparison is always false due to limited range of data type [-Wtype-limits] > 171 | if (val < 0) This looks to be a false positive. phy_read_mmd will return an errno or a value from 0->15