[kbuild-all] [intel-linux-intel-lts:5.4/preempt-rt 7252/16579] drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:6293:6: warning: no previous prototype for 'stmmac_clean_all_tx_rings'

Hi Ong, FYI, the error/warning still remains. tree: https://github.com/intel/linux-intel-lts.git 5.4/preempt-rt head: b428b2464d25f05987f834bbd84273b8d6859495 commit: c2198809408cf67767651a83f3024c6340602479 [7252/16579] net: stmmac: clean all pending Tx buffers during suspend config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel/linux-intel-lts/commit/c2198809408cf67767651a83f... git remote add intel-linux-intel-lts https://github.com/intel/linux-intel-lts.git git fetch --no-tags intel-linux-intel-lts 5.4/preempt-rt git checkout c2198809408cf67767651a83f3024c6340602479 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): arch/m68k/include/asm/raw_io.h:466:3: note: in expansion of macro 'rom_out_le16' 466 | rom_out_le16(port, *buf++); | ^~~~~~~~~~~~ In file included from include/linux/err.h:5, from include/linux/clk.h:12, from drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:17: include/linux/scatterlist.h: In function 'sg_set_buf': arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra] 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ In file included from arch/m68k/include/asm/bug.h:32, from include/linux/bug.h:5, from include/linux/thread_info.h:12, from include/asm-generic/preempt.h:5, from ./arch/m68k/include/generated/asm/preempt.h:1, from include/linux/preempt.h:78, from arch/m68k/include/asm/irqflags.h:6, from include/linux/irqflags.h:16, from arch/m68k/include/asm/atomic.h:6, from include/linux/atomic.h:7, from include/linux/mutex.h:18, from include/linux/notifier.h:14, from include/linux/clk.h:14, from drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:17: include/linux/dma-mapping.h: In function 'dma_map_resource': arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra] 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/asm-generic/bug.h:139:27: note: in definition of macro 'WARN_ON_ONCE' 139 | int __ret_warn_once = !!(condition); \ | ^~~~~~~~~ arch/m68k/include/asm/page_mm.h:170:25: note: in expansion of macro 'virt_addr_valid' 170 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn)) | ^~~~~~~~~~~~~~~ include/linux/dma-mapping.h:355:19: note: in expansion of macro 'pfn_valid' 355 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr)))) | ^~~~~~~~~ drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_hwtstamp_set': drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:555:7: warning: variable 'xmac' set but not used [-Wunused-but-set-variable] 555 | bool xmac; | ^~~~ drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: At top level: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1403:6: warning: no previous prototype for 'stmmac_alloc_rx_buffers' [-Wmissing-prototypes] 1403 | bool stmmac_alloc_rx_buffers(struct stmmac_rx_queue *rx_q, u32 count) | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_alloc_rx_buffers': drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1429:13: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] 1429 | while (--i >= 0) | ^~ drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function 'init_dma_rx_desc_rings': drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1537:15: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] 1537 | while (queue >= 0) { | ^~ In file included from include/linux/printk.h:327, from include/linux/kernel.h:15, from include/linux/clk.h:13, from drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:17: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_rx': drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:4642:27: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 6 has type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=] 4642 | netdev_dbg(priv->dev, "\tdesc: %p [entry %d] buff=0x%llx\n", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 4643 | p, entry, buf->addr); | ~~~~~~~~~ | | | dma_addr_t {aka unsigned int} include/linux/dynamic_debug.h:125:15: note: in definition of macro '__dynamic_func_call' 125 | func(&id, ##__VA_ARGS__); \ | ^~~~~~~~~~~ include/linux/dynamic_debug.h:161:2: note: in expansion of macro '_dynamic_func_call' 161 | _dynamic_func_call(fmt, __dynamic_netdev_dbg, \ | ^~~~~~~~~~~~~~~~~~ include/linux/netdevice.h:4759:2: note: in expansion of macro 'dynamic_netdev_dbg' 4759 | dynamic_netdev_dbg(__dev, format, ##args); \ | ^~~~~~~~~~~~~~~~~~ drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:4642:5: note: in expansion of macro 'netdev_dbg' 4642 | netdev_dbg(priv->dev, "\tdesc: %p [entry %d] buff=0x%llx\n", | ^~~~~~~~~~ drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:4642:60: note: format string is defined here 4642 | netdev_dbg(priv->dev, "\tdesc: %p [entry %d] buff=0x%llx\n", | ~~~^ | | | long long unsigned int | %x drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_common_interrupt': drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:5007:6: warning: variable 'queues_count' set but not used [-Wunused-but-set-variable] 5007 | u32 queues_count; | ^~~~~~~~~~~~ drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: At top level: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:5615:5: warning: no previous prototype for 'stmmac_xdp_xmit' [-Wmissing-prototypes] 5615 | int stmmac_xdp_xmit(struct net_device *dev, int n, struct xdp_frame **frames, | ^~~~~~~~~~~~~~~ 6293 | void stmmac_clean_all_tx_rings(struct stmmac_priv *priv) | ^~~~~~~~~~~~~~~~~~~~~~~~~ Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for NEED_MULTIPLE_NODES Depends on DISCONTIGMEM || NUMA Selected by - SINGLE_MEMORY_CHUNK && MMU vim +/stmmac_clean_all_tx_rings +6293 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c 6292 6294 { 6295 u32 tx_count = priv->plat->tx_queues_to_use; 6296 u32 queue; 6297 6298 for (queue = 0; queue < tx_count; queue++) { 6299 struct stmmac_tx_queue *tx_q = get_tx_queue(priv, queue); 6300 6301 stmmac_clean_tx_queue(priv, tx_q); 6302 } 6303 } 6304 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org