4:10 a.m.
Hi Christoph,
I love your patch! Yet something to improve:
[auto build test ERROR on next-20200707]
[cannot apply to powerpc/next hp-parisc/for-next s390/features sparc-next/master
sparc/master tip/x86/core iommu/next char-misc/char-misc-testing linus/master ia64/next
v5.8-rc4 v5.8-rc3 v5.8-rc2 v5.8-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Christoph-Hellwig/dma-mapping-mo...
base: 5b2a702f85b3285fcde0309aadacc13a36c70fc7
config: x86_64-randconfig-r004-20200709 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project
02946de3802d3bc65bc9f2eb9b8d4969b5a7add8)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
> drivers/misc/mic/bus/vop_bus.c:148:12: error: no member named
'dma_ops' in 'struct device'
vdev->dev.dma_ops =
dma_ops;
~~~~~~~~~ ^
> drivers/misc/mic/bus/vop_bus.c:150:27: warning: shift count >=
width of type [-Wshift-count-overflow]
dma_set_mask(&vdev->dev,
DMA_BIT_MASK(64));
^~~~~~~~~~~~~~~~
include/linux/dma-mapping.h:139:54: note: expanded from macro 'DMA_BIT_MASK'
#define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
^ ~~~
1 warning and 1 error generated.
vim +148 drivers/misc/mic/bus/vop_bus.c
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 131
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 132 struct vop_device *
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 133 vop_register_device(struct device *pdev,
int id,
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 134 const struct dma_map_ops *dma_ops,
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 135 struct vop_hw_ops *hw_ops, u8 dnode,
struct mic_mw *aper,
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 136 struct dma_chan *chan)
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 137 {
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 138 int ret;
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 139 struct vop_device *vdev;
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 140
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 141 vdev = kzalloc(sizeof(*vdev),
GFP_KERNEL);
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 142 if (!vdev)
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 143 return ERR_PTR(-ENOMEM);
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 144
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 145 vdev->dev.parent = pdev;
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 146 vdev->id.device = id;
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 147 vdev->id.vendor = VOP_DEV_ANY_ID;
5657933dbb6e25 Bart Van Assche 2017-01-20 @148 vdev->dev.dma_ops = dma_ops;
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 149 vdev->dev.dma_mask =
&vdev->dev.coherent_dma_mask;
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 @150 dma_set_mask(&vdev->dev,
DMA_BIT_MASK(64));
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 151 vdev->dev.release = vop_release_dev;
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 152 vdev->hw_ops = hw_ops;
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 153 vdev->dev.bus = &vop_bus;
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 154 vdev->dnode = dnode;
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 155 vdev->aper = aper;
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 156 vdev->dma_ch = chan;
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 157 vdev->index = dnode - 1;
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 158 dev_set_name(&vdev->dev,
"vop-dev%u", vdev->index);
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 159 /*
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 160 * device_register() causes the bus
infrastructure to look for a
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 161 * matching driver.
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 162 */
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 163 ret =
device_register(&vdev->dev);
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 164 if (ret)
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 165 goto free_vdev;
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 166 return vdev;
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 167 free_vdev:
5fbe9f35dfcd83 Arvind Yadav 2018-03-12 168 put_device(&vdev->dev);
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 169 return ERR_PTR(ret);
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 170 }
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 171 EXPORT_SYMBOL_GPL(vop_register_device);
a19ddd6fd260d6 Sudeep Dutt 2016-02-08 172
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org