[kbuild-all] Re: [PATCH v2 15/16] backlight: make of_find_backlight_by_node() static

Hi Sam, I love your patch! Yet something to improve: [auto build test ERROR on tegra-drm/drm/tegra/for-next] [also build test ERROR on pwm/for-next linus/master v5.7-rc5] [cannot apply to backlight/for-backlight-next next-20200515] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Sam-Ravnborg/backlight-updates/2... base: git://anongit.freedesktop.org/tegra/linux.git drm/tegra/for-next config: arm-randconfig-r011-20200517 (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=arm If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>, old ones prefixed by <<): drivers/gpu/drm/tilcdc/tilcdc_panel.c: In function 'panel_probe': 324 | panel_mod->backlight = of_find_backlight_by_node(bl_node); | ^~~~~~~~~~~~~~~~~~~~~~~~~ | of_find_i2c_adapter_by_node 324 | panel_mod->backlight = of_find_backlight_by_node(bl_node); | ^ cc1: all warnings being treated as errors vim +324 drivers/gpu/drm/tilcdc/tilcdc_panel.c 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 303 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 304 static int panel_probe(struct platform_device *pdev) 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 305 { 18c44db8cafe9b Ezequiel Garcia 2014-09-02 306 struct device_node *bl_node, *node = pdev->dev.of_node; 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 307 struct panel_module *panel_mod; 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 308 struct tilcdc_module *mod; 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 309 struct pinctrl *pinctrl; 12778fc14301cf Ezequiel Garcia 2014-09-02 310 int ret; 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 311 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 312 /* bail out early if no DT data: */ 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 313 if (!node) { 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 314 dev_err(&pdev->dev, "device-tree data is missing\n"); 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 315 return -ENXIO; 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 316 } 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 317 971645d1fd734b Ezequiel Garcia 2014-09-02 318 panel_mod = devm_kzalloc(&pdev->dev, sizeof(*panel_mod), GFP_KERNEL); 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 319 if (!panel_mod) 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 320 return -ENOMEM; 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 321 18c44db8cafe9b Ezequiel Garcia 2014-09-02 322 bl_node = of_parse_phandle(node, "backlight", 0); 18c44db8cafe9b Ezequiel Garcia 2014-09-02 323 if (bl_node) { 18c44db8cafe9b Ezequiel Garcia 2014-09-02 @324 panel_mod->backlight = of_find_backlight_by_node(bl_node); 18c44db8cafe9b Ezequiel Garcia 2014-09-02 325 of_node_put(bl_node); 18c44db8cafe9b Ezequiel Garcia 2014-09-02 326 18c44db8cafe9b Ezequiel Garcia 2014-09-02 327 if (!panel_mod->backlight) 18c44db8cafe9b Ezequiel Garcia 2014-09-02 328 return -EPROBE_DEFER; 18c44db8cafe9b Ezequiel Garcia 2014-09-02 329 18c44db8cafe9b Ezequiel Garcia 2014-09-02 330 dev_info(&pdev->dev, "found backlight\n"); 18c44db8cafe9b Ezequiel Garcia 2014-09-02 331 } 18c44db8cafe9b Ezequiel Garcia 2014-09-02 332 26a5bd26499fba Uwe Kleine-König 2015-02-11 333 panel_mod->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable", 26a5bd26499fba Uwe Kleine-König 2015-02-11 334 GPIOD_OUT_LOW); d898ce03675fc0 Ezequiel Garcia 2014-09-02 335 if (IS_ERR(panel_mod->enable_gpio)) { d898ce03675fc0 Ezequiel Garcia 2014-09-02 336 ret = PTR_ERR(panel_mod->enable_gpio); d898ce03675fc0 Ezequiel Garcia 2014-09-02 337 dev_err(&pdev->dev, "failed to request enable GPIO\n"); d898ce03675fc0 Ezequiel Garcia 2014-09-02 338 goto fail_backlight; d898ce03675fc0 Ezequiel Garcia 2014-09-02 339 } d898ce03675fc0 Ezequiel Garcia 2014-09-02 340 26a5bd26499fba Uwe Kleine-König 2015-02-11 341 if (panel_mod->enable_gpio) d898ce03675fc0 Ezequiel Garcia 2014-09-02 342 dev_info(&pdev->dev, "found enable GPIO\n"); d898ce03675fc0 Ezequiel Garcia 2014-09-02 343 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 344 mod = &panel_mod->base; 7cdcce9f8b4c15 Guido Martínez 2014-06-17 345 pdev->dev.platform_data = mod; 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 346 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 347 tilcdc_module_init(mod, "panel", &panel_module_ops); 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 348 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 349 pinctrl = devm_pinctrl_get_select_default(&pdev->dev); 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 350 if (IS_ERR(pinctrl)) 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 351 dev_warn(&pdev->dev, "pins are not configured\n"); 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 352 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 353 panel_mod->timings = of_get_display_timings(node); 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 354 if (!panel_mod->timings) { 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 355 dev_err(&pdev->dev, "could not get panel timings\n"); 12778fc14301cf Ezequiel Garcia 2014-09-02 356 ret = -EINVAL; 7cdcce9f8b4c15 Guido Martínez 2014-06-17 357 goto fail_free; 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 358 } 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 359 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 360 panel_mod->info = of_get_panel_info(node); 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 361 if (!panel_mod->info) { 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 362 dev_err(&pdev->dev, "could not get panel info\n"); 12778fc14301cf Ezequiel Garcia 2014-09-02 363 ret = -EINVAL; 7cdcce9f8b4c15 Guido Martínez 2014-06-17 364 goto fail_timings; 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 365 } 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 366 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 367 return 0; 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 368 7cdcce9f8b4c15 Guido Martínez 2014-06-17 369 fail_timings: 7cdcce9f8b4c15 Guido Martínez 2014-06-17 370 display_timings_release(panel_mod->timings); 7cdcce9f8b4c15 Guido Martínez 2014-06-17 371 7cdcce9f8b4c15 Guido Martínez 2014-06-17 372 fail_free: 7cdcce9f8b4c15 Guido Martínez 2014-06-17 373 tilcdc_module_cleanup(mod); d898ce03675fc0 Ezequiel Garcia 2014-09-02 374 d898ce03675fc0 Ezequiel Garcia 2014-09-02 375 fail_backlight: 18c44db8cafe9b Ezequiel Garcia 2014-09-02 376 if (panel_mod->backlight) 18c44db8cafe9b Ezequiel Garcia 2014-09-02 377 put_device(&panel_mod->backlight->dev); 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 378 return ret; 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 379 } 0d4bbaf9f3e5b9 Rob Clark 2012-12-18 380 :::::: The code at line 324 was first introduced by commit :::::: 18c44db8cafe9bda4fcb51bfc05c1f1d7cefc44c drm/tilcdc: panel: Fix backlight devicetree support :::::: TO: Ezequiel Garcia <ezequiel(a)vanguardiasur.com.ar&gt; :::::: CC: Dave Airlie <airlied(a)redhat.com&gt; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org