12:59 a.m.
Hi Zhang,
I love your patch! Perhaps something to improve:
[auto build test WARNING on pm/linux-next]
[also build test WARNING on linus/master v5.11-rc3 next-20210115]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Zhang-Rui/ACPI-introduce-support...
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
#
https://github.com/0day-ci/linux/commit/48fba58f7364b11bb5f0ea5b2e3843c75...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Zhang-Rui/ACPI-introduce-support-for-FPDT-table/20210115-175532
git checkout 48fba58f7364b11bb5f0ea5b2e3843c7580c95dd
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> drivers/acpi/acpi_fpdt.c:230:6: warning: no previous prototype
for 'acpi_init_fpdt' [-Wmissing-prototypes]
230 | void
acpi_init_fpdt(void)
| ^~~~~~~~~~~~~~
In file included from include/linux/printk.h:7,
from include/linux/kernel.h:16,
from include/linux/list.h:9,
from include/linux/kobject.h:19,
from include/linux/of.h:17,
from include/linux/irqdomain.h:35,
from include/linux/acpi.h:13,
from drivers/acpi/acpi_fpdt.c:11:
drivers/acpi/acpi_fpdt.c: In function 'acpi_init_fpdt':
> include/linux/kern_levels.h:5:18: warning: too many arguments for
format [-Wformat-extra-args]
5 | #define KERN_SOH "\001" /* ASCII
Start Of Header */
| ^~~~~~
include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
14 | #define KERN_INFO KERN_SOH "6" /* informational */
| ^~~~~~~~
include/linux/printk.h:373:9: note: in expansion of macro 'KERN_INFO'
373 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~
drivers/acpi/acpi_fpdt.c:255:4: note: in expansion of macro 'pr_info'
255 | pr_info(FW_BUG, "Invalid subtable type %d found.\n",
| ^~~~~~~
vim +/acpi_init_fpdt +230 drivers/acpi/acpi_fpdt.c
229
230 void acpi_init_fpdt(void)
231 {
232 acpi_status status;
233 struct acpi_table_header *header;
234 struct fpdt_subtable_entry *subtable;
235 u32 offset = sizeof(*header);
236
237 status = acpi_get_table(ACPI_SIG_FPDT, 0, &header);
238
239 if (ACPI_FAILURE(status))
240 return;
241
242 fpdt_kobj = kobject_create_and_add("fpdt", acpi_kobj);
243 if (!fpdt_kobj)
244 return;
245
246 while (offset < header->length) {
247 subtable = (void *)header + offset;
248 switch (subtable->type) {
249 case SUBTABLE_FBPT:
250 case SUBTABLE_S3PT:
251 fpdt_process_subtable(subtable->address,
252 subtable->type);
253 break;
254 default:
255 pr_info(FW_BUG, "Invalid subtable type %d found.\n",
256 subtable->type);
257 return;
258 }
259 offset += sizeof(*subtable);
260 }
261 }
262
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org