7:06 a.m.
Hi Linus,
I love your patch! Yet something to improve:
[auto build test ERROR on gpio/for-next]
[also build test ERROR on v5.8-rc6 next-20200721]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Linus-Walleij/gpio-Retire-the-ex...
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next
config: x86_64-randconfig-r025-20200719 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project
8ed021382e6b1d00bf907ac595b5493a02355c2c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
> drivers/gpio/gpio-dln2.c:487:8: error: implicit declaration of
function 'gpiochip_irqchip_add' [-Werror,-Wimplicit-function-declaration]
ret = gpiochip_irqchip_add(&dln2->gpio, &dln2_gpio_irqchip, 0,
^
1 error generated.
vim +/gpiochip_irqchip_add +487 drivers/gpio/gpio-dln2.c
6732127f62a763 Daniel Baluta 2014-11-06 438
6732127f62a763 Daniel Baluta 2014-11-06 439 static int dln2_gpio_probe(struct
platform_device *pdev)
6732127f62a763 Daniel Baluta 2014-11-06 440 {
6732127f62a763 Daniel Baluta 2014-11-06 441 struct dln2_gpio *dln2;
6732127f62a763 Daniel Baluta 2014-11-06 442 struct device *dev = &pdev->dev;
6732127f62a763 Daniel Baluta 2014-11-06 443 int pins;
96b932b84409a5 Octavian Purdila 2014-12-11 444 int ret;
6732127f62a763 Daniel Baluta 2014-11-06 445
6732127f62a763 Daniel Baluta 2014-11-06 446 pins = dln2_gpio_get_pin_count(pdev);
6732127f62a763 Daniel Baluta 2014-11-06 447 if (pins < 0) {
6732127f62a763 Daniel Baluta 2014-11-06 448 dev_err(dev, "failed to get pin
count: %d\n", pins);
6732127f62a763 Daniel Baluta 2014-11-06 449 return pins;
6732127f62a763 Daniel Baluta 2014-11-06 450 }
6732127f62a763 Daniel Baluta 2014-11-06 451 if (pins > DLN2_GPIO_MAX_PINS) {
6732127f62a763 Daniel Baluta 2014-11-06 452 pins = DLN2_GPIO_MAX_PINS;
6732127f62a763 Daniel Baluta 2014-11-06 453 dev_warn(dev, "clamping pins to
%d\n", DLN2_GPIO_MAX_PINS);
6732127f62a763 Daniel Baluta 2014-11-06 454 }
6732127f62a763 Daniel Baluta 2014-11-06 455
6732127f62a763 Daniel Baluta 2014-11-06 456 dln2 = devm_kzalloc(&pdev->dev,
sizeof(*dln2), GFP_KERNEL);
6732127f62a763 Daniel Baluta 2014-11-06 457 if (!dln2)
6732127f62a763 Daniel Baluta 2014-11-06 458 return -ENOMEM;
6732127f62a763 Daniel Baluta 2014-11-06 459
96b932b84409a5 Octavian Purdila 2014-12-11 460 mutex_init(&dln2->irq_lock);
6732127f62a763 Daniel Baluta 2014-11-06 461
6732127f62a763 Daniel Baluta 2014-11-06 462 dln2->pdev = pdev;
6732127f62a763 Daniel Baluta 2014-11-06 463
6732127f62a763 Daniel Baluta 2014-11-06 464 dln2->gpio.label = "dln2";
58383c78425e4e Linus Walleij 2015-11-04 465 dln2->gpio.parent = dev;
6732127f62a763 Daniel Baluta 2014-11-06 466 dln2->gpio.owner = THIS_MODULE;
6732127f62a763 Daniel Baluta 2014-11-06 467 dln2->gpio.base = -1;
6732127f62a763 Daniel Baluta 2014-11-06 468 dln2->gpio.ngpio = pins;
6732127f62a763 Daniel Baluta 2014-11-06 469 dln2->gpio.can_sleep = true;
6732127f62a763 Daniel Baluta 2014-11-06 470 dln2->gpio.set = dln2_gpio_set;
6732127f62a763 Daniel Baluta 2014-11-06 471 dln2->gpio.get = dln2_gpio_get;
6732127f62a763 Daniel Baluta 2014-11-06 472 dln2->gpio.request =
dln2_gpio_request;
6732127f62a763 Daniel Baluta 2014-11-06 473 dln2->gpio.free = dln2_gpio_free;
6732127f62a763 Daniel Baluta 2014-11-06 474 dln2->gpio.get_direction =
dln2_gpio_get_direction;
6732127f62a763 Daniel Baluta 2014-11-06 475 dln2->gpio.direction_input =
dln2_gpio_direction_input;
6732127f62a763 Daniel Baluta 2014-11-06 476 dln2->gpio.direction_output =
dln2_gpio_direction_output;
2956b5d94a76b5 Mika Westerberg 2017-01-23 477 dln2->gpio.set_config =
dln2_gpio_set_config;
6732127f62a763 Daniel Baluta 2014-11-06 478
6732127f62a763 Daniel Baluta 2014-11-06 479 platform_set_drvdata(pdev, dln2);
6732127f62a763 Daniel Baluta 2014-11-06 480
1ab79a6ad5673d Laxman Dewangan 2016-02-22 481 ret = devm_gpiochip_add_data(dev,
&dln2->gpio, dln2);
6732127f62a763 Daniel Baluta 2014-11-06 482 if (ret < 0) {
6732127f62a763 Daniel Baluta 2014-11-06 483 dev_err(dev, "failed to add gpio
chip: %d\n", ret);
1ab79a6ad5673d Laxman Dewangan 2016-02-22 484 return ret;
6732127f62a763 Daniel Baluta 2014-11-06 485 }
6732127f62a763 Daniel Baluta 2014-11-06 486
6732127f62a763 Daniel Baluta 2014-11-06 @487 ret =
gpiochip_irqchip_add(&dln2->gpio, &dln2_gpio_irqchip, 0,
6732127f62a763 Daniel Baluta 2014-11-06 488 handle_simple_irq,
IRQ_TYPE_NONE);
6732127f62a763 Daniel Baluta 2014-11-06 489 if (ret < 0) {
6732127f62a763 Daniel Baluta 2014-11-06 490 dev_err(dev, "failed to add irq
chip: %d\n", ret);
1ab79a6ad5673d Laxman Dewangan 2016-02-22 491 return ret;
6732127f62a763 Daniel Baluta 2014-11-06 492 }
6732127f62a763 Daniel Baluta 2014-11-06 493
6732127f62a763 Daniel Baluta 2014-11-06 494 ret = dln2_register_event_cb(pdev,
DLN2_GPIO_CONDITION_MET_EV,
6732127f62a763 Daniel Baluta 2014-11-06 495 dln2_gpio_event);
6732127f62a763 Daniel Baluta 2014-11-06 496 if (ret) {
6732127f62a763 Daniel Baluta 2014-11-06 497 dev_err(dev, "failed to register
event cb: %d\n", ret);
1ab79a6ad5673d Laxman Dewangan 2016-02-22 498 return ret;
6732127f62a763 Daniel Baluta 2014-11-06 499 }
6732127f62a763 Daniel Baluta 2014-11-06 500
6732127f62a763 Daniel Baluta 2014-11-06 501 return 0;
6732127f62a763 Daniel Baluta 2014-11-06 502 }
6732127f62a763 Daniel Baluta 2014-11-06 503
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org