[kbuild-all] Re: drivers/platform/x86/thinkpad_acpi.c:4475:35: error: unused variable 'fwbug_cards_ids'

On Tue, Nov 16, 2021 at 11:26:48AM +0100, Hans de Goede wrote: > Hi, > > On 11/14/21 04:10, kernel test robot wrote: >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master >> head: c8c109546a19613d323a319d0c921cb1f317e629 >> commit: fd96e35ea7b95f1e216277805be89d66e4ae962d platform/x86: thinkpad_acpi: Fix bitwise vs. logical warning >> date: 4 weeks ago >> config: i386-buildonly-randconfig-r005-20211114 (attached as .config) >> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c3dddeeafb529e769cde87bd29ef6271ac6bfa5c) >> reproduce (this is a W=1 build): >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit... >> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >> git fetch --no-tags linus master >> git checkout fd96e35ea7b95f1e216277805be89d66e4ae962d >> # save the attached .config to linux build tree >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=i386 >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot <lkp(a)intel.com&gt; >> >> All errors (new ones prefixed by >>): >> >>>> drivers/platform/x86/thinkpad_acpi.c:4475:35: error: unused variable 'fwbug_cards_ids' [-Werror,-Wunused-const-variable] >> static const struct pci_device_id fwbug_cards_ids[] __initconst = { >> ^ >> 1 error generated. > > So this *again* has absolutely nothing to do with the: > > "platform/x86: thinkpad_acpi: Fix bitwise vs. logical warning" > > commit, the problem is that: > > 1. the .config does not have CONFIG_PCI set; combined with: > 2. include/pci.h using a #define instead of a > static inline for pci_dev_present() when this is the case > 3. This is a clang WERROR build > > I'll submit a fix for 2. upstream which should also fix > similar errors in a lot of other drivers. > > Again I must say that as a maintainer I'm unhappy about the amount > of noise being generated by clang WERROR builds here though, > is it really necessary for the kernel test robot to do builds > of this type ? Sorry Hans for the noise, we will look into this to consider the solution. And want to consult, do you specially have concern about -Wunused-const-variable or all W=1 related build issues?

>> vim +/fwbug_cards_ids +4475 drivers/platform/x86/thinkpad_acpi.c >> >> f7db839fccf087 Jiaxun Yang 2019-03-07 4474 >> f7db839fccf087 Jiaxun Yang 2019-03-07 @4475 static const struct pci_device_id fwbug_cards_ids[] __initconst = { >> f7db839fccf087 Jiaxun Yang 2019-03-07 4476 { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x24F3) }, >> f7db839fccf087 Jiaxun Yang 2019-03-07 4477 { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x24FD) }, >> f7db839fccf087 Jiaxun Yang 2019-03-07 4478 { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x2526) }, >> f7db839fccf087 Jiaxun Yang 2019-03-07 4479 {} >> f7db839fccf087 Jiaxun Yang 2019-03-07 4480 }; >> f7db839fccf087 Jiaxun Yang 2019-03-07 4481 >> f7db839fccf087 Jiaxun Yang 2019-03-07 4482 >> >> :::::: The code at line 4475 was first introduced by commit >> :::::: f7db839fccf087664e5587966220821289b6a9cb platform/x86: thinkpad_acpi: Disable Bluetooth for some machines >> >> :::::: TO: Jiaxun Yang <jiaxun.yang(a)flygoat.com&gt; >> :::::: CC: Andy Shevchenko <andriy.shevchenko(a)linux.intel.com&gt; >> >> --- >> 0-DAY CI Kernel Test Service, Intel Corporation >> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org >> > _______________________________________________ > kbuild-all mailing list -- kbuild-all(a)lists.01.org > To unsubscribe send an email to kbuild-all-leave(a)lists.01.org