[kbuild-all] Re: [PATCH bpf-next v4 27/30] bpf: eliminate rlimit-based memory accounting for xskmap maps

Hi Roman, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Roman-Gushchin/bpf-switch-to-mem... base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master :::::: branch date: 4 hours ago :::::: commit date: 4 hours ago compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; cppcheck warnings: (new ones prefixed by >>) int err, numa_node; ^ # https://github.com/0day-ci/linux/commit/af82aa6260a6db216f3e1f17c2eb15d5c... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Roman-Gushchin/bpf-switch-to-memcg-based-memory-accounting/20200821-233104 git checkout af82aa6260a6db216f3e1f17c2eb15d5c36909bd vim +77 net/xdp/xskmap.c 0402acd683c6788 kernel/bpf/xskmap.c Björn Töpel 2019-08-15 74 fbfc504a24f53f7 kernel/bpf/xskmap.c Björn Töpel 2018-05-02 75 static struct bpf_map *xsk_map_alloc(union bpf_attr *attr) fbfc504a24f53f7 kernel/bpf/xskmap.c Björn Töpel 2018-05-02 76 { e312b9e706ed6d9 kernel/bpf/xskmap.c Björn Töpel 2019-12-19 @77 int err, numa_node; fbfc504a24f53f7 kernel/bpf/xskmap.c Björn Töpel 2018-05-02 78 struct xsk_map *m; e312b9e706ed6d9 kernel/bpf/xskmap.c Björn Töpel 2019-12-19 79 u64 size; fbfc504a24f53f7 kernel/bpf/xskmap.c Björn Töpel 2018-05-02 80 fbfc504a24f53f7 kernel/bpf/xskmap.c Björn Töpel 2018-05-02 81 if (!capable(CAP_NET_ADMIN)) fbfc504a24f53f7 kernel/bpf/xskmap.c Björn Töpel 2018-05-02 82 return ERR_PTR(-EPERM); fbfc504a24f53f7 kernel/bpf/xskmap.c Björn Töpel 2018-05-02 83 fbfc504a24f53f7 kernel/bpf/xskmap.c Björn Töpel 2018-05-02 84 if (attr->max_entries == 0 || attr->key_size != 4 || fbfc504a24f53f7 kernel/bpf/xskmap.c Björn Töpel 2018-05-02 85 attr->value_size != 4 || fbfc504a24f53f7 kernel/bpf/xskmap.c Björn Töpel 2018-05-02 86 attr->map_flags & ~(BPF_F_NUMA_NODE | BPF_F_RDONLY | BPF_F_WRONLY)) fbfc504a24f53f7 kernel/bpf/xskmap.c Björn Töpel 2018-05-02 87 return ERR_PTR(-EINVAL); fbfc504a24f53f7 kernel/bpf/xskmap.c Björn Töpel 2018-05-02 88 64fe8c061de7d7f kernel/bpf/xskmap.c Björn Töpel 2019-11-01 89 numa_node = bpf_map_attr_numa_node(attr); 64fe8c061de7d7f kernel/bpf/xskmap.c Björn Töpel 2019-11-01 90 size = struct_size(m, xsk_map, attr->max_entries); 64fe8c061de7d7f kernel/bpf/xskmap.c Björn Töpel 2019-11-01 91 64fe8c061de7d7f kernel/bpf/xskmap.c Björn Töpel 2019-11-01 92 m = bpf_map_area_alloc(size, numa_node); af82aa6260a6db2 net/xdp/xskmap.c Roman Gushchin 2020-08-21 93 if (!m) fbfc504a24f53f7 kernel/bpf/xskmap.c Björn Töpel 2018-05-02 94 return ERR_PTR(-ENOMEM); fbfc504a24f53f7 kernel/bpf/xskmap.c Björn Töpel 2018-05-02 95 fbfc504a24f53f7 kernel/bpf/xskmap.c Björn Töpel 2018-05-02 96 bpf_map_init_from_attr(&m->map, attr); 0402acd683c6788 kernel/bpf/xskmap.c Björn Töpel 2019-08-15 97 spin_lock_init(&m->lock); fbfc504a24f53f7 kernel/bpf/xskmap.c Björn Töpel 2018-05-02 98 fbfc504a24f53f7 kernel/bpf/xskmap.c Björn Töpel 2018-05-02 99 return &m->map; fbfc504a24f53f7 kernel/bpf/xskmap.c Björn Töpel 2018-05-02 100 } fbfc504a24f53f7 kernel/bpf/xskmap.c Björn Töpel 2018-05-02 101 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org