9:27 p.m.
Hi Harshad,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on ext4/dev]
[also build test WARNING on linus/master v5.9-rc5 next-20200918]
[cannot apply to tip/perf/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Harshad-Shirwadkar/ext4-add-fast...
base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
config: x86_64-randconfig-a006-20200917 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project
ed79827aea444e6995fb3d36abc2bfd36331773c)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> fs/jbd2/recovery.c:258:6: warning: variable 'seq' is
uninitialized when used here [-Wuninitialized]
seq);
^~~
include/linux/jbd2.h:61:59: note: expanded from macro 'jbd_debug'
__jbd2_debug((n), __FILE__, __func__, __LINE__, (fmt), ##a)
^
fs/jbd2/recovery.c:241:18: note: initialize the variable 'seq' to silence this
warning
unsigned int seq;
^
= 0
1 warning generated.
# https://github.com/0day-ci/linux/commit/1edf68c36f8df0e684d1c2bd25d324d43...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Harshad-Shirwadkar/ext4-add-fast-commits-feature/20200919-085652
git checkout 1edf68c36f8df0e684d1c2bd25d324d43da4d444
vim +/seq +258 fs/jbd2/recovery.c
234
235 static int fc_do_one_pass(journal_t *journal,
236 struct recovery_info *info, enum passtype pass)
237 {
238 unsigned int expected_commit_id = info->end_transaction;
239 unsigned long next_fc_block;
240 struct buffer_head *bh;
241 unsigned int seq;
242 int err = 0;
243
244 next_fc_block = journal->j_first_fc;
245 if (!journal->j_fc_replay_callback)
246 return 0;
247
248 while (next_fc_block <= journal->j_last_fc) {
249 jbd_debug(3, "Fast commit replay: next block %ld",
250 next_fc_block);
251 err = jread(&bh, journal, next_fc_block);
252 if (err) {
253 jbd_debug(3, "Fast commit replay: read error");
254 break;
255 }
256
257 jbd_debug(3, "Processing fast commit blk with seq %d",
258 seq);
259 err =
journal->j_fc_replay_callback(journal, bh, pass,
260 next_fc_block - journal->j_first_fc,
261 expected_commit_id);
262 next_fc_block++;
263 if (err < 0 || err == JBD2_FC_REPLAY_STOP)
264 break;
265 err = 0;
266 }
267
268 if (err)
269 jbd_debug(3, "Fast commit replay failed, err = %d\n", err);
270
271 return err;
272 }
273
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org