4:26 a.m.
From: kernel test robot <lkp(a)intel.com>
fs/afs/write.c:336:2-5: WARNING: Use BUG_ON
fs/afs/write.c:338:2-5: WARNING: Use BUG_ON
fs/afs/write.c:376:4-7: WARNING: Use BUG_ON
fs/afs/write.c:378:4-7: WARNING: Use BUG_ON
Use BUG_ON instead of a if condition followed by BUG.
Semantic patch information:
This makes an effort to find cases where BUG() follows an if
condition on an expression and replaces the if condition and BUG()
with a BUG_ON having the conditional expression of the if statement
as argument.
Generated by: scripts/coccinelle/misc/bugon.cocci
Fixes: 8214bf079208 ("scripts/dtc: Export YYLOC global declaration")
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: https://android.googlesource.com/kernel/goldfish android-3.18
head: dd54b61f1458c03f68fc019b4874d98f2f0ae3a5
commit: 8214bf079208b146e63cd0a3ce0ed335a87ce7b3 [396/1051] scripts/dtc: Export YYLOC
global declaration
:::::: branch date: 5 weeks ago
:::::: commit date: 3 months ago
Please take the patch only if it's a positive warning. Thanks!
write.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
--- a/fs/afs/write.c
+++ b/fs/afs/write.c
@@ -332,10 +332,8 @@ static int afs_write_back_from_locked_pa
_enter(",%lx", primary_page->index);
count = 1;
- if (!clear_page_dirty_for_io(primary_page))
- BUG();
- if (test_set_page_writeback(primary_page))
- BUG();
+ BUG_ON(!clear_page_dirty_for_io(primary_page));
+ BUG_ON(test_set_page_writeback(primary_page));
/* find all consecutive lockable dirty pages, stopping when we find a
* page that is not immediately lockable, is not dirty or is missing,
@@ -372,10 +370,8 @@ static int afs_write_back_from_locked_pa
unlock_page(page);
break;
}
- if (!clear_page_dirty_for_io(page))
- BUG();
- if (test_set_page_writeback(page))
- BUG();
+ BUG_ON(!clear_page_dirty_for_io(page));
+ BUG_ON(test_set_page_writeback(page));
unlock_page(page);
put_page(page);
}