8:36 a.m.
Hi Dmitry,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on bpf-next/master]
url:
https://github.com/0day-ci/linux/commits/Dmitry-Yakunin/bpf-cgroup-skb-im...
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: m68k-sun3_defconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
net/bpf/test_run.c: In function 'bpf_prog_find_active_storage':
> net/bpf/test_run.c:47:9: error: implicit declaration of function
'task_dfl_cgroup' [-Werror=implicit-function-declaration]
47 | cgrp =
task_dfl_cgroup(current);
| ^~~~~~~~~~~~~~~
> net/bpf/test_run.c:47:7: warning: assignment to 'struct
cgroup *' from 'int' makes pointer from integer without a cast
[-Wint-conversion]
47 | cgrp = task_dfl_cgroup(current);
| ^
> net/bpf/test_run.c:50:13: error: dereferencing pointer to
incomplete type 'struct cgroup'
50 |
cgrp->bpf.effective[BPF_CGROUP_INET_INGRESS]);
| ^~
net/bpf/test_run.c: In function 'bpf_test_run':
net/bpf/test_run.c:67:8: error: implicit declaration of function
'bpf_cgroup_storages_alloc'; did you mean 'bpf_cgroup_storage_alloc'?
[-Werror=implicit-function-declaration]
67 | ret = bpf_cgroup_storages_alloc(dummy_storage, prog);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| bpf_cgroup_storage_alloc
net/bpf/test_run.c:115:2: error: implicit declaration of function
'bpf_cgroup_storages_free'; did you mean 'bpf_cgroup_storage_free'?
[-Werror=implicit-function-declaration]
115 | bpf_cgroup_storages_free(dummy_storage);
| ^~~~~~~~~~~~~~~~~~~~~~~~
| bpf_cgroup_storage_free
cc1: some warnings being treated as errors
vim +/task_dfl_cgroup +47 net/bpf/test_run.c
38
39 static struct bpf_cgroup_storage **bpf_prog_find_active_storage(struct bpf_prog
*prog)
40 {
41 struct bpf_prog_array_item *item;
42 struct cgroup *cgrp;
43
44 if (prog->type != BPF_PROG_TYPE_CGROUP_SKB)
45 return NULL;
46
47 cgrp = task_dfl_cgroup(current);
48
49 item = bpf_prog_find_active(prog,
50 cgrp->bpf.effective[BPF_CGROUP_INET_INGRESS]);
51 if (!item)
52 item = bpf_prog_find_active(prog,
53 cgrp->bpf.effective[BPF_CGROUP_INET_EGRESS]);
54
55 return item ? item->cgroup_storage : NULL;
56 }
57
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org