[kbuild-all] Re: [PATCH 4/4] clk: bcm: Add BCM63268 timer clock and reset driver

Quoting kernel test robot (2021-03-03 22:22:44) > Hi "Álvaro, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on clk/clk-next] > [also build test ERROR on robh/for-next pza/reset/next v5.12-rc1 next-20210303] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/lvaro-Fern-ndez-Rojas/clk-add-BC... > base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next > config: sparc-allyesconfig (attached as .config) > compiler: sparc64-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/0day-ci/linux/commit/f6057c7d442f720a3824acc27e306a673... > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review lvaro-Fern-ndez-Rojas/clk-add-BCM63268-timer-clock-and-reset/20210226-034945 > git checkout f6057c7d442f720a3824acc27e306a67344348ce > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp(a)intel.com&gt; > > All errors (new ones prefixed by >>): > > drivers/clk/bcm/clk-bcm63268-timer.c: In function 'bcm63268_timer_reset_update': >>> drivers/clk/bcm/clk-bcm63268-timer.c:91:8: error: implicit declaration of function '__raw_readl'; did you mean '__raw_read_lock'? [-Werror=implicit-function-declaration] > 91 | val = __raw_readl(reset->regs); Please use readl() and writel() unless it needs to be raw to avoid some barrier? In which case relaxed should be used.