[kbuild-all] Re: [PATCH v2 3/3] clk: qcom: mmcc-msm8994: Add MSM8992 support

Hi Konrad, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on clk/clk-next] [also build test WARNING on v5.13-rc6 next-20210617] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Konrad-Dybcio/dt-bindings-clock-... base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next config: arc-randconfig-s032-20210618 (attached as .config) compiler: arceb-elf-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.3-341-g8af24329-dirty # https://github.com/0day-ci/linux/commit/efd6185eeb7cf2bba1e205fd0cb32136f... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Konrad-Dybcio/dt-bindings-clock-Add-support-for-MSM8992-4-MMCC/20210618-032911 git checkout efd6185eeb7cf2bba1e205fd0cb32136f2dd80ad # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=arc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; sparse warnings: (new ones prefixed by >>) drivers/clk/qcom/mmcc-msm8994.c:2567:64: sparse: sparse: Using plain integer as NULL pointer drivers/clk/qcom/mmcc-msm8994.c:2568:59: sparse: sparse: Using plain integer as NULL pointer drivers/clk/qcom/mmcc-msm8994.c:2569:55: sparse: sparse: Using plain integer as NULL pointer drivers/clk/qcom/mmcc-msm8994.c:2570:59: sparse: sparse: Using plain integer as NULL pointer drivers/clk/qcom/mmcc-msm8994.c:2571:54: sparse: sparse: Using plain integer as NULL pointer drivers/clk/qcom/mmcc-msm8994.c:2572:54: sparse: sparse: Using plain integer as NULL pointer drivers/clk/qcom/mmcc-msm8994.c:2573:57: sparse: sparse: Using plain integer as NULL pointer drivers/clk/qcom/mmcc-msm8994.c:2574:57: sparse: sparse: Using plain integer as NULL pointer drivers/clk/qcom/mmcc-msm8994.c:2575:67: sparse: sparse: Using plain integer as NULL pointer drivers/clk/qcom/mmcc-msm8994.c:2577:52: sparse: sparse: Using plain integer as NULL pointer drivers/clk/qcom/mmcc-msm8994.c:2578:61: sparse: sparse: Using plain integer as NULL pointer vim +2566 drivers/clk/qcom/mmcc-msm8994.c 2559 2560 static int mmcc_msm8994_probe(struct platform_device *pdev) 2561 { 2562 struct regmap *regmap; 2563 2564 if (of_device_is_compatible(pdev->dev.of_node, "qcom,mmcc-msm8992")) { 2565 /* MSM8992 features less clocks and some have different freq tables */ 2567 mmcc_msm8994_desc.clks[CAMSS_JPEG_JPEG2_CLK] = 0; 2568 mmcc_msm8994_desc.clks[FD_CORE_CLK_SRC] = 0; 2569 mmcc_msm8994_desc.clks[FD_CORE_CLK] = 0; 2570 mmcc_msm8994_desc.clks[FD_CORE_UAR_CLK] = 0; 2571 mmcc_msm8994_desc.clks[FD_AXI_CLK] = 0; 2572 mmcc_msm8994_desc.clks[FD_AHB_CLK] = 0; 2573 mmcc_msm8994_desc.clks[JPEG1_CLK_SRC] = 0; 2574 mmcc_msm8994_desc.clks[JPEG2_CLK_SRC] = 0; 2575 mmcc_msm8994_desc.clks[VENUS0_CORE2_VCODEC_CLK] = 0; 2576 2577 mmcc_msm8994_desc.gdscs[FD_GDSC] = 0; 2578 mmcc_msm8994_desc.gdscs[VENUS_CORE2_GDSC] = 0; 2579 2580 axi_clk_src.freq_tbl = ftbl_axi_clk_src_8992; 2581 cpp_clk_src.freq_tbl = ftbl_cpp_clk_src_8992; 2582 csi0_clk_src.freq_tbl = ftbl_csi0_1_2_3_clk_src_8992; 2583 csi1_clk_src.freq_tbl = ftbl_csi0_1_2_3_clk_src_8992; 2584 csi2_clk_src.freq_tbl = ftbl_csi0_1_2_3_clk_src_8992; 2585 csi3_clk_src.freq_tbl = ftbl_csi0_1_2_3_clk_src_8992; 2586 mclk0_clk_src.freq_tbl = ftbl_mclk0_clk_src_8992; 2587 mclk1_clk_src.freq_tbl = ftbl_mclk1_2_3_clk_src_8992; 2588 mclk2_clk_src.freq_tbl = ftbl_mclk1_2_3_clk_src_8992; 2589 mclk3_clk_src.freq_tbl = ftbl_mclk1_2_3_clk_src_8992; 2590 mdp_clk_src.freq_tbl = ftbl_mdp_clk_src_8992; 2591 ocmemnoc_clk_src.freq_tbl = ftbl_ocmemnoc_clk_src_8992; 2592 vcodec0_clk_src.freq_tbl = ftbl_vcodec0_clk_src_8992; 2593 vfe0_clk_src.freq_tbl = ftbl_vfe0_1_clk_src_8992; 2594 vfe1_clk_src.freq_tbl = ftbl_vfe0_1_clk_src_8992; 2595 } 2596 2597 regmap = qcom_cc_map(pdev, &mmcc_msm8994_desc); 2598 if (IS_ERR(regmap)) 2599 return PTR_ERR(regmap); 2600 2601 clk_alpha_pll_configure(&mmpll0_early, regmap, &mmpll_p_config); 2602 clk_alpha_pll_configure(&mmpll1_early, regmap, &mmpll_p_config); 2603 clk_alpha_pll_configure(&mmpll3_early, regmap, &mmpll_p_config); 2604 clk_alpha_pll_configure(&mmpll5_early, regmap, &mmpll_p_config); 2605 2606 return qcom_cc_really_probe(pdev, &mmcc_msm8994_desc, regmap); 2607 } 2608 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org