Hi Andy,
I love your patch! Yet something to improve:
[auto build test ERROR on balbi-usb/next]
[also build test ERROR on mkp-scsi/for-next linus/master v5.6-rc5 next-20200312]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see
https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Andy-Shevchenko/asm-generic-Prov...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: openrisc-randconfig-a001-20200312 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=9.2.0 make.cross ARCH=openrisc
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers//target/target_core_sbc.c: In function 'transport_lba_21':
> drivers//target/target_core_sbc.c:260:9: error: implicit
declaration of function 'get_unaligned_be24'; did you mean
'get_unaligned_be64'? [-Werror=implicit-function-declaration]
260 |
return get_unaligned_be24(&cdb[1]) & 0x1fffff;
| ^~~~~~~~~~~~~~~~~~
| get_unaligned_be64
cc1: some warnings being treated as errors
--
drivers//target/target_core_spc.c: In function 'spc_parse_cdb':
> drivers//target/target_core_spc.c:1375:11: error: implicit
declaration of function 'get_unaligned_be24'; did you mean
'get_unaligned_be64'? [-Werror=implicit-function-declaration]
1375 |
*size = get_unaligned_be24(&cdb[6]);
| ^~~~~~~~~~~~~~~~~~
| get_unaligned_be64
cc1: some warnings being treated as errors
--
drivers//target/target_core_xcopy.c: In function
'target_xcopy_parse_segdesc_02':
> drivers//target/target_core_xcopy.c:319:14: error: implicit
declaration of function 'get_unaligned_be24'; did you mean
'get_unaligned_be64'? [-Werror=implicit-function-declaration]
319 |
xop->dbl = get_unaligned_be24(&desc[29]);
| ^~~~~~~~~~~~~~~~~~
| get_unaligned_be64
cc1: some warnings being treated as errors
--
drivers//target/target_core_pscsi.c: In function 'pscsi_tape_read_blocksize':
> drivers//target/target_core_pscsi.c:158:22: error: implicit
declaration of function 'get_unaligned_be24'; did you mean
'get_unaligned_be64'? [-Werror=implicit-function-declaration]
158 |
sdev->sector_size = get_unaligned_be24(&buf[9]);
| ^~~~~~~~~~~~~~~~~~
| get_unaligned_be64
cc1: some warnings being treated as errors
vim +260 drivers//target/target_core_sbc.c
d6e0175cf3f973 Christoph Hellwig 2012-05-20 257
d6e0175cf3f973 Christoph Hellwig 2012-05-20 258 static inline u32
transport_lba_21(unsigned char *cdb)
d6e0175cf3f973 Christoph Hellwig 2012-05-20 259 {
a85d667e58bddf Bart Van Assche 2017-05-23 @260 return get_unaligned_be24(&cdb[1])
& 0x1fffff;
d6e0175cf3f973 Christoph Hellwig 2012-05-20 261 }
d6e0175cf3f973 Christoph Hellwig 2012-05-20 262
:::::: The code at line 260 was first introduced by commit
:::::: a85d667e58bddf73be84d1981b41eaac985ed216 target: Use {get,put}_unaligned_be*()
instead of open coding these functions
:::::: TO: Bart Van Assche <bart.vanassche(a)sandisk.com>
:::::: CC: Nicholas Bellinger <nab(a)linux-iscsi.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org