4:24 a.m.
From: kernel test robot <lkp(a)intel.com>
fs/ntfs/inode.c:349:2-5: WARNING: Use BUG_ON
fs/ntfs/inode.c:372:2-5: WARNING: Use BUG_ON
Use BUG_ON instead of a if condition followed by BUG.
Semantic patch information:
This makes an effort to find cases where BUG() follows an if
condition on an expression and replaces the if condition and BUG()
with a BUG_ON having the conditional expression of the if statement
as argument.
Generated by: scripts/coccinelle/misc/bugon.cocci
Fixes: 8214bf079208 ("scripts/dtc: Export YYLOC global declaration")
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: https://android.googlesource.com/kernel/goldfish android-3.18
head: dd54b61f1458c03f68fc019b4874d98f2f0ae3a5
commit: 8214bf079208b146e63cd0a3ce0ed335a87ce7b3 [396/1051] scripts/dtc: Export YYLOC
global declaration
:::::: branch date: 5 weeks ago
:::::: commit date: 3 months ago
Please take the patch only if it's a positive warning. Thanks!
inode.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
--- a/fs/ntfs/inode.c
+++ b/fs/ntfs/inode.c
@@ -345,8 +345,7 @@ void ntfs_destroy_big_inode(struct inode
ntfs_debug("Entering.");
BUG_ON(ni->page);
- if (!atomic_dec_and_test(&ni->count))
- BUG();
+ BUG_ON(!atomic_dec_and_test(&ni->count));
call_rcu(&inode->i_rcu, ntfs_i_callback);
}
@@ -368,8 +367,7 @@ static void ntfs_destroy_extent_inode(nt
{
ntfs_debug("Entering.");
BUG_ON(ni->page);
- if (!atomic_dec_and_test(&ni->count))
- BUG();
+ BUG_ON(!atomic_dec_and_test(&ni->count));
kmem_cache_free(ntfs_inode_cache, ni);
}