5:57 a.m.
Hi Peng,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tip/sched/core]
[also build test ERROR on tip/master linux/master linus/master v5.9-rc5 next-20200917]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Peng-Liu/sched-deadline-Fix-sche...
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
848785df48835eefebe0c4eb5da7690690b0a8b7
config: x86_64-randconfig-s021-20200917 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-201-g24bdaac6-dirty
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from arch/x86/include/asm/cpumask.h:5,
from arch/x86/include/asm/msr.h:11,
from arch/x86/include/asm/processor.h:22,
from arch/x86/include/asm/cpufeature.h:5,
from arch/x86/include/asm/thread_info.h:53,
from include/linux/thread_info.h:38,
from arch/x86/include/asm/preempt.h:7,
from include/linux/preempt.h:78,
from include/linux/rcupdate.h:27,
from include/linux/rculist.h:11,
from include/linux/pid.h:5,
from include/linux/sched.h:14,
from kernel/sched/sched.h:5,
from kernel/sched/deadline.c:18:
kernel/sched/deadline.c: In function 'sched_dl_do_global':
> kernel/sched/deadline.c:2595:20: error: 'possible_mask'
undeclared (first use in this function); did you mean 'cpu_possible_mask'?
2595 | for_each_cpu(cpu, possible_mask) {
| ^~~~~~~~~~~~~
include/linux/cpumask.h:203:44: note: in definition of macro 'for_each_cpu'
203 | for ((cpu) = 0; (cpu) < 1; (cpu)++, (void)mask)
| ^~~~
kernel/sched/deadline.c:2595:20: note: each undeclared identifier is reported only once
for each function it appears in
2595 | for_each_cpu(cpu, possible_mask) {
| ^~~~~~~~~~~~~
include/linux/cpumask.h:203:44: note: in definition of macro 'for_each_cpu'
203 | for ((cpu) = 0; (cpu) < 1; (cpu)++, (void)mask)
| ^~~~
# https://github.com/0day-ci/linux/commit/34a03e474224b29097a1b94a766d6a8eb...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Peng-Liu/sched-deadline-Fix-sched_dl_global_validate/20200918-004123
git checkout 34a03e474224b29097a1b94a766d6a8eb3f7c4e6
vim +2595 kernel/sched/deadline.c
2584
2585 def_dl_bandwidth.dl_period = global_rt_period();
2586 def_dl_bandwidth.dl_runtime = global_rt_runtime();
2587
2588 if (global_rt_runtime() != RUNTIME_INF)
2589 new_bw = to_ratio(global_rt_period(), global_rt_runtime());
2590
2591 #ifdef CONFIG_SMP
2592 possible_mask = &dl_local_possible_mask;
2593 cpumask_copy(possible_mask, cpu_possible_mask);
2594 #endif /* CONFIG_SMP */
2595 for_each_cpu(cpu, possible_mask) {
2596 rcu_read_lock_sched();
2597 dl_b = dl_bw_of(cpu);
2598
2599 raw_spin_lock_irqsave(&dl_b->lock, flags);
2600 dl_b->bw = new_bw;
2601 raw_spin_unlock_irqrestore(&dl_b->lock, flags);
2602 #ifdef CONFIG_SMP
2603 cpumask_andnot(possible_mask, possible_mask,
2604 cpu_rq(cpu)->rd->span);
2605 #endif /* CONFIG_SMP */
2606 rcu_read_unlock_sched();
2607 init_dl_rq_bw_ratio(&cpu_rq(cpu)->dl);
2608 }
2609 }
2610
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org