[kbuild-all] [sashal-linux-stable:queue-4.19 212/440] drivers/pci/quirks.c:5103:2: error: implicit declaration of function 'pci_create_device_link'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git queue-4.19 head: 7a462d454a5354302318d17cb32da8ec0c8e1a35 commit: 025b25be8630a0280d2c0ff360576bb50b141877 [212/440] PCI: Add NVIDIA GPU multi-function power dependencies config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 025b25be8630a0280d2c0ff360576bb50b141877 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; Note: the sashal-linux-stable/queue-4.19 HEAD 7a462d454a5354302318d17cb32da8ec0c8e1a35 builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): In file included from include/linux/kernel.h:10, from drivers/pci/quirks.c:16: include/linux/scatterlist.h: In function 'sg_set_buf': arch/xtensa/include/asm/page.h:182:9: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] 182 | ((pfn) >= ARCH_PFN_OFFSET && ((pfn) - ARCH_PFN_OFFSET) < max_mapnr) | ^~ include/linux/compiler.h:77:42: note: in definition of macro 'unlikely' 77 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ arch/xtensa/include/asm/page.h:190:32: note: in expansion of macro 'pfn_valid' 190 | #define virt_addr_valid(kaddr) pfn_valid(__pa(kaddr) >> PAGE_SHIFT) | ^~~~~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ include/linux/dma-mapping.h: In function 'dma_map_resource': arch/xtensa/include/asm/page.h:182:9: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] 182 | ((pfn) >= ARCH_PFN_OFFSET && ((pfn) - ARCH_PFN_OFFSET) < max_mapnr) | ^~ include/linux/compiler.h:77:42: note: in definition of macro 'unlikely' 77 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/dma-mapping.h:329:2: note: in expansion of macro 'BUG_ON' 329 | BUG_ON(pfn_valid(PHYS_PFN(phys_addr))); | ^~~~~~ include/linux/dma-mapping.h:329:9: note: in expansion of macro 'pfn_valid' 329 | BUG_ON(pfn_valid(PHYS_PFN(phys_addr))); | ^~~~~~~~~ drivers/pci/quirks.c: In function 'pci_quirk_rciep_acs': drivers/pci/quirks.c:4556:9: error: implicit declaration of function 'pci_acs_ctrl_enabled'; did you mean 'pci_acs_path_enabled'? [-Werror=implicit-function-declaration] 4556 | return pci_acs_ctrl_enabled(acs_flags, | ^~~~~~~~~~~~~~~~~~~~ | pci_acs_path_enabled drivers/pci/quirks.c: In function 'quirk_gpu_usb': 5103 | pci_create_device_link(usb, 2, 0, PCI_BASE_CLASS_DISPLAY, 16); | ^~~~~~~~~~~~~~~~~~~~~~ drivers/pci/quirks.c: In function 'quirk_switchtec_ntb_dma_alias': drivers/pci/quirks.c:5190:32: warning: variable 'mmio_sys_info' set but not used [-Wunused-but-set-variable] 5190 | struct sys_info_regs __iomem *mmio_sys_info; | ^~~~~~~~~~~~~ In file included from drivers/pci/quirks.c:18: drivers/pci/quirks.c: At top level: drivers/pci/quirks.c:5374:25: error: 'PCI_VENDOR_ID_PERICOM' undeclared here (not in a function); did you mean 'PCI_VENDOR_ID_MYRICOM'? 5374 | DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_PERICOM, 0x400e, pci_fixup_no_pme); | ^~~~~~~~~~~~~~~~~~~~~ include/linux/pci.h:1855:7: note: in definition of macro 'DECLARE_PCI_FIXUP_SECTION' 1855 | = { vendor, device, class, class_shift, hook }; | ^~~~~~ drivers/pci/quirks.c:5374:1: note: in expansion of macro 'DECLARE_PCI_FIXUP_FINAL' 5374 | DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_PERICOM, 0x400e, pci_fixup_no_pme); | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/pci/quirks.c: In function 'quirk_netmos': drivers/pci/quirks.c:2201:6: warning: this statement may fall through [-Wimplicit-fallthrough=] 2201 | if (dev->subsystem_vendor == PCI_VENDOR_ID_IBM && | ^ drivers/pci/quirks.c:2205:2: note: here 2205 | case PCI_DEVICE_ID_NETMOS_9735: | ^~~~ cc1: some warnings being treated as errors vim +/pci_create_device_link +5103 drivers/pci/quirks.c 5058 5059 /* 5060 * GPUs with integrated HDA controller for streaming audio to attached displays 5061 * need a device link from the HDA controller (consumer) to the GPU (supplier) 5062 * so that the GPU is powered up whenever the HDA controller is accessed. 5063 * The GPU and HDA controller are functions 0 and 1 of the same PCI device. 5064 * The device link stays in place until shutdown (or removal of the PCI device 5065 * if it's hotplugged). Runtime PM is allowed by default on the HDA controller 5066 * to prevent it from permanently keeping the GPU awake. 5067 */ 5068 static void quirk_gpu_hda(struct pci_dev *hda) 5069 { 5070 struct pci_dev *gpu; 5071 5072 if (PCI_FUNC(hda->devfn) != 1) 5073 return; 5074 5075 gpu = pci_get_domain_bus_and_slot(pci_domain_nr(hda->bus), 5076 hda->bus->number, 5077 PCI_DEVFN(PCI_SLOT(hda->devfn), 0)); 5078 if (!gpu || (gpu->class >> 16) != PCI_BASE_CLASS_DISPLAY) { 5079 pci_dev_put(gpu); 5080 return; 5081 } 5082 5083 if (!device_link_add(&hda->dev, &gpu->dev, 5084 DL_FLAG_STATELESS | DL_FLAG_PM_RUNTIME)) 5085 pci_err(hda, "cannot link HDA to GPU %s\n", pci_name(gpu)); 5086 5087 pm_runtime_allow(&hda->dev); 5088 pci_dev_put(gpu); 5089 } 5090 DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_ATI, PCI_ANY_ID, 5091 PCI_CLASS_MULTIMEDIA_HD_AUDIO, 8, quirk_gpu_hda); 5092 DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_AMD, PCI_ANY_ID, 5093 PCI_CLASS_MULTIMEDIA_HD_AUDIO, 8, quirk_gpu_hda); 5094 DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID, 5095 PCI_CLASS_MULTIMEDIA_HD_AUDIO, 8, quirk_gpu_hda); 5096 5097 /* 5098 * Create device link for NVIDIA GPU with integrated USB xHCI Host 5099 * controller to VGA. 5100 */ 5101 static void quirk_gpu_usb(struct pci_dev *usb) 5102 { 5104 } 5105 DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID, 5106 PCI_CLASS_SERIAL_USB, 8, quirk_gpu_usb); 5107 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org