[kbuild-all] [chrome-os:chromeos-4.4 202/214] drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c:361:11: warning: comparison of integer expressions of different signedness: 'int' and '__u32' {aka 'unsigned int'}

tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-4.4 head: 165087594d83615eb48f64ee09830ccccd7f4ae4 commit: 10f444186a4c895d03e4884ec529067daee430b3 [202/214] BACKPORT: media: rockchip: rkisp1: destage Rockchip ISP1 driver config: arc-allyesconfig (attached as .config) compiler: arceb-elf-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git remote add chrome-os https://chromium.googlesource.com/chromiumos/third_party/kernel git fetch --no-tags chrome-os chromeos-4.4 git checkout 10f444186a4c895d03e4884ec529067daee430b3 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): In file included from arch/arc/include/asm/bug.h:32, from include/linux/bug.h:4, from include/linux/debug_locks.h:6, from include/linux/lockdep.h:23, from include/linux/spinlock_types.h:18, from include/linux/mutex.h:15, from include/linux/kernfs.h:13, from include/linux/sysfs.h:15, from include/linux/kobject.h:21, from include/linux/device.h:17, from include/linux/pm_runtime.h:12, from drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c:12: include/linux/cpumask.h: In function 'cpumask_check': include/linux/cpumask.h:117:19: warning: comparison of integer expressions of different signedness: 'unsigned int' and 'int' [-Wsign-compare] 117 | WARN_ON_ONCE(cpu >= nr_cpumask_bits); | ^~ include/asm-generic/bug.h:123:27: note: in definition of macro 'WARN_ON_ONCE' 123 | int __ret_warn_once = !!(condition); \ | ^~~~~~~~~ drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c: In function 'rkisp1_cap_enum_mbus_codes': 361 | if (n++ == code->index) { | ^~ drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c: In function 'rkisp1_find_fmt_cfg': 1263 | for (i = 0; i < cap->config->fmt_size; i++) { | ^ drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c: In function 'rkisp1_enum_fmt_vid_cap_mplane': 1337 | if (f->index >= cap->config->fmt_size) | ^~ drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c:1345:16: warning: comparison of integer expressions of different signedness: 'unsigned int' and 'int' [-Wsign-compare] 1345 | for (i = 0; i < cap->config->fmt_size; i++) { | ^ -- In file included from drivers/media/platform/rockchip/rkisp1/rkisp1-common.c:8: include/media/v4l2-rect.h: In function 'v4l2_rect_overlap': 185 | if (r1->left >= r2->left + r2->width || | ^~ include/media/v4l2-rect.h:186:15: warning: comparison of integer expressions of different signedness: '__s32' {aka 'const int'} and 'unsigned int' [-Wsign-compare] 186 | r2->left >= r1->left + r1->width) | ^~ include/media/v4l2-rect.h:193:14: warning: comparison of integer expressions of different signedness: '__s32' {aka 'const int'} and 'unsigned int' [-Wsign-compare] 193 | if (r1->top >= r2->top + r2->height || | ^~ include/media/v4l2-rect.h:194:14: warning: comparison of integer expressions of different signedness: '__s32' {aka 'const int'} and 'unsigned int' [-Wsign-compare] 194 | r2->top >= r1->top + r1->height) | ^~ In file included from arch/arc/include/asm/bug.h:32, from include/linux/bug.h:4, from include/linux/thread_info.h:11, from include/asm-generic/preempt.h:4, from arch/arc/include/generated/asm/preempt.h:1, from include/linux/preempt.h:59, from include/linux/spinlock.h:50, from include/linux/seqlock.h:35, from include/linux/time.h:5, from include/linux/videodev2.h:59, from include/media/v4l2-rect.h:23, from drivers/media/platform/rockchip/rkisp1/rkisp1-common.c:8: include/linux/cpumask.h: In function 'cpumask_check': include/linux/cpumask.h:117:19: warning: comparison of integer expressions of different signedness: 'unsigned int' and 'int' [-Wsign-compare] 117 | WARN_ON_ONCE(cpu >= nr_cpumask_bits); | ^~ include/asm-generic/bug.h:123:27: note: in definition of macro 'WARN_ON_ONCE' 123 | int __ret_warn_once = !!(condition); \ | ^~~~~~~~~ -- In file included from arch/arc/include/asm/bug.h:32, from include/linux/bug.h:4, from include/linux/thread_info.h:11, from include/asm-generic/preempt.h:4, from arch/arc/include/generated/asm/preempt.h:1, from include/linux/preempt.h:59, from include/linux/spinlock.h:50, from include/linux/rcupdate.h:38, from include/linux/rbtree.h:34, from include/linux/hrtimer.h:18, from include/linux/iopoll.h:20, from drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c:11: include/linux/cpumask.h: In function 'cpumask_check': include/linux/cpumask.h:117:19: warning: comparison of integer expressions of different signedness: 'unsigned int' and 'int' [-Wsign-compare] 117 | WARN_ON_ONCE(cpu >= nr_cpumask_bits); | ^~ include/asm-generic/bug.h:123:27: note: in definition of macro 'WARN_ON_ONCE' 123 | int __ret_warn_once = !!(condition); \ | ^~~~~~~~~ drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c: In function 'rkisp1_isp_enum_mbus_code': 590 | if (code->index == pos - 1) { | ^~ vim +361 drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c a4204813632adf drivers/staging/media/rkisp1/rkisp1-capture.c Helen Koike 2020-01-08 344 65926a5b1c6371 drivers/staging/media/rkisp1/rkisp1-capture.c Dafna Hirschfeld 2020-09-01 345 int rkisp1_cap_enum_mbus_codes(struct rkisp1_capture *cap, 65926a5b1c6371 drivers/staging/media/rkisp1/rkisp1-capture.c Dafna Hirschfeld 2020-09-01 346 struct v4l2_subdev_mbus_code_enum *code) 65926a5b1c6371 drivers/staging/media/rkisp1/rkisp1-capture.c Dafna Hirschfeld 2020-09-01 347 { 65926a5b1c6371 drivers/staging/media/rkisp1/rkisp1-capture.c Dafna Hirschfeld 2020-09-01 348 const struct rkisp1_capture_fmt_cfg *fmts = cap->config->fmts; 65926a5b1c6371 drivers/staging/media/rkisp1/rkisp1-capture.c Dafna Hirschfeld 2020-09-01 349 /* 65926a5b1c6371 drivers/staging/media/rkisp1/rkisp1-capture.c Dafna Hirschfeld 2020-09-01 350 * initialize curr_mbus to non existing mbus code 0 to ensure it is 65926a5b1c6371 drivers/staging/media/rkisp1/rkisp1-capture.c Dafna Hirschfeld 2020-09-01 351 * different from fmts[0].mbus 65926a5b1c6371 drivers/staging/media/rkisp1/rkisp1-capture.c Dafna Hirschfeld 2020-09-01 352 */ 65926a5b1c6371 drivers/staging/media/rkisp1/rkisp1-capture.c Dafna Hirschfeld 2020-09-01 353 u32 curr_mbus = 0; 65926a5b1c6371 drivers/staging/media/rkisp1/rkisp1-capture.c Dafna Hirschfeld 2020-09-01 354 int i, n = 0; 65926a5b1c6371 drivers/staging/media/rkisp1/rkisp1-capture.c Dafna Hirschfeld 2020-09-01 355 65926a5b1c6371 drivers/staging/media/rkisp1/rkisp1-capture.c Dafna Hirschfeld 2020-09-01 356 for (i = 0; i < cap->config->fmt_size; i++) { 65926a5b1c6371 drivers/staging/media/rkisp1/rkisp1-capture.c Dafna Hirschfeld 2020-09-01 357 if (fmts[i].mbus == curr_mbus) 65926a5b1c6371 drivers/staging/media/rkisp1/rkisp1-capture.c Dafna Hirschfeld 2020-09-01 358 continue; 65926a5b1c6371 drivers/staging/media/rkisp1/rkisp1-capture.c Dafna Hirschfeld 2020-09-01 359 65926a5b1c6371 drivers/staging/media/rkisp1/rkisp1-capture.c Dafna Hirschfeld 2020-09-01 360 curr_mbus = fmts[i].mbus; 65926a5b1c6371 drivers/staging/media/rkisp1/rkisp1-capture.c Dafna Hirschfeld 2020-09-01 @361 if (n++ == code->index) { 65926a5b1c6371 drivers/staging/media/rkisp1/rkisp1-capture.c Dafna Hirschfeld 2020-09-01 362 code->code = curr_mbus; 65926a5b1c6371 drivers/staging/media/rkisp1/rkisp1-capture.c Dafna Hirschfeld 2020-09-01 363 return 0; 65926a5b1c6371 drivers/staging/media/rkisp1/rkisp1-capture.c Dafna Hirschfeld 2020-09-01 364 } 65926a5b1c6371 drivers/staging/media/rkisp1/rkisp1-capture.c Dafna Hirschfeld 2020-09-01 365 } 65926a5b1c6371 drivers/staging/media/rkisp1/rkisp1-capture.c Dafna Hirschfeld 2020-09-01 366 return -EINVAL; 65926a5b1c6371 drivers/staging/media/rkisp1/rkisp1-capture.c Dafna Hirschfeld 2020-09-01 367 } 65926a5b1c6371 drivers/staging/media/rkisp1/rkisp1-capture.c Dafna Hirschfeld 2020-09-01 368 :::::: The code at line 361 was first introduced by commit :::::: 65926a5b1c6371c16edecfb4cd3d147af33201f4 UPSTREAM: media: staging: rkisp1: add a helper function to enumerate supported mbus formats on capture :::::: TO: Dafna Hirschfeld <dafna.hirschfeld(a)collabora.com&gt; :::::: CC: Commit Bot <commit-bot(a)chromium.org&gt; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org