4:49 a.m.
Hi Oleksij,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linux/master]
[also build test WARNING on linus/master v5.12-rc2]
[cannot apply to iio/togreg]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Oleksij-Rempel/mainline-ti-tsc20...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
a74e6a014c9d4d4161061f770c9b4f98372ac778
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/7c34f2cd7f0176071b53152c6065f6d5a...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Oleksij-Rempel/mainline-ti-tsc2046-adc-driver/20210312-185657
git checkout 7c34f2cd7f0176071b53152c6065f6d5a078463b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/device.h:15,
from include/linux/node.h:18,
from include/linux/cpu.h:17,
from include/linux/cacheinfo.h:6,
from arch/riscv/include/asm/cacheinfo.h:9,
from arch/riscv/include/asm/elf.h:14,
from include/linux/elf.h:6,
from include/linux/module.h:18,
from drivers/iio/adc/ti-tsc2046.c:10:
drivers/iio/adc/ti-tsc2046.c: In function 'tsc2046_adc_parse_fwnode':
> drivers/iio/adc/ti-tsc2046.c:579:17: warning: format '%i'
expects argument of type 'int', but argument 5 has type 'long unsigned
int' [-Wformat=]
579 | dev_err(dev, "%pfw: Unsupported reg value:
%i, max supported is: %i.\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
19 | #define dev_fmt(fmt) fmt
| ^~~
drivers/iio/adc/ti-tsc2046.c:579:4: note: in expansion of macro 'dev_err'
579 | dev_err(dev, "%pfw: Unsupported reg value: %i, max supported is:
%i.\n",
| ^~~~~~~
drivers/iio/adc/ti-tsc2046.c:579:70: note: format string is defined here
579 | dev_err(dev, "%pfw: Unsupported reg value: %i, max supported is:
%i.\n",
| ~^
| |
| int
| %li
vim +579 drivers/iio/adc/ti-tsc2046.c
561
562 static void tsc2046_adc_parse_fwnode(struct tsc2046_adc_priv *priv)
563 {
564 struct fwnode_handle *child;
565 struct device *dev = &priv->spi->dev;
566
567 device_for_each_child_node(dev, child) {
568 u32 stl, aver, reg;
569 int ret;
570
571 ret = fwnode_property_read_u32(child, "reg", ®);
572 if (ret) {
573 dev_err(dev, "invalid reg on %pfw, err: %pe\n", child,
574 ERR_PTR(ret));
575 continue;
576 }
577
578 if (reg >= ARRAY_SIZE(priv->ch_cfg)) {
579 dev_err(dev, "%pfw: Unsupported reg value: %i, max
supported is: %i.\n",
580 child, reg, ARRAY_SIZE(priv->ch_cfg));
581 continue;
582 }
583
584 ret = fwnode_property_read_u32(child, "settling-time-us", &stl);
585 if (!ret)
586 priv->ch_cfg[reg].settling_time_us = stl;
587
588 ret = fwnode_property_read_u32(child, "average-samples", &aver);
589 if (!ret)
590 priv->ch_cfg[reg].average_samples = aver;
591 }
592 }
593
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org