[kbuild-all] Re: [PATCH] fs/ext2: Use ext2_put_page

Hi, I love your patch! Yet something to improve: [auto build test ERROR on ext3/for_next] [also build test ERROR on linus/master linux/master v5.10-rc3 next-20201111] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/ira-weiny-intel-com/fs-ext2-Use-... base: https://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git for_next config: sh-allmodconfig (attached as .config) compiler: sh4-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/d24a7d5f9818dbc967629bb19cfa34856... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review ira-weiny-intel-com/fs-ext2-Use-ext2_put_page/20201112-050044 git checkout d24a7d5f9818dbc967629bb19cfa34856dbb7498 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All error/warnings (new ones prefixed by >>): In file included from fs/ext2/file.c:28: fs/ext2/ext2.h: In function 'ext2_get_page': 764 | if (PageError(page) || !ext2_check_page(page, quiet)) | ^~~~~~~~~~~~~~~ | ext2_get_page cc1: some warnings being treated as errors -- In file included from fs/ext2/ioctl.c:11: fs/ext2/ext2.h: In function 'ext2_get_page': 760 | struct page *page = read_mapping_page(mapping, n, NULL); | ^~~~~~~~~~~~~~~~~ | unmap_mapping_pages >> fs/ext2/ext2.h:760:22: warning: initialization of 'struct page *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 764 | if (PageError(page) || !ext2_check_page(page, quiet)) | ^~~~~~~~~~~~~~~ | ext2_get_page cc1: some warnings being treated as errors -- In file included from fs/ext2/balloc.c:15: fs/ext2/ext2.h: In function 'ext2_get_page': 760 | struct page *page = read_mapping_page(mapping, n, NULL); | ^~~~~~~~~~~~~~~~~ | unmap_mapping_pages >> fs/ext2/ext2.h:760:22: warning: initialization of 'struct page *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 764 | if (PageError(page) || !ext2_check_page(page, quiet)) | ^~~~~~~~~~~~~~~ | ext2_get_page In file included from include/linux/buffer_head.h:14, from fs/ext2/balloc.c:20: include/linux/pagemap.h: At top level: 497 | static inline struct page *read_mapping_page(struct address_space *mapping, | ^~~~~~~~~~~~~~~~~ In file included from fs/ext2/balloc.c:15: fs/ext2/ext2.h:760:22: note: previous implicit declaration of 'read_mapping_page' was here 760 | struct page *page = read_mapping_page(mapping, n, NULL); | ^~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from fs/ext2/dir.c:25: fs/ext2/ext2.h: In function 'ext2_get_page': 760 | struct page *page = read_mapping_page(mapping, n, NULL); | ^~~~~~~~~~~~~~~~~ | unmap_mapping_pages >> fs/ext2/ext2.h:760:22: warning: initialization of 'struct page *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 764 | if (PageError(page) || !ext2_check_page(page, quiet)) | ^~~~~~~~~~~~~~~ | ext2_get_page In file included from include/linux/buffer_head.h:14, from fs/ext2/dir.c:26: include/linux/pagemap.h: At top level: 497 | static inline struct page *read_mapping_page(struct address_space *mapping, | ^~~~~~~~~~~~~~~~~ In file included from fs/ext2/dir.c:25: fs/ext2/ext2.h:760:22: note: previous implicit declaration of 'read_mapping_page' was here 760 | struct page *page = read_mapping_page(mapping, n, NULL); | ^~~~~~~~~~~~~~~~~ 109 | static bool ext2_check_page(struct page *page, int quiet) | ^~~~~~~~~~~~~~~ In file included from fs/ext2/dir.c:25: fs/ext2/ext2.h:764:28: note: previous implicit declaration of 'ext2_check_page' was here 764 | if (PageError(page) || !ext2_check_page(page, quiet)) | ^~~~~~~~~~~~~~~ fs/ext2/dir.c:109:13: warning: 'ext2_check_page' defined but not used [-Wunused-function] 109 | static bool ext2_check_page(struct page *page, int quiet) | ^~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +764 fs/ext2/ext2.h 755 756 static inline struct page * ext2_get_page(struct inode *dir, unsigned long n, 757 int quiet) 758 { 759 struct address_space *mapping = dir->i_mapping; 761 if (!IS_ERR(page)) { 762 kmap(page); 763 if (unlikely(!PageChecked(page))) { 765 goto fail; 766 } 767 } 768 return page; 769 770 fail: 771 ext2_put_page(page); 772 return ERR_PTR(-EIO); 773 } 774 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org