[kbuild-all] [mcgrof-next:20211123-sysctl-cleanups 41/41] kernel/kprobes.c:52:1: error: function declaration isn't a prototype

tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git 20211123-sysctl-cleanups head: c18add41d859b4feec081eab6cfd624a5642973d commit: c18add41d859b4feec081eab6cfd624a5642973d [41/41] kprobe: move sysctl_kprobes_optimization to kprobes.c config: sparc-randconfig-r002-20211123 (https://download.01.org/0day-ci/archive/20211124/202111241540.e3ukBGer-lk...) compiler: sparc64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/com... git remote add mcgrof-next https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git git fetch --no-tags mcgrof-next 20211123-sysctl-cleanups git checkout c18add41d859b4feec081eab6cfd624a5642973d # save the config file to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=sparc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All error/warnings (new ones prefixed by >>): In file included from include/linux/key.h:17, from include/linux/cred.h:13, from include/linux/sched/signal.h:10, from include/linux/rcuwait.h:6, from include/linux/percpu-rwsem.h:7, from include/linux/fs.h:33, from include/linux/huge_mm.h:8, from include/linux/mm.h:717, from include/linux/kallsyms.h:13, from include/linux/ftrace.h:12, from include/linux/kprobes.h:28, from kernel/kprobes.c:23: include/linux/sysctl.h: In function 'register_sysctl_mount_point': include/linux/sysctl.h:270:1: error: expected ';' before '}' token 270 | } | ^ kernel/kprobes.c: At top level: kernel/kprobes.c:52:1: error: return type defaults to 'int' [-Werror=return-type] 52 | kprobe_sysctls_init() do { } while (0) | ^~~~~~~~~~~~~~~~~~~ kernel/kprobes.c: In function 'kprobe_sysctls_init': 52 | kprobe_sysctls_init() do { } while (0) | ^~ 52 | kprobe_sysctls_init() do { } while (0) | ^~~~~ 61 | static struct hlist_head kprobe_table[KPROBE_TABLE_SIZE]; | ^~~~~~~~~~~~ 64 | static bool kprobes_all_disarmed; | ^~~~~~~~~~~~~~~~~~~~ In file included from include/linux/notifier.h:14, from include/linux/kprobes.h:21, from kernel/kprobes.c:23: 67 | static DEFINE_MUTEX(kprobe_mutex); | ^~~~~~~~~~~~ include/linux/mutex.h:116:22: note: in definition of macro 'DEFINE_MUTEX' 116 | struct mutex mutexname = __MUTEX_INITIALIZER(mutexname) | ^~~~~~~~~ 116 | struct mutex mutexname = __MUTEX_INITIALIZER(mutexname) | ^~~~~ kernel/kprobes.c:67:8: note: in expansion of macro 'DEFINE_MUTEX' 67 | static DEFINE_MUTEX(kprobe_mutex); | ^~~~~~~~~~~~ In file included from include/asm-generic/percpu.h:7, from arch/sparc/include/asm/percpu_64.h:25, from arch/sparc/include/asm/percpu.h:5, from include/linux/irqflags.h:17, from include/asm-generic/cmpxchg-local.h:6, from arch/sparc/include/asm/cmpxchg_64.h:111, from arch/sparc/include/asm/cmpxchg.h:5, from arch/sparc/include/asm/atomic_64.h:12, from arch/sparc/include/asm/atomic.h:5, from include/linux/atomic.h:7, from include/asm-generic/bitops/lock.h:5, from arch/sparc/include/asm/bitops_64.h:52, from arch/sparc/include/asm/bitops.h:5, from include/linux/bitops.h:33, from include/linux/thread_info.h:27, from arch/sparc/include/asm/current.h:15, from include/linux/mutex.h:14, from include/linux/notifier.h:14, from include/linux/kprobes.h:21, from kernel/kprobes.c:23: 68 | static DEFINE_PER_CPU(struct kprobe *, kprobe_instance); | ^~~~~~~~~~~~~~~ include/linux/percpu-defs.h:104:44: note: in definition of macro 'DEFINE_PER_CPU_SECTION' 104 | __PCPU_ATTRS(sec) __typeof__(type) name | ^~~~ kernel/kprobes.c:68:8: note: in expansion of macro 'DEFINE_PER_CPU' 68 | static DEFINE_PER_CPU(struct kprobe *, kprobe_instance); | ^~~~~~~~~~~~~~ 68 | static DEFINE_PER_CPU(struct kprobe *, kprobe_instance); | ^~~~~~~~~~~~~~~ include/linux/percpu-defs.h:104:44: note: in definition of macro 'DEFINE_PER_CPU_SECTION' 104 | __PCPU_ATTRS(sec) __typeof__(type) name | ^~~~ kernel/kprobes.c:68:8: note: in expansion of macro 'DEFINE_PER_CPU' 68 | static DEFINE_PER_CPU(struct kprobe *, kprobe_instance); | ^~~~~~~~~~~~~~ 72 | { | ^ In file included from include/linux/kprobes.h:20, from kernel/kprobes.c:23: 80 | static LIST_HEAD(kprobe_blacklist); | ^~~~~~~~~~~~~~~~ include/linux/list.h:26:26: note: in definition of macro 'LIST_HEAD' 26 | struct list_head name = LIST_HEAD_INIT(name) | ^~~~ 26 | struct list_head name = LIST_HEAD_INIT(name) | ^~~~~~~~~ kernel/kprobes.c:80:8: note: in expansion of macro 'LIST_HEAD' 80 | static LIST_HEAD(kprobe_blacklist); | ^~~~~~~~~ kernel/kprobes.c:361:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token 361 | { | ^ kernel/kprobes.c:366:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token 366 | { | ^ kernel/kprobes.c:377:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token 377 | { | ^ In file included from arch/sparc/include/asm/kprobes.h:5, from include/linux/kprobes.h:31, from kernel/kprobes.c:23: 14 | _kbl_addr_##fname = (unsigned long)fname; | ^~~~~~~~~~ include/asm-generic/kprobes.h:15:33: note: in expansion of macro '__NOKPROBE_SYMBOL' 15 | # define NOKPROBE_SYMBOL(fname) __NOKPROBE_SYMBOL(fname) | ^~~~~~~~~~~~~~~~~ kernel/kprobes.c:390:1: note: in expansion of macro 'NOKPROBE_SYMBOL' 390 | NOKPROBE_SYMBOL(get_kprobe); | ^~~~~~~~~~~~~~~ In file included from arch/sparc/include/asm/kprobes.h:5, from include/linux/kprobes.h:31, from kernel/kprobes.c:23: 14 | _kbl_addr_##fname = (unsigned long)fname; | ^~~~~~~~~~ include/asm-generic/kprobes.h:15:33: note: in expansion of macro '__NOKPROBE_SYMBOL' 15 | # define NOKPROBE_SYMBOL(fname) __NOKPROBE_SYMBOL(fname) | ^~~~~~~~~~~~~~~~~ kernel/kprobes.c:390:1: note: in expansion of macro 'NOKPROBE_SYMBOL' 390 | NOKPROBE_SYMBOL(get_kprobe); | ^~~~~~~~~~~~~~~ 390 | NOKPROBE_SYMBOL(get_kprobe); | ^ 392 | static int aggr_pre_handler(struct kprobe *p, struct pt_regs *regs); | ^~~~~~~~~~~~~~~~ kernel/kprobes.c:396:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token 396 | { | ^ kernel/kprobes.c:402:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token 402 | { | ^ kernel/kprobes.c:409:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token 409 | { | ^ kernel/kprobes.c:1038:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token 1038 | { | ^ kernel/kprobes.c:1050:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token 1050 | { | ^ kernel/kprobes.c:1056:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token 1056 | { | ^ kernel/kprobes.c:1144:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token 1144 | { | ^ kernel/kprobes.c:1149:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token 1149 | { | ^ kernel/kprobes.c:1155:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token 1155 | { | ^ kernel/kprobes.c:1164:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token 1164 | { | ^ kernel/kprobes.c:1178:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token 1178 | { | ^ kernel/kprobes.c:1196:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token 1196 | { | ^ In file included from arch/sparc/include/asm/kprobes.h:5, from include/linux/kprobes.h:31, from kernel/kprobes.c:23: 14 | _kbl_addr_##fname = (unsigned long)fname; | ^~~~~~~~~~ include/asm-generic/kprobes.h:15:33: note: in expansion of macro '__NOKPROBE_SYMBOL' 15 | # define NOKPROBE_SYMBOL(fname) __NOKPROBE_SYMBOL(fname) | ^~~~~~~~~~~~~~~~~ kernel/kprobes.c:1209:1: note: in expansion of macro 'NOKPROBE_SYMBOL' 1209 | NOKPROBE_SYMBOL(aggr_pre_handler); | ^~~~~~~~~~~~~~~ kernel/kprobes.c:1209:1: warning: 'used' attribute ignored [-Wattributes] In file included from arch/sparc/include/asm/kprobes.h:5, from include/linux/kprobes.h:31, from kernel/kprobes.c:23: include/asm-generic/kprobes.h:14:9: error: section attribute not allowed for '_kbl_addr_aggr_pre_handler' 14 | _kbl_addr_##fname = (unsigned long)fname; | ^~~~~~~~~~ include/asm-generic/kprobes.h:15:33: note: in expansion of macro '__NOKPROBE_SYMBOL' 15 | # define NOKPROBE_SYMBOL(fname) __NOKPROBE_SYMBOL(fname) | ^~~~~~~~~~~~~~~~~ kernel/kprobes.c:1209:1: note: in expansion of macro 'NOKPROBE_SYMBOL' 1209 | NOKPROBE_SYMBOL(aggr_pre_handler); | ^~~~~~~~~~~~~~~ kernel/kprobes.c:1209:34: error: expected declaration specifiers before ';' token 1209 | NOKPROBE_SYMBOL(aggr_pre_handler); | ^ kernel/kprobes.c:1213:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token 1213 | { | ^ In file included from arch/sparc/include/asm/kprobes.h:5, from include/linux/kprobes.h:31, from kernel/kprobes.c:23: include/asm-generic/kprobes.h:14:9: error: storage class specified for parameter '_kbl_addr_aggr_post_handler' 14 | _kbl_addr_##fname = (unsigned long)fname; | ^~~~~~~~~~ include/asm-generic/kprobes.h:15:33: note: in expansion of macro '__NOKPROBE_SYMBOL' 15 | # define NOKPROBE_SYMBOL(fname) __NOKPROBE_SYMBOL(fname) | ^~~~~~~~~~~~~~~~~ kernel/kprobes.c:1224:1: note: in expansion of macro 'NOKPROBE_SYMBOL' 1224 | NOKPROBE_SYMBOL(aggr_post_handler); | ^~~~~~~~~~~~~~~ kernel/kprobes.c:1224:1: error: parameter '_kbl_addr_aggr_post_handler' is initialized kernel/kprobes.c:1224:1: warning: 'used' attribute ignored [-Wattributes] In file included from arch/sparc/include/asm/kprobes.h:5, from include/linux/kprobes.h:31, from kernel/kprobes.c:23: include/asm-generic/kprobes.h:14:9: error: section attribute not allowed for '_kbl_addr_aggr_post_handler' 14 | _kbl_addr_##fname = (unsigned long)fname; | ^~~~~~~~~~ include/asm-generic/kprobes.h:15:33: note: in expansion of macro '__NOKPROBE_SYMBOL' 15 | # define NOKPROBE_SYMBOL(fname) __NOKPROBE_SYMBOL(fname) | ^~~~~~~~~~~~~~~~~ kernel/kprobes.c:1224:1: note: in expansion of macro 'NOKPROBE_SYMBOL' 1224 | NOKPROBE_SYMBOL(aggr_post_handler); | ^~~~~~~~~~~~~~~ kernel/kprobes.c:1224:17: error: 'aggr_post_handler' undeclared (first use in this function); did you mean 'aggr_pre_handler'? 1224 | NOKPROBE_SYMBOL(aggr_post_handler); | ^~~~~~~~~~~~~~~~~ include/asm-generic/kprobes.h:14:44: note: in definition of macro '__NOKPROBE_SYMBOL' 14 | _kbl_addr_##fname = (unsigned long)fname; | ^~~~~ kernel/kprobes.c:1224:1: note: in expansion of macro 'NOKPROBE_SYMBOL' 1224 | NOKPROBE_SYMBOL(aggr_post_handler); | ^~~~~~~~~~~~~~~ kernel/kprobes.c:1224:17: note: each undeclared identifier is reported only once for each function it appears in 1224 | NOKPROBE_SYMBOL(aggr_post_handler); | ^~~~~~~~~~~~~~~~~ include/asm-generic/kprobes.h:14:44: note: in definition of macro '__NOKPROBE_SYMBOL' 14 | _kbl_addr_##fname = (unsigned long)fname; | ^~~~~ kernel/kprobes.c:1224:1: note: in expansion of macro 'NOKPROBE_SYMBOL' 1224 | NOKPROBE_SYMBOL(aggr_post_handler); | ^~~~~~~~~~~~~~~ kernel/kprobes.c:1224:35: error: expected declaration specifiers before ';' token 1224 | NOKPROBE_SYMBOL(aggr_post_handler); | ^ kernel/kprobes.c:1228:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token 1228 | { | ^ In file included from arch/sparc/include/asm/kprobes.h:5, from include/linux/kprobes.h:31, from kernel/kprobes.c:23: include/asm-generic/kprobes.h:14:9: error: storage class specified for parameter '_kbl_addr_kprobes_inc_nmissed_count' 14 | _kbl_addr_##fname = (unsigned long)fname; | ^~~~~~~~~~ include/asm-generic/kprobes.h:15:33: note: in expansion of macro '__NOKPROBE_SYMBOL' 15 | # define NOKPROBE_SYMBOL(fname) __NOKPROBE_SYMBOL(fname) | ^~~~~~~~~~~~~~~~~ kernel/kprobes.c:1238:1: note: in expansion of macro 'NOKPROBE_SYMBOL' 1238 | NOKPROBE_SYMBOL(kprobes_inc_nmissed_count); | ^~~~~~~~~~~~~~~ kernel/kprobes.c:1238:1: error: parameter '_kbl_addr_kprobes_inc_nmissed_count' is initialized kernel/kprobes.c:1238:1: warning: 'used' attribute ignored [-Wattributes] In file included from arch/sparc/include/asm/kprobes.h:5, from include/linux/kprobes.h:31, from kernel/kprobes.c:23: include/asm-generic/kprobes.h:14:9: error: section attribute not allowed for '_kbl_addr_kprobes_inc_nmissed_count' 14 | _kbl_addr_##fname = (unsigned long)fname; | ^~~~~~~~~~ include/asm-generic/kprobes.h:15:33: note: in expansion of macro '__NOKPROBE_SYMBOL' 15 | # define NOKPROBE_SYMBOL(fname) __NOKPROBE_SYMBOL(fname) | ^~~~~~~~~~~~~~~~~ kernel/kprobes.c:1238:1: note: in expansion of macro 'NOKPROBE_SYMBOL' 1238 | NOKPROBE_SYMBOL(kprobes_inc_nmissed_count); | ^~~~~~~~~~~~~~~ kernel/kprobes.c:1238:43: error: expected declaration specifiers before ';' token 1238 | NOKPROBE_SYMBOL(kprobes_inc_nmissed_count); | ^ kernel/kprobes.c:1241:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token 1241 | { vim +52 kernel/kprobes.c 50 51 #ifndef CONFIG_SYSCTL 53 #endif 54 55 static int kprobes_initialized; 56 /* kprobe_table can be accessed by 57 * - Normal hlist traversal and RCU add/del under 'kprobe_mutex' is held. 58 * Or 59 * - RCU hlist traversal under disabling preempt (breakpoint handlers) 60 */ 62 63 /* NOTE: change this value only with 'kprobe_mutex' held */ 65 66 /* This protects 'kprobe_table' and 'optimizing_list' */ 69 70 kprobe_opcode_t * __weak kprobe_lookup_name(const char *name, 71 unsigned int __unused) 73 return ((kprobe_opcode_t *)(kallsyms_lookup_name(name))); 74 } 75 76 /* 77 * Blacklist -- list of 'struct kprobe_blacklist_entry' to store info where 78 * kprobes can not probe. 79 */ 81 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org