4:24 a.m.
From: kernel test robot <lkp(a)intel.com>
fs/ocfs2/dlmfs/dlmfs.c:140:2-5: WARNING: Use BUG_ON
fs/ocfs2/dlmfs/dlmfs.c:187:2-5: WARNING: Use BUG_ON
Use BUG_ON instead of a if condition followed by BUG.
Semantic patch information:
This makes an effort to find cases where BUG() follows an if
condition on an expression and replaces the if condition and BUG()
with a BUG_ON having the conditional expression of the if statement
as argument.
Generated by: scripts/coccinelle/misc/bugon.cocci
Fixes: 8214bf079208 ("scripts/dtc: Export YYLOC global declaration")
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: https://android.googlesource.com/kernel/goldfish android-3.18
head: dd54b61f1458c03f68fc019b4874d98f2f0ae3a5
commit: 8214bf079208b146e63cd0a3ce0ed335a87ce7b3 [396/1051] scripts/dtc: Export YYLOC
global declaration
:::::: branch date: 5 weeks ago
:::::: commit date: 3 months ago
Please take the patch only if it's a positive warning. Thanks!
dlmfs.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
--- a/fs/ocfs2/dlmfs/dlmfs.c
+++ b/fs/ocfs2/dlmfs/dlmfs.c
@@ -136,8 +136,7 @@ static int dlmfs_file_open(struct inode
struct dlmfs_filp_private *fp = NULL;
struct dlmfs_inode_private *ip;
- if (S_ISDIR(inode->i_mode))
- BUG();
+ BUG_ON(S_ISDIR(inode->i_mode));
mlog(0, "open called on inode %lu, flags 0x%x\n", inode->i_ino,
file->f_flags);
@@ -183,8 +182,7 @@ static int dlmfs_file_release(struct ino
struct dlmfs_inode_private *ip = DLMFS_I(inode);
struct dlmfs_filp_private *fp = file->private_data;
- if (S_ISDIR(inode->i_mode))
- BUG();
+ BUG_ON(S_ISDIR(inode->i_mode));
mlog(0, "close called on inode %lu\n", inode->i_ino);