[kbuild-all] Re: [PATCH v3 05/11] riscv: Add clear_bit_unlock_is_negative_byte implementation

Hi Matthew, Thank you for the patch! Yet something to improve: [auto build test ERROR on ia64/next] [also build test ERROR on m68k/for-next s390/features linus/master v5.7-rc1 next-20200416] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Matthew-Wilcox/Make-PageWritebac... base: https://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.git next config: riscv-allyesconfig (attached as .config) compiler: riscv64-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=riscv If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): In file included from include/linux/bitops.h:29, from include/linux/kernel.h:12, from include/asm-generic/bug.h:19, from arch/riscv/include/asm/bug.h:75, from include/linux/bug.h:5, from include/linux/page-flags.h:10, from kernel/bounds.c:10: arch/riscv/include/asm/bitops.h: In function 'clear_bit_unlock_is_negative_byte': arch/riscv/include/asm/bitops.h:178:9: error: implicit declaration of function 'test_bit'; did you mean 'set_bit'? [-Werror=implicit-function-declaration] 178 | return test_bit(7, p); | ^~~~~~~~ | set_bit In file included from arch/riscv/include/asm/bitops.h:208, from include/linux/bitops.h:29, from include/linux/kernel.h:12, from include/asm-generic/bug.h:19, from arch/riscv/include/asm/bug.h:75, from include/linux/bug.h:5, from include/linux/page-flags.h:10, from kernel/bounds.c:10: include/asm-generic/bitops/non-atomic.h: At top level: 104 | static inline int test_bit(int nr, const volatile unsigned long *addr) | ^~~~~~~~ In file included from include/linux/bitops.h:29, from include/linux/kernel.h:12, from include/asm-generic/bug.h:19, from arch/riscv/include/asm/bug.h:75, from include/linux/bug.h:5, from include/linux/page-flags.h:10, from kernel/bounds.c:10: arch/riscv/include/asm/bitops.h:178:9: note: previous implicit declaration of 'test_bit' was here 178 | return test_bit(7, p); | ^~~~~~~~ cc1: some warnings being treated as errors make[2]: *** [scripts/Makefile.build:101: kernel/bounds.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1113: prepare0] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:180: sub-make] Error 2 34 real 4 user 6 sys 29.68% cpu make prepare vim +/test_bit +104 include/asm-generic/bitops/non-atomic.h 4117b02132d1cf9 Akinobu Mita 2006-03-26 98 4117b02132d1cf9 Akinobu Mita 2006-03-26 99 /** 4117b02132d1cf9 Akinobu Mita 2006-03-26 100 * test_bit - Determine whether a bit is set 4117b02132d1cf9 Akinobu Mita 2006-03-26 101 * @nr: bit number to test 4117b02132d1cf9 Akinobu Mita 2006-03-26 102 * @addr: Address to start counting from 4117b02132d1cf9 Akinobu Mita 2006-03-26 103 */ 4117b02132d1cf9 Akinobu Mita 2006-03-26 @104 static inline int test_bit(int nr, const volatile unsigned long *addr) 4117b02132d1cf9 Akinobu Mita 2006-03-26 105 { d05be13bcc6ec61 Jiri Slaby 2007-10-18 106 return 1UL & (addr[BIT_WORD(nr)] >> (nr & (BITS_PER_LONG-1))); 4117b02132d1cf9 Akinobu Mita 2006-03-26 107 } 4117b02132d1cf9 Akinobu Mita 2006-03-26 108 :::::: The code at line 104 was first introduced by commit :::::: 4117b02132d1cf96a3e1c57148e302c4801c974d [PATCH] bitops: generic __{,test_and_}{set,clear,change}_bit() and test_bit() :::::: TO: Akinobu Mita <mita(a)miraclelinux.com&gt; :::::: CC: Linus Torvalds <torvalds(a)g5.osdl.org&gt; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org