4:40 a.m.
Hi Takashi,
I love your patch! Perhaps something to improve:
[auto build test WARNING on sound/for-next]
[also build test WARNING on v5.14-rc1 next-20210713]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Takashi-Iwai/ALSA-More-devres-us...
base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: arm64-buildonly-randconfig-r003-20210713 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project
8d69635ed9ecf36fd0ca85906bfde17949671cbe)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
#
https://github.com/0day-ci/linux/commit/2fe9eb4f2c4739f0452db5aee6618679d...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Takashi-Iwai/ALSA-More-devres-usages/20210713-225131
git checkout 2fe9eb4f2c4739f0452db5aee6618679da3adc73
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> sound/pci/via82xx_modem.c:1075:2: warning: variable
'chip' is uninitialized when used here [-Wuninitialized]
chip->card = card;
^~~~
sound/pci/via82xx_modem.c:1067:28: note: initialize the variable 'chip' to
silence this warning
struct via82xx_modem *chip;
^
= NULL
1 warning generated.
vim +/chip +1075 sound/pci/via82xx_modem.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 1060
e23e7a14362072 Bill Pemberton 2012-12-06 1061 static int snd_via82xx_create(struct
snd_card *card,
^1da177e4c3f41 Linus Torvalds 2005-04-16 1062 struct pci_dev *pci,
^1da177e4c3f41 Linus Torvalds 2005-04-16 1063 int chip_type,
^1da177e4c3f41 Linus Torvalds 2005-04-16 1064 int revision,
2fe9eb4f2c4739 Takashi Iwai 2021-07-13 1065 unsigned int ac97_clock)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1066 {
e437e3d7c7fb65 Takashi Iwai 2005-11-17 1067 struct via82xx_modem *chip;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1068 int err;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1069
2fe9eb4f2c4739 Takashi Iwai 2021-07-13 1070 err = pcim_enable_device(pci);
afb342f02241a9 Takashi Iwai 2021-06-08 1071 if (err < 0)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1072 return err;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1073
^1da177e4c3f41 Linus Torvalds 2005-04-16 1074 spin_lock_init(&chip->reg_lock);
^1da177e4c3f41 Linus Torvalds 2005-04-16 @1075 chip->card = card;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1076 chip->pci = pci;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1077 chip->irq = -1;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1078
afb342f02241a9 Takashi Iwai 2021-06-08 1079 err = pci_request_regions(pci,
card->driver);
2fe9eb4f2c4739 Takashi Iwai 2021-07-13 1080 if (err < 0)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1081 return err;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1082 chip->port = pci_resource_start(pci,
0);
2fe9eb4f2c4739 Takashi Iwai 2021-07-13 1083 if (devm_request_irq(&pci->dev,
pci->irq, snd_via82xx_interrupt,
2fe9eb4f2c4739 Takashi Iwai 2021-07-13 1084 IRQF_SHARED, KBUILD_MODNAME,
chip)) {
473439e06a2562 Takashi Iwai 2014-02-25 1085 dev_err(card->dev, "unable to
grab IRQ %d\n", pci->irq);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1086 return -EBUSY;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1087 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1088 chip->irq = pci->irq;
c47583b0eb6847 Takashi Iwai 2019-12-10 1089 card->sync_irq = chip->irq;
2fe9eb4f2c4739 Takashi Iwai 2021-07-13 1090 card->private_free =
snd_via82xx_free;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1091 if (ac97_clock >= 8000 &&
ac97_clock <= 48000)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1092 chip->ac97_clock = ac97_clock;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1093
afb342f02241a9 Takashi Iwai 2021-06-08 1094 err = snd_via82xx_chip_init(chip);
2fe9eb4f2c4739 Takashi Iwai 2021-07-13 1095 if (err < 0)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1096 return err;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1097
^1da177e4c3f41 Linus Torvalds 2005-04-16 1098 /* The 8233 ac97 controller does not
implement the master bit
^1da177e4c3f41 Linus Torvalds 2005-04-16 1099 * in the pci command register. IMHO this
is a violation of the PCI spec.
^1da177e4c3f41 Linus Torvalds 2005-04-16 1100 * We call pci_set_master here because it
does not hurt. */
^1da177e4c3f41 Linus Torvalds 2005-04-16 1101 pci_set_master(pci);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1102 return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1103 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1104
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org