2:24 a.m.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci/error
head: 5692817fc88f347328e35cd7b19bd04f4400652e
commit: 8fae7d8809b8151488969d6cfad2f6dd2c69d311 [2/8] PCI/ERR: Simplify
pci_dev_set_io_state()
config: i386-randconfig-m021-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
New smatch warnings:
drivers/pci/hotplug/../pci.h:348 pci_dev_set_io_state() warn: statement has no effect 22
vim +348 drivers/pci/hotplug/../pci.h
a6bd101b8f84f9b Keith Busch 2018-09-20 341 static inline bool
pci_dev_set_io_state(struct pci_dev *dev,
a6bd101b8f84f9b Keith Busch 2018-09-20 342 pci_channel_state_t new)
a6bd101b8f84f9b Keith Busch 2018-09-20 343 {
a6bd101b8f84f9b Keith Busch 2018-09-20 344 device_lock_assert(&dev->dev);
8fae7d8809b8151 Bjorn Helgaas 2020-05-19 345
8fae7d8809b8151 Bjorn Helgaas 2020-05-19 346 /* Can always put a device in perm_failure
state */
8fae7d8809b8151 Bjorn Helgaas 2020-05-19 347 if (new == pci_channel_io_perm_failure) {
8fae7d8809b8151 Bjorn Helgaas 2020-05-19 @348 dev->error_state ==
pci_channel_io_perm_failure;
This should be = instead of ==.
8fae7d8809b8151 Bjorn Helgaas 2020-05-19 349 return true;
a6bd101b8f84f9b Keith Busch 2018-09-20 350 }
8fae7d8809b8151 Bjorn Helgaas 2020-05-19 351
8fae7d8809b8151 Bjorn Helgaas 2020-05-19 352 /* If already in perm_failure, can't
set to normal or frozen */
8fae7d8809b8151 Bjorn Helgaas 2020-05-19 353 if (dev->error_state ==
pci_channel_io_perm_failure)
8fae7d8809b8151 Bjorn Helgaas 2020-05-19 354 return false;
8fae7d8809b8151 Bjorn Helgaas 2020-05-19 355
8fae7d8809b8151 Bjorn Helgaas 2020-05-19 356 /* Can always change normal to frozen or
vice versa */
a6bd101b8f84f9b Keith Busch 2018-09-20 357 dev->error_state = new;
8fae7d8809b8151 Bjorn Helgaas 2020-05-19 358 return true;
a6bd101b8f84f9b Keith Busch 2018-09-20 359 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org