[kbuild-all] Re: [PATCH] brcmfmac: Configure keep-alive packet on suspend

Hi Loic, I love your patch! Perhaps something to improve: [auto build test WARNING on kvalo-wireless-drivers-next/master] [also build test WARNING on kvalo-wireless-drivers/master v5.16-rc2 next-20211118] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Loic-Poulain/brcmfmac-Configure-... base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-ne... master config: riscv-randconfig-r002-20211122 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c133fb321f7ca6083ce15b6aa5bf89de6600e649) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://github.com/0day-ci/linux/commit/13a67e895024e7cdbf0faa409fe3349cb... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Loic-Poulain/brcmfmac-Configure-keep-alive-packet-on-suspend/20211122-165520 git checkout 13a67e895024e7cdbf0faa409fe3349cb0d741fc # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=riscv If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): int brcmf_keepalive_start(struct brcmf_if *ifp, unsigned int interval) ^ drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:3904:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int brcmf_keepalive_start(struct brcmf_if *ifp, unsigned int interval) ^ static 1 warning generated. vim +/brcmf_keepalive_start +3904 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c 3903 3905 { 3906 struct brcmf_mkeep_alive_pkt_le kalive = {0}; 3907 int ret = 0; 3908 3909 /* Configure Null function/data keepalive */ 3910 kalive.version = cpu_to_le16(1); 3911 kalive.period_msec = cpu_to_le16(interval * MSEC_PER_SEC); 3912 kalive.len_bytes = cpu_to_le16(0); 3913 kalive.keep_alive_id = cpu_to_le16(0); 3914 3915 ret = brcmf_fil_iovar_data_set(ifp, "mkeep_alive", &kalive, sizeof(kalive)); 3916 if (ret) 3917 brcmf_err("keep-alive packet config failed, ret=%d\n", ret); 3918 3919 return ret; 3920 } 3921 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org