[kbuild-all] Re: [PATCH v2 3/5] mt76: mt7663s: rely on mt76_connac_pm_ref/mt76_connac_pm_unref in tx path

Hi Lorenzo, I love your patch! Yet something to improve: [auto build test ERROR on wireless-drivers/master] [also build test ERROR on v5.13-rc6 next-20210618] [cannot apply to wireless-drivers-next/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Lorenzo-Bianconi/mt7663s-enable-... base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git master config: mips-allyesconfig (attached as .config) compiler: mips-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/80a27acf098f3392d9b7392c1af5678aa... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Lorenzo-Bianconi/mt7663s-enable-runtime-pm-support/20210618-161033 git checkout 80a27acf098f3392d9b7392c1af5678aa154da72 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): drivers/net/wireless/mediatek/mt76/mt7615/sdio_txrx.c: In function 'mt7663s_txrx_worker': 322 | mt76_connac_pm_unref(&dev->mphy, &dev->pm); | ^~~~~~~~~~ | | | struct mt76_phy * In file included from drivers/net/wireless/mediatek/mt76/mt7615/../mt76_connac_mcu.h:7, from drivers/net/wireless/mediatek/mt76/mt7615/mt7615.h:11, from drivers/net/wireless/mediatek/mt76/mt7615/sdio_txrx.c:18: drivers/net/wireless/mediatek/mt76/mt7615/../mt76_connac.h:119:45: note: expected 'struct mt76_connac_pm *' but argument is of type 'struct mt76_phy *' 119 | mt76_connac_pm_unref(struct mt76_connac_pm *pm) | ~~~~~~~~~~~~~~~~~~~~~~~^~ 322 | mt76_connac_pm_unref(&dev->mphy, &dev->pm); | ^~~~~~~~~~~~~~~~~~~~ In file included from drivers/net/wireless/mediatek/mt76/mt7615/../mt76_connac_mcu.h:7, from drivers/net/wireless/mediatek/mt76/mt7615/mt7615.h:11, from drivers/net/wireless/mediatek/mt76/mt7615/sdio_txrx.c:18: drivers/net/wireless/mediatek/mt76/mt7615/../mt76_connac.h:119:1: note: declared here 119 | mt76_connac_pm_unref(struct mt76_connac_pm *pm) | ^~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/mt76_connac_pm_unref +322 drivers/net/wireless/mediatek/mt76/mt7615/sdio_txrx.c 281 282 void mt7663s_txrx_worker(struct mt76_worker *w) 283 { 284 struct mt76_sdio *sdio = container_of(w, struct mt76_sdio, 285 txrx_worker); 286 struct mt76_dev *mdev = container_of(sdio, struct mt76_dev, sdio); 287 struct mt7615_dev *dev = container_of(mdev, struct mt7615_dev, mt76); 288 int i, nframes, ret; 289 290 if (!mt76_connac_pm_ref(&dev->mphy, &dev->pm)) { 291 queue_work(mdev->wq, &dev->pm.wake_work); 292 return; 293 } 294 295 /* disable interrupt */ 296 sdio_claim_host(sdio->func); 297 sdio_writel(sdio->func, WHLPCR_INT_EN_CLR, MCR_WHLPCR, NULL); 298 299 do { 300 nframes = 0; 301 302 /* tx */ 303 for (i = 0; i <= MT_TXQ_PSD; i++) { 304 ret = mt7663s_tx_run_queue(mdev, mdev->phy.q_tx[i]); 305 if (ret > 0) 306 nframes += ret; 307 } 308 ret = mt7663s_tx_run_queue(mdev, mdev->q_mcu[MT_MCUQ_WM]); 309 if (ret > 0) 310 nframes += ret; 311 312 /* rx */ 313 ret = mt7663s_rx_handler(mdev); 314 if (ret > 0) 315 nframes += ret; 316 } while (nframes > 0); 317 318 /* enable interrupt */ 319 sdio_writel(sdio->func, WHLPCR_INT_EN_SET, MCR_WHLPCR, NULL); 320 sdio_release_host(sdio->func); 321 323 } 324 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org