[kbuild-all] Re: [PATCH v1 1/9] drivers: hv: dxgkrnl: Driver initialization and creation of dxgadapter

Hi Iouri, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.16 next-20220113] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Iouri-Tarassov/drivers-hv-dxgkrn... base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git e3084ed48fd6b661fe434da0cb36d7d6706cf27f config: arm64-randconfig-r032-20220113 (https://download.01.org/0day-ci/archive/20220113/202201131405.tgtilUdq-lk...) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project d1021978b8e7e35dcc30201ca1731d64b5a602a8) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://github.com/0day-ci/linux/commit/00f97c12e2cf0ba4ba1108e2fce9a3d0e... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Iouri-Tarassov/drivers-hv-dxgkrnl-Driver-overview/20220113-035836 git checkout 00f97c12e2cf0ba4ba1108e2fce9a3d0e287cc8c # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/hv/dxgkrnl/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): struct dxgadapter *find_pci_adapter(struct pci_dev *dev) ^ drivers/hv/dxgkrnl/dxgmodule.c:79:1: note: declare 'static' if the function is not intended to be used outside of this translation unit struct dxgadapter *find_pci_adapter(struct pci_dev *dev) ^ static void signal_host_cpu_event(struct dxghostevent *eventhdr) ^ drivers/hv/dxgkrnl/dxgmodule.c:135:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void signal_host_cpu_event(struct dxghostevent *eventhdr) ^ static int dxgglobal_create_adapter(struct pci_dev *dev, guid_t *guid, ^ drivers/hv/dxgkrnl/dxgmodule.c:219:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int dxgglobal_create_adapter(struct pci_dev *dev, guid_t *guid, ^ static 3 warnings generated. -- In file included from drivers/hv/dxgkrnl/dxgvmbus.c:22: drivers/hv/dxgkrnl/dxgvmbus.h:867:26: warning: implicit conversion from enumeration type 'enum dxgkvmb_commandtype' to different enumeration type 'enum dxgkvmb_commandtype_global' [-Wenum-conversion] command->command_type = DXGK_VMBCOMMAND_INVALID; ~ ^~~~~~~~~~~~~~~~~~~~~~~ int ntstatus2int(struct ntstatus status) ^ drivers/hv/dxgkrnl/dxgvmbus.c:116:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int ntstatus2int(struct ntstatus status) ^ static void process_inband_packet(struct dxgvmbuschannel *channel, ^ drivers/hv/dxgkrnl/dxgvmbus.c:219:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void process_inband_packet(struct dxgvmbuschannel *channel, ^ static void process_completion_packet(struct dxgvmbuschannel *channel, ^ drivers/hv/dxgkrnl/dxgvmbus.c:237:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void process_completion_packet(struct dxgvmbuschannel *channel, ^ static int dxgvmb_send_async_msg(struct dxgvmbuschannel *channel, ^ drivers/hv/dxgkrnl/dxgvmbus.c:363:1: note: declare 'static' if the function is not intended to be used outside of this translation unit int dxgvmb_send_async_msg(struct dxgvmbuschannel *channel, ^ static drivers/hv/dxgkrnl/dxgvmbus.c:199:20: warning: unused function 'command_vm_to_host_init0' [-Wunused-function] static inline void command_vm_to_host_init0(struct dxgkvmb_command_vm_to_host ^ 6 warnings generated. vim +/find_pci_adapter +79 drivers/hv/dxgkrnl/dxgmodule.c 78 80 { 81 struct dxgadapter *entry; 82 struct dxgadapter *adapter = NULL; 83 84 dxgglobal_acquire_adapter_list_lock(DXGLOCK_EXCL); 85 86 list_for_each_entry(entry, &dxgglobal->adapter_list_head, 87 adapter_list_entry) { 88 if (dev == entry->pci_dev) { 89 adapter = entry; 90 break; 91 } 92 } 93 94 dxgglobal_release_adapter_list_lock(DXGLOCK_EXCL); 95 return adapter; 96 } 97 98 static struct dxgadapter *find_adapter(struct winluid *luid) 99 { 100 struct dxgadapter *entry; 101 struct dxgadapter *adapter = NULL; 102 103 dxgglobal_acquire_adapter_list_lock(DXGLOCK_EXCL); 104 105 list_for_each_entry(entry, &dxgglobal->adapter_list_head, 106 adapter_list_entry) { 107 if (memcmp(luid, &entry->luid, sizeof(struct winluid)) == 0) { 108 adapter = entry; 109 break; 110 } 111 } 112 113 dxgglobal_release_adapter_list_lock(DXGLOCK_EXCL); 114 return adapter; 115 } 116 117 void dxgglobal_add_host_event(struct dxghostevent *event) 118 { 119 spin_lock_irq(&dxgglobal->host_event_list_mutex); 120 list_add_tail(&event->host_event_list_entry, 121 &dxgglobal->host_event_list_head); 122 spin_unlock_irq(&dxgglobal->host_event_list_mutex); 123 } 124 125 void dxgglobal_remove_host_event(struct dxghostevent *event) 126 { 127 spin_lock_irq(&dxgglobal->host_event_list_mutex); 128 if (event->host_event_list_entry.next != NULL) { 129 list_del(&event->host_event_list_entry); 130 event->host_event_list_entry.next = NULL; 131 } 132 spin_unlock_irq(&dxgglobal->host_event_list_mutex); 133 } 134 136 { 137 struct dxghosteventcpu *event = (struct dxghosteventcpu *)eventhdr; 138 139 if (event->remove_from_list || 140 event->destroy_after_signal) { 141 list_del(&eventhdr->host_event_list_entry); 142 eventhdr->host_event_list_entry.next = NULL; 143 } 144 if (event->cpu_event) { 145 dev_dbg(dxgglobaldev, "signal cpu event\n"); 146 eventfd_signal(event->cpu_event, 1); 147 if (event->destroy_after_signal) 148 eventfd_ctx_put(event->cpu_event); 149 } else { 150 dev_dbg(dxgglobaldev, "signal completion\n"); 151 complete(event->completion_event); 152 } 153 if (event->destroy_after_signal) { 154 dev_dbg(dxgglobaldev, "destroying event %p\n", 155 event); 156 vfree(event); 157 } 158 } 159 160 void dxgglobal_signal_host_event(u64 event_id) 161 { 162 struct dxghostevent *event; 163 unsigned long flags; 164 165 dev_dbg(dxgglobaldev, "%s %lld\n", __func__, event_id); 166 167 spin_lock_irqsave(&dxgglobal->host_event_list_mutex, flags); 168 list_for_each_entry(event, &dxgglobal->host_event_list_head, 169 host_event_list_entry) { 170 if (event->event_id == event_id) { 171 dev_dbg(dxgglobaldev, "found event to signal %lld\n", 172 event_id); 173 if (event->event_type == dxghostevent_cpu_event) 174 signal_host_cpu_event(event); 175 else 176 pr_err("Unknown host event type"); 177 break; 178 } 179 } 180 spin_unlock_irqrestore(&dxgglobal->host_event_list_mutex, flags); 181 dev_dbg(dxgglobaldev, "dxgglobal_signal_host_event_end %lld\n", 182 event_id); 183 } 184 185 struct dxghostevent *dxgglobal_get_host_event(u64 event_id) 186 { 187 struct dxghostevent *entry; 188 struct dxghostevent *event = NULL; 189 190 spin_lock_irq(&dxgglobal->host_event_list_mutex); 191 list_for_each_entry(entry, &dxgglobal->host_event_list_head, 192 host_event_list_entry) { 193 if (entry->event_id == event_id) { 194 list_del(&entry->host_event_list_entry); 195 entry->host_event_list_entry.next = NULL; 196 event = entry; 197 break; 198 } 199 } 200 spin_unlock_irq(&dxgglobal->host_event_list_mutex); 201 return event; 202 } 203 204 u64 dxgglobal_new_host_event_id(void) 205 { 206 return atomic64_inc_return(&dxgglobal->host_event_id); 207 } 208 209 void dxgglobal_acquire_process_adapter_lock(void) 210 { 211 mutex_lock(&dxgglobal->process_adapter_mutex); 212 } 213 214 void dxgglobal_release_process_adapter_lock(void) 215 { 216 mutex_unlock(&dxgglobal->process_adapter_mutex); 217 } 218 220 struct winluid host_vgpu_luid) 221 { 222 struct dxgadapter *adapter; 223 int ret = 0; 224 225 adapter = vzalloc(sizeof(struct dxgadapter)); 226 if (adapter == NULL) { 227 ret = -ENOMEM; 228 goto cleanup; 229 } 230 231 adapter->adapter_state = DXGADAPTER_STATE_WAITING_VMBUS; 232 adapter->host_vgpu_luid = host_vgpu_luid; 233 kref_init(&adapter->adapter_kref); 234 init_rwsem(&adapter->core_lock); 235 236 INIT_LIST_HEAD(&adapter->adapter_process_list_head); 237 INIT_LIST_HEAD(&adapter->shared_resource_list_head); 238 INIT_LIST_HEAD(&adapter->adapter_shared_syncobj_list_head); 239 INIT_LIST_HEAD(&adapter->syncobj_list_head); 240 init_rwsem(&adapter->shared_resource_list_lock); 241 adapter->pci_dev = dev; 242 guid_to_luid(guid, &adapter->luid); 243 244 dxgglobal_acquire_adapter_list_lock(DXGLOCK_EXCL); 245 246 list_add_tail(&adapter->adapter_list_entry, 247 &dxgglobal->adapter_list_head); 248 dxgglobal->num_adapters++; 249 dxgglobal_release_adapter_list_lock(DXGLOCK_EXCL); 250 251 dev_dbg(dxgglobaldev, "new adapter added %p %x-%x\n", adapter, 252 adapter->luid.a, adapter->luid.b); 253 cleanup: 254 dev_dbg(dxgglobaldev, "%s end: %d", __func__, ret); 255 return ret; 256 } 257 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org