[kbuild-all] Re: [PATCH leds + devicetree v1 2/2] leds: trigger: netdev: allow parsing `trigger-sources` from device tree

Hi "Marek, Thank you for the patch! Yet something to improve: [auto build test ERROR on pavel-linux-leds/for-next] [also build test ERROR on robh/for-next linus/master v5.9-rc5 next-20200914] [cannot apply to linux/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Marek-Beh-n/Parse-DT-property-tr... base: git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git for-next config: i386-randconfig-a011-20200914 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): drivers/leds/trigger/ledtrig-netdev.c: In function 'netdev_trig_of_parse': 396 | struct of_phandle_args args; | ^~~~ 407 | count = of_count_phandle_with_args(np, "trigger-sources", | ^~~~~~~~~~~~~~~~~~~~~~~~~~ 421 | err = of_parse_phandle_with_args(np, "trigger-sources", | ^~~~~~~~~~~~~~~~~~~~~~~~~~ 430 | err = of_property_read_string(np, "function", &function); | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/leds/trigger/ledtrig-netdev.c:396:25: warning: unused variable 'args' [-Wunused-variable] 396 | struct of_phandle_args args; | ^~~~ cc1: some warnings being treated as errors # https://github.com/0day-ci/linux/commit/2055fc3b24bb72ea2569a866ccfb1ee84... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Marek-Beh-n/Parse-DT-property-trigger-sources-for-netdev-LED-trigger/20200915-074253 git checkout 2055fc3b24bb72ea2569a866ccfb1ee840e0d385 vim +396 drivers/leds/trigger/ledtrig-netdev.c 392 393 static bool netdev_trig_of_parse(struct led_classdev *led_cdev, 394 struct led_netdev_data *trigger_data) 395 { 397 struct net_device *netdev; 398 struct device_node *np; 399 const char *function; 400 unsigned long mode; 401 int count, err; 402 403 np = dev_of_node(led_cdev->dev); 404 if (!np) 405 return -EOPNOTSUPP; 406 408 "#trigger-source-cells"); 409 if (count == -ENOENT) { 410 return false; 411 } else if (count < 0) { 412 dev_warn(led_cdev->dev, 413 "Failed parsing trigger sources for %pOF!\n", np); 414 return false; 415 } 416 417 /* netdev trigger can have only one source */ 418 if (count != 1) 419 return false; 420 422 "#trigger-source-cells", 0, &args); 423 if (err) 424 return false; 425 426 netdev = of_find_net_device_by_node(args.np); 427 if (!netdev) 428 return false; 429 431 if (err && err != -ENOENT) { 432 dev_warn(led_cdev->dev, "Failed parsing function for %pOF!\n", 433 np); 434 return false; 435 } else if (err == -ENOENT) { 436 /* default function is link */ 437 function = LED_FUNCTION_LINK; 438 } 439 440 mode = 0; 441 if (!strcmp(function, LED_FUNCTION_LINK)) { 442 set_bit(NETDEV_LED_LINK, &mode); 443 } else if (!strcmp(function, LED_FUNCTION_ACTIVITY)) { 444 set_bit(NETDEV_LED_TX, &mode); 445 set_bit(NETDEV_LED_RX, &mode); 446 } else if (!strcmp(function, LED_FUNCTION_RX)) { 447 set_bit(NETDEV_LED_RX, &mode); 448 } else if (!strcmp(function, LED_FUNCTION_TX)) { 449 set_bit(NETDEV_LED_TX, &mode); 450 } else { 451 dev_dbg(led_cdev->dev, 452 "Unsupported netdev trigger function for %pOF!\n", np); 453 return false; 454 } 455 456 if (trigger_data) { 457 dev_hold(netdev); 458 trigger_data->net_dev = netdev; 459 memcpy(trigger_data->device_name, netdev->name, IFNAMSIZ); 460 trigger_data->mode = mode; 461 if (netif_carrier_ok(netdev)) 462 set_bit(NETDEV_LED_MODE_LINKUP, &trigger_data->mode); 463 } 464 465 return true; 466 } 467 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org