[kbuild-all] Re: [PATCH v3 12/14] tools/kernel.h: hide noinstr

Hi Sasha, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.8-rc2 next-20200622] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Sasha-Levin/Fix-up-liblockdep-fo... base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dd0d718152e4c65b173070d48ea9dfc06894c3e5 config: x86_64-rhel (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): In file included from objtool.h:13, from weak.c:10: 42 | bool changed, text, rodata, noinstr; | ^ elf.h:43:1: error: no semicolon at end of struct or union [-Werror] 43 | }; | ^ cc1: all warnings being treated as errors In file included from objtool.h:13, from orc_dump.c:8: 42 | bool changed, text, rodata, noinstr; | ^ elf.h:43:1: error: no semicolon at end of struct or union [-Werror] 43 | }; | ^ In file included from objtool.h:13, from builtin-orc.c:17: 42 | bool changed, text, rodata, noinstr; | ^ elf.h:43:1: error: no semicolon at end of struct or union [-Werror] 43 | }; | ^ In file included from objtool.h:13, from arch.h:11, from check.h:11, from orc_gen.c:9: 42 | bool changed, text, rodata, noinstr; | ^ elf.h:43:1: error: no semicolon at end of struct or union [-Werror] 43 | }; | ^ In file included from orc_gen.c:9: check.h:18:14: error: declaration does not declare anything [-Werror] 18 | bool noinstr; | ^ cc1: all warnings being treated as errors mv: cannot stat 'tools/objtool/.weak.o.tmp': No such file or directory make[4]: *** [tools/build/Makefile.build:97: tools/objtool/weak.o] Error 1 make[4]: *** Waiting for unfinished jobs.... In file included from objtool.h:13, from builtin-check.c:19: 42 | bool changed, text, rodata, noinstr; | ^ elf.h:43:1: error: no semicolon at end of struct or union [-Werror] 43 | }; | ^ In file included from objtool.h:13, from arch.h:11, from check.c:11: 42 | bool changed, text, rodata, noinstr; | ^ elf.h:43:1: error: no semicolon at end of struct or union [-Werror] 43 | }; | ^ In file included from special.h:10, from special.c:15: 42 | bool changed, text, rodata, noinstr; | ^ elf.h:43:1: error: no semicolon at end of struct or union [-Werror] 43 | }; | ^ In file included from check.c:12: check.h:18:14: error: declaration does not declare anything [-Werror] 18 | bool noinstr; | ^ cc1: all warnings being treated as errors mv: cannot stat 'tools/objtool/.builtin-orc.o.tmp': No such file or directory In file included from elf.c:20: 42 | bool changed, text, rodata, noinstr; | ^ elf.h:43:1: error: no semicolon at end of struct or union [-Werror] 43 | }; | ^ make[4]: *** [tools/build/Makefile.build:97: tools/objtool/builtin-orc.o] Error 1 cc1: all warnings being treated as errors mv: cannot stat 'tools/objtool/.builtin-check.o.tmp': No such file or directory make[4]: *** [tools/build/Makefile.build:97: tools/objtool/builtin-check.o] Error 1 mv: cannot stat 'tools/objtool/.orc_gen.o.tmp': No such file or directory cc1: all warnings being treated as errors make[4]: *** [tools/build/Makefile.build:97: tools/objtool/orc_gen.o] Error 1 cc1: all warnings being treated as errors mv: cannot stat 'tools/objtool/.orc_dump.o.tmp': No such file or directory mv: cannot stat 'tools/objtool/.special.o.tmp': No such file or directory make[4]: *** [tools/build/Makefile.build:97: tools/objtool/orc_dump.o] Error 1 make[4]: *** [tools/build/Makefile.build:97: tools/objtool/special.o] Error 1 cc1: all warnings being treated as errors check.c: In function 'init_insn_state': 254 | state->noinstr = sec->noinstr; | ^ check.c: In function 'decode_instructions': check.c:282:17: error: expected identifier before '=' token 282 | sec->noinstr = true; | ^ mv: cannot stat 'tools/objtool/.elf.o.tmp': No such file or directory make[4]: *** [tools/build/Makefile.build:97: tools/objtool/elf.o] Error 1 check.c: In function 'validate_call': check.c:2195:21: error: expected identifier before '&&' token 2195 | if (state->noinstr && state->instr <= 0 && | ^~ check.c: In function 'validate_return': check.c:2230:21: error: expected identifier before '&&' token 2230 | if (state->noinstr && state->instr > 0) { | ^~ check.c: In function 'validate_branch': 2334 | if (state.noinstr) | ^ In file included from arch/x86/../../objtool.h:13, from arch/x86/../../arch.h:11, from arch/x86/../../check.h:11, from arch/x86/decode.c:14: 42 | bool changed, text, rodata, noinstr; | ^ arch/x86/../../elf.h:43:1: error: no semicolon at end of struct or union [-Werror] 43 | }; | ^ In file included from arch/x86/decode.c:14: arch/x86/../../check.h:18:14: error: declaration does not declare anything [-Werror] 18 | bool noinstr; | ^ cc1: all warnings being treated as errors cc1: all warnings being treated as errors mv: cannot stat 'tools/objtool/.check.o.tmp': No such file or directory mv: cannot stat 'tools/objtool/arch/x86/.decode.o.tmp': No such file or directory make[4]: *** [tools/build/Makefile.build:96: tools/objtool/check.o] Error 1 make[5]: *** [tools/build/Makefile.build:97: tools/objtool/arch/x86/decode.o] Error 1 make[4]: *** [tools/build/Makefile.build:139: arch/x86] Error 2 make[3]: *** [Makefile:64: tools/objtool/objtool-in.o] Error 2 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [Makefile:68: objtool] Error 2 make[1]: *** [Makefile:1858: tools/objtool] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:185: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org