9:28 a.m.
Hi Florian,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on nf-next/master]
url:
https://github.com/0day-ci/linux/commits/Florian-Westphal/netfilter-bpf-b...
base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: openrisc-buildonly-randconfig-r004-20211014 (attached as .config)
compiler: or1k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/2d7f7c3f2aa0c1933f06cfb066511f4cd...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Florian-Westphal/netfilter-bpf-base-hook-program-generator/20211014-201309
git checkout 2d7f7c3f2aa0c1933f06cfb066511f4cdefd6ff7
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir
ARCH=openrisc SHELL=/bin/bash net/netfilter/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
net/netfilter/core.c: In function 'nf_hook_entries_grow':
> net/netfilter/core.c:195:20: error: 'struct
nf_hook_entries' has no member named 'hook_prog'
195 |
new->hook_prog = hook_bpf_prog;
| ^~
> net/netfilter/core.c:198:39: error: 'const struct
nf_hook_entries' has no member named 'hook_prog'
198 |
old_prog = old->hook_prog;
| ^~
net/netfilter/core.c: In function '__nf_hook_entries_try_shrink':
net/netfilter/core.c:321:42: error: 'struct nf_hook_entries' has no member
named 'hook_prog'
321 | old ? old->hook_prog : NULL,
hook_bpf_prog);
| ^~
vim +195 net/netfilter/core.c
123
124 static struct nf_hook_entries *
125 nf_hook_entries_grow(const struct nf_hook_entries *old,
126 const struct nf_hook_ops *reg)
127 {
128 unsigned int i, alloc_entries, nhooks, old_entries;
129 struct nf_hook_ops **orig_ops = NULL;
130 struct bpf_prog *hook_bpf_prog;
131 struct nf_hook_ops **new_ops;
132 struct nf_hook_entries *new;
133 bool inserted = false;
134
135 alloc_entries = 1;
136 old_entries = old ? old->num_hook_entries : 0;
137
138 if (old) {
139 orig_ops = nf_hook_entries_get_hook_ops(old);
140
141 for (i = 0; i < old_entries; i++) {
142 if (orig_ops[i] != &dummy_ops)
143 alloc_entries++;
144 }
145 }
146
147 if (alloc_entries > MAX_HOOK_COUNT)
148 return ERR_PTR(-E2BIG);
149
150 new = allocate_hook_entries_size(alloc_entries);
151 if (!new)
152 return ERR_PTR(-ENOMEM);
153
154 new_ops = nf_hook_entries_get_hook_ops(new);
155
156 i = 0;
157 nhooks = 0;
158 while (i < old_entries) {
159 if (orig_ops[i] == &dummy_ops) {
160 ++i;
161 continue;
162 }
163
164 if (inserted || reg->priority > orig_ops[i]->priority) {
165 new_ops[nhooks] = (void *)orig_ops[i];
166 new->hooks[nhooks] = old->hooks[i];
167 i++;
168 } else {
169 new_ops[nhooks] = (void *)reg;
170 new->hooks[nhooks].hook = reg->hook;
171 new->hooks[nhooks].priv = reg->priv;
172 inserted = true;
173 }
174 nhooks++;
175 }
176
177 if (!inserted) {
178 new_ops[nhooks] = (void *)reg;
179 new->hooks[nhooks].hook = reg->hook;
180 new->hooks[nhooks].priv = reg->priv;
181 }
182
183 hook_bpf_prog = nf_hook_bpf_create(new);
184
185 /* XXX: jit failure handling?
186 * We could refuse hook registration.
187 *
188 * For now, allocate_hook_entries_size() sets
189 * ->hook_prog to a small fallback program that
190 * calls nf_hook_slow().
191 */
192 if (hook_bpf_prog) {
193 struct bpf_prog *old_prog = NULL;
194
195 new->hook_prog = hook_bpf_prog;
196
197 if (old)
198 old_prog = old->hook_prog;
199
200 nf_hook_bpf_change_prog(BPF_DISPATCHER_PTR(nf_hook_base),
201 old_prog, hook_bpf_prog);
202 }
203
204 return new;
205 }
206
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org