5:25 a.m.
Hi Shay,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Shay-Agroskin/Use-build_skb-and-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
dc8cf7550a703b8b9c94beed621c6c2474347eff
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
#
https://github.com/0day-ci/linux/commit/d37d1c673e22e4e7c24eb8bbc4c5662a7...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Shay-Agroskin/Use-build_skb-and-reorganize-some-code-in-ENA/20210609-000712
git checkout d37d1c673e22e4e7c24eb8bbc4c5662a7812842c
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> drivers/net/ethernet/amazon/ena/ena_netdev.c:978:14: warning: no
previous prototype for 'ena_alloc_map_page' [-Wmissing-prototypes]
978
| struct page *ena_alloc_map_page(struct ena_ring *rx_ring, dma_addr_t *dma)
| ^~~~~~~~~~~~~~~~~~
vim +/ena_alloc_map_page +978 drivers/net/ethernet/amazon/ena/ena_netdev.c
977
978 struct page *ena_alloc_map_page(struct ena_ring *rx_ring,
dma_addr_t *dma)
979 {
980 struct page *page;
981
982 /* This would allocate the page on the same NUMA node the executing code
983 * is running on.
984 */
985 page = dev_alloc_page();
986 if (!page) {
987 ena_increase_stat(&rx_ring->rx_stats.page_alloc_fail, 1,
988 &rx_ring->syncp);
989 return ERR_PTR(-ENOSPC);
990 }
991
992 /* To enable NIC-side port-mirroring, AKA SPAN port,
993 * we make the buffer readable from the nic as well
994 */
995 *dma = dma_map_page(rx_ring->dev, page, 0, ENA_PAGE_SIZE,
996 DMA_BIDIRECTIONAL);
997 if (unlikely(dma_mapping_error(rx_ring->dev, *dma))) {
998 ena_increase_stat(&rx_ring->rx_stats.dma_mapping_err, 1,
999 &rx_ring->syncp);
1000 __free_page(page);
1001 return ERR_PTR(-EIO);
1002 }
1003
1004 return page;
1005 }
1006
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org