[kbuild-all] [media-next:master 180/181] drivers/staging/media/hantro/hantro_drv.c:175:2: error: expected identifier or '(' before 'return'

Hi Mauro, FYI, the error/warning still remains. tree: git://linuxtv.org/mchehab/media-next.git master head: c4fb2697f420b3c752230d8060801681bc486c04 commit: 9454974c75ddbe0ec82c1bb3f0b5d6f3ce65b8fd [180/181] media: hantro: use pm_runtime_resume_and_get() config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git remote add media-next git://linuxtv.org/mchehab/media-next.git git fetch --no-tags media-next master git checkout 9454974c75ddbe0ec82c1bb3f0b5d6f3ce65b8fd # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): drivers/staging/media/hantro/hantro_drv.c: In function 'device_run': drivers/staging/media/hantro/hantro_drv.c:165:3: error: label 'err_cancel_job' used but not defined 165 | goto err_cancel_job; | ^~~~ drivers/staging/media/hantro/hantro_drv.c:157:32: warning: variable 'dst' set but not used [-Wunused-but-set-variable] 157 | struct vb2_v4l2_buffer *src, *dst; | ^~~ drivers/staging/media/hantro/hantro_drv.c:157:26: warning: variable 'src' set but not used [-Wunused-but-set-variable] 157 | struct vb2_v4l2_buffer *src, *dst; | ^~~ drivers/staging/media/hantro/hantro_drv.c: At top level: drivers/staging/media/hantro/hantro_drv.c:168:2: warning: data definition has no type or storage class 168 | ret = clk_bulk_enable(ctx->dev->variant->num_clocks, ctx->dev->clocks); | ^~~ drivers/staging/media/hantro/hantro_drv.c:168:2: error: type defaults to 'int' in declaration of 'ret' [-Werror=implicit-int] drivers/staging/media/hantro/hantro_drv.c:168:24: error: 'ctx' undeclared here (not in a function) 168 | ret = clk_bulk_enable(ctx->dev->variant->num_clocks, ctx->dev->clocks); | ^~~ drivers/staging/media/hantro/hantro_drv.c:169:2: error: expected identifier or '(' before 'if' 169 | if (ret) | ^~ drivers/staging/media/hantro/hantro_drv.c:172:2: warning: data definition has no type or storage class 172 | v4l2_m2m_buf_copy_metadata(src, dst, true); | ^~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/media/hantro/hantro_drv.c:172:2: error: type defaults to 'int' in declaration of 'v4l2_m2m_buf_copy_metadata' [-Werror=implicit-int] drivers/staging/media/hantro/hantro_drv.c:172:2: warning: parameter names (without types) in function declaration drivers/staging/media/hantro/hantro_drv.c:172:2: error: conflicting types for 'v4l2_m2m_buf_copy_metadata' In file included from drivers/staging/media/hantro/hantro_drv.c:23: include/media/v4l2-mem2mem.h:830:6: note: previous declaration of 'v4l2_m2m_buf_copy_metadata' was here 830 | void v4l2_m2m_buf_copy_metadata(const struct vb2_v4l2_buffer *out_vb, | ^~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/media/hantro/hantro_drv.c:174:5: error: expected '=', ',', ';', 'asm' or '__attribute__' before '->' token 174 | ctx->codec_ops->run(ctx); | ^~ 175 | return; | ^~~~~~ drivers/staging/media/hantro/hantro_drv.c:177:15: error: expected '=', ',', ';', 'asm' or '__attribute__' before ':' token 177 | err_cancel_job: | ^ drivers/staging/media/hantro/hantro_drv.c:179:1: error: expected identifier or '(' before '}' token 179 | } | ^ cc1: some warnings being treated as errors vim +175 drivers/staging/media/hantro/hantro_drv.c 932a9317ac492d drivers/staging/media/hantro/hantro_drv.c Boris Brezillon 2019-07-25 153 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia 2018-12-05 154 static void device_run(void *priv) 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia 2018-12-05 155 { a29add8c9bb29d drivers/staging/media/hantro/hantro_drv.c Philipp Zabel 2019-06-12 156 struct hantro_ctx *ctx = priv; 6c2eb77bf5667c drivers/staging/media/hantro/hantro_drv.c Boris Brezillon 2019-08-16 157 struct vb2_v4l2_buffer *src, *dst; 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia 2018-12-05 158 int ret; 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia 2018-12-05 159 6c2eb77bf5667c drivers/staging/media/hantro/hantro_drv.c Boris Brezillon 2019-08-16 160 src = hantro_get_src_buf(ctx); 6c2eb77bf5667c drivers/staging/media/hantro/hantro_drv.c Boris Brezillon 2019-08-16 161 dst = hantro_get_dst_buf(ctx); 6c2eb77bf5667c drivers/staging/media/hantro/hantro_drv.c Boris Brezillon 2019-08-16 162 9454974c75ddbe drivers/staging/media/hantro/hantro_drv.c Mauro Carvalho Chehab 2021-04-26 163 ret = pm_runtime_resume_and_get(ctx->dev->dev); 9454974c75ddbe drivers/staging/media/hantro/hantro_drv.c Mauro Carvalho Chehab 2021-04-26 164 if (ret < 0) 892bb6ecead9b8 drivers/staging/media/hantro/hantro_drv.c Mauro Carvalho Chehab 2021-04-28 165 goto err_cancel_job; 892bb6ecead9b8 drivers/staging/media/hantro/hantro_drv.c Mauro Carvalho Chehab 2021-04-28 166 } 892bb6ecead9b8 drivers/staging/media/hantro/hantro_drv.c Mauro Carvalho Chehab 2021-04-28 167 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia 2018-12-05 168 ret = clk_bulk_enable(ctx->dev->variant->num_clocks, ctx->dev->clocks); 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia 2018-12-05 169 if (ret) 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia 2018-12-05 170 goto err_cancel_job; 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia 2018-12-05 171 6c2eb77bf5667c drivers/staging/media/hantro/hantro_drv.c Boris Brezillon 2019-08-16 172 v4l2_m2m_buf_copy_metadata(src, dst, true); 6c2eb77bf5667c drivers/staging/media/hantro/hantro_drv.c Boris Brezillon 2019-08-16 173 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia 2018-12-05 174 ctx->codec_ops->run(ctx); 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia 2018-12-05 @175 return; 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia 2018-12-05 176 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia 2018-12-05 177 err_cancel_job: 892bb6ecead9b8 drivers/staging/media/hantro/hantro_drv.c Mauro Carvalho Chehab 2021-04-28 178 hantro_job_finish_no_pm(ctx->dev, ctx, VB2_BUF_STATE_ERROR); 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia 2018-12-05 179 } 775fec69008d30 drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c Ezequiel Garcia 2018-12-05 180 :::::: The code at line 175 was first introduced by commit :::::: 775fec69008d30ed5e4ce9fa7701c5591e424c87 media: add Rockchip VPU JPEG encoder driver :::::: TO: Ezequiel Garcia <ezequiel(a)collabora.com&gt; :::::: CC: Mauro Carvalho Chehab <mchehab+samsung(a)kernel.org&gt; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org