[kbuild-all] Re: [PATCH v5] sched/fair: Correctly insert cfs_rq's to list on unthrottle

Hi Odin, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/sched/core] [also build test ERROR on tip/master linux/master linus/master v5.13-rc6 next-20210615] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Odin-Ugedal/sched-fair-Correctly... base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 0159bb020ca9a43b17aa9149f1199643c1d49426 config: m68k-randconfig-r021-20210615 (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/670fb8556a2d3594c67bf4ab2983ba4f9... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Odin-Ugedal/sched-fair-Correctly-insert-cfs_rq-s-to-list-on-unthrottle/20210616-151742 git checkout 670fb8556a2d3594c67bf4ab2983ba4f91f5686b # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): kernel/sched/fair.c: In function 'tg_unthrottle_up': 4724 | if (!cfs_rq_is_decayed(cfs_rq) || cfs_rq->nr_running) | ^~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/cfs_rq_is_decayed +4724 kernel/sched/fair.c 4712 4713 static int tg_unthrottle_up(struct task_group *tg, void *data) 4714 { 4715 struct rq *rq = data; 4716 struct cfs_rq *cfs_rq = tg->cfs_rq[cpu_of(rq)]; 4717 4718 cfs_rq->throttle_count--; 4719 if (!cfs_rq->throttle_count) { 4720 cfs_rq->throttled_clock_task_time += rq_clock_task(rq) - 4721 cfs_rq->throttled_clock_task; 4722 4723 /* Add cfs_rq with load or one or more already running entities to the list */ 4725 list_add_leaf_cfs_rq(cfs_rq); 4726 } 4727 4728 return 0; 4729 } 4730 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org