2:31 p.m.
Hi Jacopo,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v5.7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Jacopo-Mondi/v4l2-subdev-Introdu...
base: git://linuxtv.org/media_tree.git master
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
cppcheck warnings: (new ones prefixed by >>)
> drivers/media/i2c/ov6650.c:941:34: warning: Clarify calculation
precedence for '&' and '?'. [clarifyCalculation]
|
(comj & COMJ_VSYNC_HIGH ? V4L2_MBUS_VSYNC_ACTIVE_HIGH
^
drivers/media/i2c/ov6650.c:943:34: warning: Clarify calculation precedence for
'&' and '?'. [clarifyCalculation]
| (comf & COMF_HREF_LOW ? V4L2_MBUS_HSYNC_ACTIVE_LOW
^
drivers/media/i2c/ov6650.c:945:34: warning: Clarify calculation precedence for
'&' and '?'. [clarifyCalculation]
| (comj & COMJ_PCLK_RISING ? V4L2_MBUS_PCLK_SAMPLE_RISING
^
--
In file included from fs/nfsd/trace.c:
> fs/nfsd/trace.h:175:0: warning: There is an unknown macro here
somewhere. Configuration is required. If DECLARE_EVENT_CLASS is a macro then please
configure it. [unknownMacro]
^
> fs/nfsd/nfsctl.c:1277:7: warning: Opposite inner 'if'
condition leads to a dead code block. [oppositeInnerCondition]
if
(!files->name)
^
fs/nfsd/nfsctl.c:1276:19: note: outer condition: files->name
for (i = 0; files->name && files->name[0]; i++, files++) {
^
fs/nfsd/nfsctl.c:1277:7: note: opposite inner condition: !files->name
if (!files->name)
^
> fs/nfsd/nfsctl.c:524:5: warning: Variable 'rv' is
reassigned a value before the old one has been used. [redundantAssignment]
rv =
nfsd_get_nrthreads(npools, nthreads, net);
^
fs/nfsd/nfsctl.c:504:5: note: Variable 'rv' is reassigned a value before the
old one has been used.
rv = -ENOMEM;
^
fs/nfsd/nfsctl.c:524:5: note: Variable 'rv' is reassigned a value before the
old one has been used.
rv = nfsd_get_nrthreads(npools, nthreads, net);
^
> fs/nfsd/nfsctl.c:1201:6: warning: Variable 'ret' is
reassigned a value before the old one has been used. [redundantAssignment]
ret =
__nfsd_mkdir(d_inode(parent), dentry, S_IFDIR | 0600, ncl);
^
fs/nfsd/nfsctl.c:1195:0: note: Variable 'ret' is reassigned a value before the
old one has been used.
int ret = -ENOMEM;
^
fs/nfsd/nfsctl.c:1201:6: note: Variable 'ret' is reassigned a value before the
old one has been used.
ret = __nfsd_mkdir(d_inode(parent), dentry, S_IFDIR | 0600, ncl);
^
vim +941 drivers/media/i2c/ov6650.c
922
923 /* Request bus settings on camera side */
924 static int ov6650_get_mbus_config(struct v4l2_subdev *sd,
925 unsigned int pad,
926 struct v4l2_mbus_config *cfg)
927 {
928 struct i2c_client *client = v4l2_get_subdevdata(sd);
929 u8 comj, comf;
930 int ret;
931
932 ret = ov6650_reg_read(client, REG_COMJ, &comj);
933 if (ret)
934 return ret;
935
936 ret = ov6650_reg_read(client, REG_COMF, &comf);
937 if (ret)
938 return ret;
939
940 cfg->flags = V4L2_MBUS_MASTER
941 | (comj & COMJ_VSYNC_HIGH ?
V4L2_MBUS_VSYNC_ACTIVE_HIGH
942 : V4L2_MBUS_VSYNC_ACTIVE_LOW)
943 | (comf & COMF_HREF_LOW ? V4L2_MBUS_HSYNC_ACTIVE_LOW
944 : V4L2_MBUS_HSYNC_ACTIVE_HIGH)
945 | (comj & COMJ_PCLK_RISING ? V4L2_MBUS_PCLK_SAMPLE_RISING
946 : V4L2_MBUS_PCLK_SAMPLE_FALLING);
947 cfg->type = V4L2_MBUS_PARALLEL;
948
949 return 0;
950 }
951
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org