9:54 p.m.
Hi Zhiyong,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on pinctrl/devel]
[also build test WARNING on robh/for-next v5.13-rc7 next-20210622]
[cannot apply to mediatek/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Zhiyong-Tao/Mediatek-pinctrl-pat...
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: x86_64-randconfig-a003-20210622 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project
b259740801d3515810ecc15bf0c24b0d476a1608)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
#
https://github.com/0day-ci/linux/commit/24650abc31b292c3cfc8c82e6281e4b37...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Zhiyong-Tao/Mediatek-pinctrl-patch-on-mt8195/20210623-173915
git checkout 24650abc31b292c3cfc8c82e6281e4b37dc0bb4a
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:667:5: warning:
no previous prototype for function 'mtk_pinconf_bias_set_rsel'
[-Wmissing-prototypes]
int mtk_pinconf_bias_set_rsel(struct mtk_pinctrl *hw,
^
drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:667:1: note: declare 'static'
if the function is not intended to be used outside of this translation unit
int mtk_pinconf_bias_set_rsel(struct mtk_pinctrl *hw,
^
static
1 warning generated.
vim +/mtk_pinconf_bias_set_rsel +667 drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
666
667 int mtk_pinconf_bias_set_rsel(struct mtk_pinctrl *hw,
668 const struct mtk_pin_desc *desc,
669 u32 pullup, u32 arg)
670 {
671 int err;
672
673 if (arg < MTK_PULL_SET_RSEL_000 || arg > MTK_PULL_SET_RSEL_111) {
674 err = -EINVAL;
675 goto out;
676 }
677
678 arg -= MTK_PULL_SET_RSEL_000;
679 err = mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_RSEL, arg);
680 if (err)
681 goto out;
682
683 err = mtk_pinconf_bias_set_pu_pd(hw, desc, pullup, MTK_ENABLE);
684
685 out:
686 return err;
687 }
688 EXPORT_SYMBOL_GPL(mtk_pinconf_bias_set_rsel);
689
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org