12:19 a.m.
Hi Gang,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tip/master]
[also build test ERROR on tip/sched/core linux/master linus/master v5.16-rc2]
[cannot apply to next-20211124]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Gang-Li/sched-numa-add-per-proce...
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
7284bd9822f33a3be80ac6d92b4540d6dcfb5219
config: um-i386_defconfig
(https://download.01.org/0day-ci/archive/20211124/202111242126.gbvMm0yg-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
#
https://github.com/0day-ci/linux/commit/0ba51a6062697d2109e0cf86470e354ed...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Gang-Li/sched-numa-add-per-process-numa_balancing/20211124-162550
git checkout 0ba51a6062697d2109e0cf86470e354ed005fab8
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
kernel/sched/fair.c:631:5: warning: no previous prototype for
'sched_update_scaling' [-Wmissing-prototypes]
631 | int sched_update_scaling(void)
| ^~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c: In function 'task_tick_fair':
> kernel/sched/fair.c:11172:27: error: 'struct mm_struct'
has no member named 'numab_enabled'
11172 | if (curr->mm &&
(curr->mm->numab_enabled == NUMAB_ENABLED \
| ^~
> kernel/sched/fair.c:11172:46: error: 'NUMAB_ENABLED'
undeclared (first use in this function); did you mean 'UMH_ENABLED'?
11172 | if (curr->mm && (curr->mm->numab_enabled == NUMAB_ENABLED \
| ^~~~~~~~~~~~~
| UMH_ENABLED
kernel/sched/fair.c:11172:46: note: each undeclared identifier is reported only once
for each function it appears in
kernel/sched/fair.c:11174:17: error: 'struct mm_struct' has no member named
'numab_enabled'
11174 | && curr->mm->numab_enabled == NUMAB_DEFAULT)))
| ^~
> kernel/sched/fair.c:11174:36: error: 'NUMAB_DEFAULT'
undeclared (first use in this function); did you mean 'LMI_DEFAULT'?
11174 | && curr->mm->numab_enabled == NUMAB_DEFAULT)))
| ^~~~~~~~~~~~~
| LMI_DEFAULT
vim +11172 kernel/sched/fair.c
11153
11154 /*
11155 * scheduler tick hitting a task of our scheduling class.
11156 *
11157 * NOTE: This function can be called remotely by the tick offload that
11158 * goes along full dynticks. Therefore no local assumption can be made
11159 * and everything must be accessed through the @rq and @curr passed in
11160 * parameters.
11161 */
11162 static void task_tick_fair(struct rq *rq, struct task_struct *curr, int queued)
11163 {
11164 struct cfs_rq *cfs_rq;
11165 struct sched_entity *se = &curr->se;
11166
11167 for_each_sched_entity(se) {
11168 cfs_rq = cfs_rq_of(se);
11169 entity_tick(cfs_rq, se, queued);
11170 }
11171
11172 if (curr->mm && (curr->mm->numab_enabled == NUMAB_ENABLED \
11173 || (static_branch_unlikely(&sched_numa_balancing) \
11174 && curr->mm->numab_enabled == NUMAB_DEFAULT)))
11175 task_tick_numa(rq, curr);
11176
11177 update_misfit_status(curr, rq);
11178 update_overutilized_status(task_rq(curr));
11179
11180 task_tick_core(rq, curr);
11181 }
11182
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org