[kbuild-all] [intel-linux-intel-lts:5.4/yocto 415/1142] drivers/misc/xlink-usb/local_host/mxlk_interface.c:110:20: warning: passing argument 1 of 'vpu_close1' makes integer from pointer without a cast

tree: https://github.com/intel/linux-intel-lts.git 5.4/yocto head: eeb611e5394c56d45c5cc8f7dc484c9f19e93143 commit: 5e9e6d86fe729cf81e8a0df5c53d326b9f2ec791 [415/1142] xlink-usb: XLink USB Remote and Local Host driver config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel/linux-intel-lts/commit/5e9e6d86fe729cf81e8a0df5c... git remote add intel-linux-intel-lts https://github.com/intel/linux-intel-lts.git git fetch --no-tags intel-linux-intel-lts 5.4/yocto git checkout 5e9e6d86fe729cf81e8a0df5c53d326b9f2ec791 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): In file included from arch/m68k/include/asm/io_mm.h:25, from arch/m68k/include/asm/io.h:8, from include/linux/scatterlist.h:9, from include/linux/usb/gadget.h:24, from include/linux/usb/composite.h:41, from drivers/misc/xlink-usb/local_host/u_xlink.h:12, from drivers/misc/xlink-usb/local_host/mxlk_interface.c:13: arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsb': arch/m68k/include/asm/raw_io.h:83:7: warning: variable '__w' set but not used [-Wunused-but-set-variable] 83 | ({u8 __w, __v = (b); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:430:3: note: in expansion of macro 'rom_out_8' 430 | rom_out_8(port, *buf++); | ^~~~~~~~~ arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw': arch/m68k/include/asm/raw_io.h:86:8: warning: variable '__w' set but not used [-Wunused-but-set-variable] 86 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:448:3: note: in expansion of macro 'rom_out_be16' 448 | rom_out_be16(port, *buf++); | ^~~~~~~~~~~~ arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw_swapw': arch/m68k/include/asm/raw_io.h:90:8: warning: variable '__w' set but not used [-Wunused-but-set-variable] 90 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:466:3: note: in expansion of macro 'rom_out_le16' 466 | rom_out_le16(port, *buf++); | ^~~~~~~~~~~~ In file included from include/linux/kernel.h:11, from include/linux/list.h:9, from include/linux/module.h:9, from drivers/misc/xlink-usb/local_host/mxlk_interface.c:11: include/linux/scatterlist.h: In function 'sg_set_buf': arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra] 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ drivers/misc/xlink-usb/local_host/mxlk_interface.c: In function 'xlink_usb_write': 110 | return vpu_close1(data); | ^~~~ | | | void * In file included from drivers/misc/xlink-usb/local_host/mxlk_interface.c:13: drivers/misc/xlink-usb/local_host/u_xlink.h:75:20: note: expected 'int' but argument is of type 'void *' 75 | int vpu_close1(int size); | ~~~~^~~~ -- In file included from arch/m68k/include/asm/io_mm.h:25, from arch/m68k/include/asm/io.h:8, from include/linux/scatterlist.h:9, from include/linux/kfifo.h:42, from drivers/misc/xlink-usb/local_host/u_xlink.c:32: arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsb': arch/m68k/include/asm/raw_io.h:83:7: warning: variable '__w' set but not used [-Wunused-but-set-variable] 83 | ({u8 __w, __v = (b); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:430:3: note: in expansion of macro 'rom_out_8' 430 | rom_out_8(port, *buf++); | ^~~~~~~~~ arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw': arch/m68k/include/asm/raw_io.h:86:8: warning: variable '__w' set but not used [-Wunused-but-set-variable] 86 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:448:3: note: in expansion of macro 'rom_out_be16' 448 | rom_out_be16(port, *buf++); | ^~~~~~~~~~~~ arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw_swapw': arch/m68k/include/asm/raw_io.h:90:8: warning: variable '__w' set but not used [-Wunused-but-set-variable] 90 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:466:3: note: in expansion of macro 'rom_out_le16' 466 | rom_out_le16(port, *buf++); | ^~~~~~~~~~~~ In file included from include/linux/kernel.h:11, from drivers/misc/xlink-usb/local_host/u_xlink.c:20: include/linux/scatterlist.h: In function 'sg_set_buf': arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra] 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ drivers/misc/xlink-usb/local_host/u_xlink.c: In function 'vpu_rx_push': 297 | bool disconnect = false; | ^~~~~~~~~~ In file included from drivers/misc/xlink-usb/local_host/u_xlink.c:32: drivers/misc/xlink-usb/local_host/u_xlink.c: In function 'vpu_write1': include/linux/kfifo.h:181:47: warning: statement with no effect [-Wunused-value] 181 | #define kfifo_initialized(fifo) ((fifo)->kfifo.mask) | ~~~~~~~~~~~~~~^~~~~~ drivers/misc/xlink-usb/local_host/u_xlink.c:791:2: note: in expansion of macro 'kfifo_initialized' 791 | kfifo_initialized(&port->port_write_buf); | ^~~~~~~~~~~~~~~~~ 820 | unsigned long flags; | ^~~~~~~~ drivers/misc/xlink-usb/local_host/u_xlink.c:823:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 823 | int room = 0; | ^~~ drivers/misc/xlink-usb/local_host/u_xlink.c:836:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 836 | struct list_head *pool = &port->write_pool; | ^~~~~~ drivers/misc/xlink-usb/local_host/u_xlink.c:840:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 840 | bool do_tty_wake = false; | ^~~~ 840 | bool do_tty_wake = false; | ^~~~~~~~~~~ 823 | int room = 0; | ^~~~ drivers/misc/xlink-usb/local_host/u_xlink.c: In function 'vpu_read': drivers/misc/xlink-usb/local_host/u_xlink.c:970:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 970 | struct list_head *pool = &port->read_pool; | ^~~~~~ drivers/misc/xlink-usb/local_host/u_xlink.c:976:3: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 976 | size_t bcopy; | ^~~~~~ drivers/misc/xlink-usb/local_host/u_xlink.c: In function 'vpu_read_swid': drivers/misc/xlink-usb/local_host/u_xlink.c:992:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 992 | struct list_head *pool = &port->read_pool; | ^~~~~~ -- In file included from arch/m68k/include/asm/io_mm.h:25, from arch/m68k/include/asm/io.h:8, from include/linux/scatterlist.h:9, from include/linux/usb/gadget.h:24, from include/linux/usb/composite.h:41, from drivers/misc/xlink-usb/local_host/u_xlink.h:12, from drivers/misc/xlink-usb/local_host/f_vpuusb.c:25: arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsb': arch/m68k/include/asm/raw_io.h:83:7: warning: variable '__w' set but not used [-Wunused-but-set-variable] 83 | ({u8 __w, __v = (b); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:430:3: note: in expansion of macro 'rom_out_8' 430 | rom_out_8(port, *buf++); | ^~~~~~~~~ arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw': arch/m68k/include/asm/raw_io.h:86:8: warning: variable '__w' set but not used [-Wunused-but-set-variable] 86 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:448:3: note: in expansion of macro 'rom_out_be16' 448 | rom_out_be16(port, *buf++); | ^~~~~~~~~~~~ arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw_swapw': arch/m68k/include/asm/raw_io.h:90:8: warning: variable '__w' set but not used [-Wunused-but-set-variable] 90 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); \ | ^~~ arch/m68k/include/asm/raw_io.h:466:3: note: in expansion of macro 'rom_out_le16' 466 | rom_out_le16(port, *buf++); | ^~~~~~~~~~~~ In file included from include/asm-generic/bug.h:5, from arch/m68k/include/asm/bug.h:32, from include/linux/bug.h:5, from include/linux/mmdebug.h:5, from include/linux/gfp.h:5, from include/linux/slab.h:15, from drivers/misc/xlink-usb/local_host/f_vpuusb.c:20: include/linux/scatterlist.h: In function 'sg_set_buf': arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra] 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ drivers/misc/xlink-usb/local_host/f_vpuusb.c: At top level: 349 | int mxlk_trigger_reset(void *arg) | ^~~~~~~~~~~~~~~~~~ 377 | int vpu_setup(struct usb_function *f, const struct usb_ctrlrequest *ctrl) | ^~~~~~~~~ 525 | int vpu_cdc_notify(struct f_acm *acm, u8 type, u16 value, | ^~~~~~~~~~~~~~ 562 | int vpu_notify_serial_state(struct f_acm *acm) | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/misc/xlink-usb/local_host/f_vpuusb.c: In function 'keembay_usb_irq_handler': 358 | int *data = vpu_read_swid(data); | ^~~~~~~~~~~~~~~~~~~ -- drivers/misc/xlink-usb/remote_host/vpu-cdc-acm.c: In function 'usb_get_device_status_by_id': 615 | u32 num = 0; | ^~~ drivers/misc/xlink-usb/remote_host/vpu-cdc-acm.c: At top level: 631 | int usb_interrupt(struct usb_device *usb_dev, unsigned int pipe, | ^~~~~~~~~~~~~ drivers/misc/xlink-usb/remote_host/vpu-cdc-acm.c: In function 'usb_interrupt': 635 | struct usb_host_endpoint *ep; | ^~ 634 | struct urb *urb; | ^~~ drivers/misc/xlink-usb/remote_host/vpu-cdc-acm.c: In function 'usb_device_reset': drivers/misc/xlink-usb/remote_host/vpu-cdc-acm.c:662:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 662 | struct usb_interface *data_interface = acm->data; | ^~~~~~ drivers/misc/xlink-usb/remote_host/vpu-cdc-acm.c:658:28: warning: variable 'ep' set but not used [-Wunused-but-set-variable] 658 | struct usb_host_endpoint *ep; | ^~ 653 | int ret; | ^~~ drivers/misc/xlink-usb/remote_host/vpu-cdc-acm.c: In function 'vpu_write_host': drivers/misc/xlink-usb/remote_host/vpu-cdc-acm.c:749:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 749 | int val = ACM_CTRL_DTR | ACM_CTRL_RTS; | ^~~ drivers/misc/xlink-usb/remote_host/vpu-cdc-acm.c:754:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 754 | int count = len; | ^~~ drivers/misc/xlink-usb/remote_host/vpu-cdc-acm.c: In function 'vpu_write_reset_host': drivers/misc/xlink-usb/remote_host/vpu-cdc-acm.c:848:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 848 | const char *buf = 0; | ^~~~~ drivers/misc/xlink-usb/remote_host/vpu-cdc-acm.c: At top level: 884 | void vpu_write_swid(struct acm *acm, int *buf, int len) | ^~~~~~~~~~~~~~ 1013 | void vpu_close_swid(struct acm *acm, int len) | ^~~~~~~~~~~~~~ drivers/misc/xlink-usb/remote_host/vpu-cdc-acm.c: In function 'vpu_read_host': drivers/misc/xlink-usb/remote_host/vpu-cdc-acm.c:1066:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 1066 | struct urb *urb; | ^~~~~~ drivers/misc/xlink-usb/remote_host/vpu-cdc-acm.c:1096:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 1096 | int val = ACM_CTRL_DTR | ACM_CTRL_RTS; | ^~~ drivers/misc/xlink-usb/remote_host/vpu-cdc-acm.c: In function 'vpu_acm_probe': drivers/misc/xlink-usb/remote_host/vpu-cdc-acm.c:1365:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 1365 | struct usb_device *udev = interface_to_usbdev(intf); | ^~~~~~ 1532 | vpu_write_swid(acm, devnum, size); | ^~~~~~ | | | int drivers/misc/xlink-usb/remote_host/vpu-cdc-acm.c:884:43: note: expected 'int *' but argument is of type 'int' 884 | void vpu_write_swid(struct acm *acm, int *buf, int len) | ~~~~~^~~ drivers/misc/xlink-usb/remote_host/vpu-cdc-acm.c:1534:22: warning: passing argument 2 of 'vpu_write_swid' makes pointer from integer without a cast [-Wint-conversion] 1534 | vpu_write_swid(acm, busnum, size); | ^~~~~~ | | | int drivers/misc/xlink-usb/remote_host/vpu-cdc-acm.c:884:43: note: expected 'int *' but argument is of type 'int' 884 | void vpu_write_swid(struct acm *acm, int *buf, int len) | ~~~~~^~~ drivers/misc/xlink-usb/remote_host/vpu-cdc-acm.c: In function 'vpu_acm_init': 1727 | int retval; | ^~~~~~ At top level: drivers/misc/xlink-usb/remote_host/vpu-cdc-acm.c:595:20: warning: 'usb_get_device_by_name' defined but not used [-Wunused-function] 595 | static struct acm *usb_get_device_by_name(const char *name) | ^~~~~~~~~~~~~~~~~~~~~~ -- drivers/misc/xlink-usb/remote_host/mxlk_interface_host.c: In function 'xlink_usb_write': 40 | return vpu_close_host(sw_device_id, size); | ^~~~ | | | size_t * const {aka unsigned int * const} In file included from drivers/misc/xlink-usb/remote_host/mxlk_interface_host.c:22: drivers/misc/xlink-usb/remote_host/vpu-cdc-acm.h:59:32: note: expected 'int' but argument is of type 'size_t * const' {aka 'unsigned int * const'} 59 | int vpu_close_host(u32 id, int len); | ~~~~^~~ Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for NEED_MULTIPLE_NODES Depends on DISCONTIGMEM || NUMA Selected by - SINGLE_MEMORY_CHUNK && MMU vim +/vpu_close1 +110 drivers/misc/xlink-usb/local_host/mxlk_interface.c 97 98 int xlink_usb_write(uint32_t sw_device_id, void *data, size_t *const size, 99 uint32_t timeout) 100 { 101 int mxlk; 102 int rc; 103 104 mxlk = usb_get_by_id(sw_device_id); 105 if (!mxlk) 106 return -ENODEV; 107 rc = vpu_write1(data, size, timeout); 108 if (rc < 0) 109 return rc; 111 } 112 EXPORT_SYMBOL(xlink_usb_write); 113 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org