8:14 p.m.
Hi Chunfeng,
I love your patch! Perhaps something to improve:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on robh/for-next linus/master v5.12-rc4 next-20210323]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Chunfeng-Yun/dt-bindings-usb-mtk...
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: arm64-randconfig-r031-20210322 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project
14696baaf4c43fe53f738bc292bbe169eed93d5d)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
#
https://github.com/0day-ci/linux/commit/6c0e65b02daf53e661d1804f081cb75fd...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Chunfeng-Yun/dt-bindings-usb-mtk-xhci-support-property-usb2-lpm-disable/20210322-111651
git checkout 6c0e65b02daf53e661d1804f081cb75fda28b916
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> drivers/usb/mtu3/mtu3_host.c:60:35: warning: implicit conversion
from 'unsigned long' to 'u32' (aka 'unsigned int') changes value
from 18446744073441120320 to 4026536000 [-Wconstant-conversion]
msk = WC0_IS_EN | WC0_IS_C(0xf) | WC0_IS_P;
~ ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
drivers/usb/mtu3/mtu3_host.c:61:29: warning: implicit conversion from 'unsigned
long' to 'u32' (aka 'unsigned int') changes value from
18446744071562068032 to 2147483712 [-Wconstant-conversion]
val = enable ? (WC0_IS_EN | WC0_IS_C(0x8)) : 0;
~ ~~~~~~~~~~^~~~~~~~~~~~~~~
2 warnings generated.
vim +60 drivers/usb/mtu3/mtu3_host.c
43
44 /*
45 * ip-sleep wakeup mode:
46 * all clocks can be turn off, but power domain should be kept on
47 */
48 static void ssusb_wakeup_ip_sleep_set(struct ssusb_mtk *ssusb, bool enable)
49 {
50 u32 reg, msk, val;
51
52 switch (ssusb->uwk_vers) {
53 case SSUSB_UWK_V1:
54 reg = ssusb->uwk_reg_base + PERI_WK_CTRL1;
55 msk = WC1_IS_EN | WC1_IS_C(0xf) | WC1_IS_P;
56 val = enable ? (WC1_IS_EN | WC1_IS_C(0x8)) : 0;
57 break;
58 case SSUSB_UWK_V11:
59 reg = ssusb->uwk_reg_base + PERI_WK_CTRL0;
60 msk = WC0_IS_EN | WC0_IS_C(0xf) | WC0_IS_P;
61 val =
enable ? (WC0_IS_EN | WC0_IS_C(0x8)) : 0;
62 break;
63 case SSUSB_UWK_V2:
64 reg = ssusb->uwk_reg_base + PERI_SSUSB_SPM_CTRL;
65 msk = SSC_IP_SLEEP_EN | SSC_SPM_INT_EN;
66 val = enable ? msk : 0;
67 break;
68 default:
69 return;
70 }
71 regmap_update_bits(ssusb->uwk, reg, msk, val);
72 }
73
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org