[kbuild-all] Re: [PATCH 1/2 v7] rseq/membarrier: add MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ

Hi Peter, Thank you for the patch! Yet something to improve: [auto build test ERROR on kselftest/next] [also build test ERROR on tip/sched/core linux/master linus/master v5.9-rc5 next-20200915] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Peter-Oskolkov/rseq-membarrier-a... base: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next config: m68k-randconfig-r015-20200916 (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): In file included from include/linux/kernel.h:11, from include/linux/list.h:9, from include/linux/module.h:12, from drivers/mmc/host/wbsd.c:20: include/linux/scatterlist.h: In function 'sg_set_buf': arch/m68k/include/asm/page_no.h:33:50: warning: ordered comparison of pointer with null pointer [-Wextra] 33 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \ | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ drivers/mmc/host/wbsd.c: In function 'wbsd_request_end': drivers/mmc/host/wbsd.c:212:14: error: implicit declaration of function 'claim_dma_lock' [-Werror=implicit-function-declaration] 212 | dmaflags = claim_dma_lock(); | ^~~~~~~~~~~~~~ 213 | disable_dma(host->dma); | ^~~~~~~~~~~ | disable_irq 214 | clear_dma_ff(host->dma); | ^~~~~~~~~~~~ drivers/mmc/host/wbsd.c:215:3: error: implicit declaration of function 'release_dma_lock'; did you mean 'release_task'? [-Werror=implicit-function-declaration] 215 | release_dma_lock(dmaflags); | ^~~~~~~~~~~~~~~~ | release_task drivers/mmc/host/wbsd.c: In function 'wbsd_prepare_data': 618 | set_dma_mode(host->dma, DMA_MODE_READ & ~0x40); | ^~~~~~~~~~~~ | set_dev_node 618 | set_dma_mode(host->dma, DMA_MODE_READ & ~0x40); | ^~~~~~~~~~~~~ | FMODE_READ drivers/mmc/host/wbsd.c:618:28: note: each undeclared identifier is reported only once for each function it appears in 620 | set_dma_mode(host->dma, DMA_MODE_WRITE & ~0x40); | ^~~~~~~~~~~~~~ | FMODE_WRITE 621 | set_dma_addr(host->dma, host->dma_addr); | ^~~~~~~~~~~~ | print_vma_addr 622 | set_dma_count(host->dma, size); | ^~~~~~~~~~~~~ | head_mapcount 624 | enable_dma(host->dma); | ^~~~~~~~~~ | enable_nmi drivers/mmc/host/wbsd.c: In function 'wbsd_finish_data': 702 | count = get_dma_residue(host->dma); | ^~~~~~~~~~~~~~~ | set_dma_reserve cc1: some warnings being treated as errors -- In file included from include/asm-generic/bug.h:5, from arch/m68k/include/asm/bug.h:32, from include/linux/bug.h:5, from include/linux/thread_info.h:12, from arch/m68k/include/asm/current.h:16, from include/linux/sched.h:12, from kernel/sched/sched.h:5, from kernel/sched/membarrier.c:7: include/linux/scatterlist.h: In function 'sg_set_buf': arch/m68k/include/asm/page_no.h:33:50: warning: ordered comparison of pointer with null pointer [-Wextra] 33 | #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \ | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ In file included from kernel/sched/sched.h:65, from kernel/sched/membarrier.c:7: kernel/sched/membarrier.c: At top level: 238 | asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) \ | ^~~ include/linux/syscalls.h:224:2: note: in expansion of macro '__SYSCALL_DEFINEx' 224 | __SYSCALL_DEFINEx(x, sname, __VA_ARGS__) | ^~~~~~~~~~~~~~~~~ include/linux/syscalls.h:215:36: note: in expansion of macro 'SYSCALL_DEFINEx' 215 | #define SYSCALL_DEFINE3(name, ...) SYSCALL_DEFINEx(3, _##name, __VA_ARGS__) | ^~~~~~~~~~~~~~~ kernel/sched/membarrier.c:401:1: note: in expansion of macro 'SYSCALL_DEFINE3' 401 | SYSCALL_DEFINE3(membarrier, int, cmd, unsigned int, flags, int, cpu_id) | ^~~~~~~~~~~~~~~ In file included from kernel/sched/sched.h:65, from kernel/sched/membarrier.c:7: include/linux/syscalls.h:977:17: note: previous declaration of 'sys_membarrier' was here 977 | asmlinkage long sys_membarrier(int cmd, int flags, int cpu_id); | ^~~~~~~~~~~~~~ # https://github.com/0day-ci/linux/commit/eb21b18c9bbbbb6f280319c4ead2be5c5... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Peter-Oskolkov/rseq-membarrier-add-MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ/20200916-025708 git checkout eb21b18c9bbbbb6f280319c4ead2be5c52dade77 vim +/sys_membarrier +238 include/linux/syscalls.h 1bd21c6c21e8489 Dominik Brodowski 2018-04-05 227 e145242ea0df6b7 Dominik Brodowski 2018-04-09 228 /* e145242ea0df6b7 Dominik Brodowski 2018-04-09 229 * The asmlinkage stub is aliased to a function named __se_sys_*() which e145242ea0df6b7 Dominik Brodowski 2018-04-09 230 * sign-extends 32-bit ints to longs whenever needed. The actual work is e145242ea0df6b7 Dominik Brodowski 2018-04-09 231 * done within __do_sys_*(). e145242ea0df6b7 Dominik Brodowski 2018-04-09 232 */ 1bd21c6c21e8489 Dominik Brodowski 2018-04-05 233 #ifndef __SYSCALL_DEFINEx bed1ffca022cc87 Frederic Weisbecker 2009-03-13 234 #define __SYSCALL_DEFINEx(x, name, ...) \ bee20031772af3d Arnd Bergmann 2018-06-19 235 __diag_push(); \ bee20031772af3d Arnd Bergmann 2018-06-19 236 __diag_ignore(GCC, 8, "-Wattribute-alias", \ bee20031772af3d Arnd Bergmann 2018-06-19 237 "Type aliasing is used to sanitize syscall arguments");\ 83460ec8dcac141 Andi Kleen 2013-11-12 @238 asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) \ e145242ea0df6b7 Dominik Brodowski 2018-04-09 239 __attribute__((alias(__stringify(__se_sys##name)))); \ c9a211951c7c79c Howard McLauchlan 2018-03-21 240 ALLOW_ERROR_INJECTION(sys##name, ERRNO); \ e145242ea0df6b7 Dominik Brodowski 2018-04-09 241 static inline long __do_sys##name(__MAP(x,__SC_DECL,__VA_ARGS__));\ e145242ea0df6b7 Dominik Brodowski 2018-04-09 242 asmlinkage long __se_sys##name(__MAP(x,__SC_LONG,__VA_ARGS__)); \ e145242ea0df6b7 Dominik Brodowski 2018-04-09 243 asmlinkage long __se_sys##name(__MAP(x,__SC_LONG,__VA_ARGS__)) \ 1a94bc34768e463 Heiko Carstens 2009-01-14 244 { \ e145242ea0df6b7 Dominik Brodowski 2018-04-09 245 long ret = __do_sys##name(__MAP(x,__SC_CAST,__VA_ARGS__));\ 07fe6e00f6cca6f Al Viro 2013-01-21 246 __MAP(x,__SC_TEST,__VA_ARGS__); \ 2cf0966683430b6 Al Viro 2013-01-21 247 __PROTECT(x, ret,__MAP(x,__SC_ARGS,__VA_ARGS__)); \ 2cf0966683430b6 Al Viro 2013-01-21 248 return ret; \ 1a94bc34768e463 Heiko Carstens 2009-01-14 249 } \ bee20031772af3d Arnd Bergmann 2018-06-19 250 __diag_pop(); \ e145242ea0df6b7 Dominik Brodowski 2018-04-09 251 static inline long __do_sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) 1bd21c6c21e8489 Dominik Brodowski 2018-04-05 252 #endif /* __SYSCALL_DEFINEx */ 1a94bc34768e463 Heiko Carstens 2009-01-14 253 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org