Hi, I love your patch! Perhaps something to improve: [auto build test WARNING on hch-configfs/for-next] [also build test WARNING on linus/master hnaz-linux-mm/master v5.10-rc7] [cannot apply to mmotm/master next-20201210] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/ira-weiny-intel-com/mm-highmem-R... base: git://git.infradead.org/users/hch/configfs.git for-next config: x86_64-randconfig-a004-20201209 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 1968804ac726e7674d5de22bc2204b45857da344) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/9580f83142cf2df75ceb9e7dbe1939012... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review ira-weiny-intel-com/mm-highmem-Remove-deprecated-kmap_atomic/20201211-021920 git checkout 9580f83142cf2df75ceb9e7dbe1939012818722c # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): In file included from arch/x86/kernel/asm-offsets.c:13: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:22: In file included from include/linux/writeback.h:14: In file included from include/linux/blk-cgroup.h:23: In file included from include/linux/blkdev.h:14: In file included from include/linux/pagemap.h:11: include/linux/highmem.h:229:15: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] void *addr = kmap_local_page(page); ^ include/linux/highmem.h:229:15: note: did you mean 'kmap_to_page'? include/linux/highmem.h:130:28: note: 'kmap_to_page' declared here static inline struct page *kmap_to_page(void *addr) ^ include/linux/highmem.h:229:8: warning: incompatible integer to pointer conversion initializing 'void *' with an expression of type 'int' [-Wint-conversion] void *addr = kmap_local_page(page); ^ ~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:231:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(addr); ^ include/linux/highmem.h:282:16: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] void *kaddr = kmap_local_page(page); ^ include/linux/highmem.h:282:8: warning: incompatible integer to pointer conversion initializing 'void *' with an expression of type 'int' [-Wint-conversion] void *kaddr = kmap_local_page(page); ^ ~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:284:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(kaddr); ^ include/linux/highmem.h:291:16: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] void *kaddr = kmap_local_page(page); ^ include/linux/highmem.h:291:8: warning: incompatible integer to pointer conversion initializing 'void *' with an expression of type 'int' [-Wint-conversion] void *kaddr = kmap_local_page(page); ^ ~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:301:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(kaddr); ^ include/linux/highmem.h:324:10: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] vfrom = kmap_local_page(from); ^ include/linux/highmem.h:324:8: warning: incompatible integer to pointer conversion assigning to 'char *' from 'int' [-Wint-conversion] vfrom = kmap_local_page(from); ^ ~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:325:6: warning: incompatible integer to pointer conversion assigning to 'char *' from 'int' [-Wint-conversion] vto = kmap_local_page(to); ^ ~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:327:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(vto); ^ include/linux/highmem.h:339:10: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] vfrom = kmap_local_page(from); ^ include/linux/highmem.h:339:8: warning: incompatible integer to pointer conversion assigning to 'char *' from 'int' [-Wint-conversion] vfrom = kmap_local_page(from); ^ ~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:340:6: warning: incompatible integer to pointer conversion assigning to 'char *' from 'int' [-Wint-conversion] vto = kmap_local_page(to); ^ ~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:342:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(vto); ^ include/linux/highmem.h:352:14: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] char *dst = kmap_local_page(dst_page); ^ char *dst = kmap_local_page(dst_page); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:353:8: warning: incompatible integer to pointer conversion initializing 'char *' with an expression of type 'int' [-Wint-conversion] char *src = kmap_local_page(src_page); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:357:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(src); ^ include/linux/highmem.h:365:14: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] char *dst = kmap_local_page(dst_page); ^ include/linux/highmem.h:365:8: warning: incompatible integer to pointer conversion initializing 'char *' with an expression of type 'int' [-Wint-conversion] char *dst = kmap_local_page(dst_page); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:366:8: warning: incompatible integer to pointer conversion initializing 'char *' with an expression of type 'int' [-Wint-conversion] char *src = kmap_local_page(src_page); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:370:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(src); ^ include/linux/highmem.h:376:15: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] char *from = kmap_local_page(page); ^ include/linux/highmem.h:376:8: warning: incompatible integer to pointer conversion initializing 'char *' with an expression of type 'int' [-Wint-conversion] char *from = kmap_local_page(page); ^ ~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:380:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(from); ^ include/linux/highmem.h:385:13: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] char *to = kmap_local_page(page); ^ include/linux/highmem.h:385:8: warning: incompatible integer to pointer conversion initializing 'char *' with an expression of type 'int' [-Wint-conversion] char *to = kmap_local_page(page); ^ ~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:389:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(to); ^ include/linux/highmem.h:394:15: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] char *addr = kmap_local_page(page); ^ include/linux/highmem.h:394:8: warning: incompatible integer to pointer conversion initializing 'char *' with an expression of type 'int' [-Wint-conversion] char *addr = kmap_local_page(page); ^ ~~~~~~~~~~~~~~~~~~~~~ fatal error: too many errors emitted, stopping now [-ferror-limit=] 14 warnings and 20 errors generated. -- In file included from arch/x86/kernel/asm-offsets.c:13: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:22: In file included from include/linux/writeback.h:14: In file included from include/linux/blk-cgroup.h:23: In file included from include/linux/blkdev.h:14: In file included from include/linux/pagemap.h:11: include/linux/highmem.h:229:15: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] void *addr = kmap_local_page(page); ^ include/linux/highmem.h:229:15: note: did you mean 'kmap_to_page'? include/linux/highmem.h:130:28: note: 'kmap_to_page' declared here static inline struct page *kmap_to_page(void *addr) ^ include/linux/highmem.h:229:8: warning: incompatible integer to pointer conversion initializing 'void *' with an expression of type 'int' [-Wint-conversion] void *addr = kmap_local_page(page); ^ ~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:231:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(addr); ^ include/linux/highmem.h:282:16: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] void *kaddr = kmap_local_page(page); ^ include/linux/highmem.h:282:8: warning: incompatible integer to pointer conversion initializing 'void *' with an expression of type 'int' [-Wint-conversion] void *kaddr = kmap_local_page(page); ^ ~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:284:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(kaddr); ^ include/linux/highmem.h:291:16: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] void *kaddr = kmap_local_page(page); ^ include/linux/highmem.h:291:8: warning: incompatible integer to pointer conversion initializing 'void *' with an expression of type 'int' [-Wint-conversion] void *kaddr = kmap_local_page(page); ^ ~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:301:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(kaddr); ^ include/linux/highmem.h:324:10: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] vfrom = kmap_local_page(from); ^ include/linux/highmem.h:324:8: warning: incompatible integer to pointer conversion assigning to 'char *' from 'int' [-Wint-conversion] vfrom = kmap_local_page(from); ^ ~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:325:6: warning: incompatible integer to pointer conversion assigning to 'char *' from 'int' [-Wint-conversion] vto = kmap_local_page(to); ^ ~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:327:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(vto); ^ include/linux/highmem.h:339:10: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] vfrom = kmap_local_page(from); ^ include/linux/highmem.h:339:8: warning: incompatible integer to pointer conversion assigning to 'char *' from 'int' [-Wint-conversion] vfrom = kmap_local_page(from); ^ ~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:340:6: warning: incompatible integer to pointer conversion assigning to 'char *' from 'int' [-Wint-conversion] vto = kmap_local_page(to); ^ ~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:342:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(vto); ^ include/linux/highmem.h:352:14: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] char *dst = kmap_local_page(dst_page); ^ char *dst = kmap_local_page(dst_page); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:353:8: warning: incompatible integer to pointer conversion initializing 'char *' with an expression of type 'int' [-Wint-conversion] char *src = kmap_local_page(src_page); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:357:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(src); ^ include/linux/highmem.h:365:14: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] char *dst = kmap_local_page(dst_page); ^ include/linux/highmem.h:365:8: warning: incompatible integer to pointer conversion initializing 'char *' with an expression of type 'int' [-Wint-conversion] char *dst = kmap_local_page(dst_page); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:366:8: warning: incompatible integer to pointer conversion initializing 'char *' with an expression of type 'int' [-Wint-conversion] char *src = kmap_local_page(src_page); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:370:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(src); ^ include/linux/highmem.h:376:15: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] char *from = kmap_local_page(page); ^ include/linux/highmem.h:376:8: warning: incompatible integer to pointer conversion initializing 'char *' with an expression of type 'int' [-Wint-conversion] char *from = kmap_local_page(page); ^ ~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:380:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(from); ^ include/linux/highmem.h:385:13: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] char *to = kmap_local_page(page); ^ include/linux/highmem.h:385:8: warning: incompatible integer to pointer conversion initializing 'char *' with an expression of type 'int' [-Wint-conversion] char *to = kmap_local_page(page); ^ ~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:389:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(to); ^ include/linux/highmem.h:394:15: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] char *addr = kmap_local_page(page); ^ include/linux/highmem.h:394:8: warning: incompatible integer to pointer conversion initializing 'char *' with an expression of type 'int' [-Wint-conversion] char *addr = kmap_local_page(page); ^ ~~~~~~~~~~~~~~~~~~~~~ fatal error: too many errors emitted, stopping now [-ferror-limit=] 14 warnings and 20 errors generated. make[2]: *** [scripts/Makefile.build:117: arch/x86/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1200: prepare0] Error 2 make[1]: Target 'modules_prepare' not remade because of errors. make: *** [Makefile:185: __sub-make] Error 2 make: Target 'modules_prepare' not remade because of errors. -- In file included from arch/x86/kernel/asm-offsets.c:13: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:22: In file included from include/linux/writeback.h:14: In file included from include/linux/blk-cgroup.h:23: In file included from include/linux/blkdev.h:14: In file included from include/linux/pagemap.h:11: include/linux/highmem.h:229:15: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] void *addr = kmap_local_page(page); ^ include/linux/highmem.h:229:15: note: did you mean 'kmap_to_page'? include/linux/highmem.h:130:28: note: 'kmap_to_page' declared here static inline struct page *kmap_to_page(void *addr) ^ include/linux/highmem.h:229:8: warning: incompatible integer to pointer conversion initializing 'void *' with an expression of type 'int' [-Wint-conversion] void *addr = kmap_local_page(page); ^ ~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:231:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(addr); ^ include/linux/highmem.h:282:16: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] void *kaddr = kmap_local_page(page); ^ include/linux/highmem.h:282:8: warning: incompatible integer to pointer conversion initializing 'void *' with an expression of type 'int' [-Wint-conversion] void *kaddr = kmap_local_page(page); ^ ~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:284:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(kaddr); ^ include/linux/highmem.h:291:16: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] void *kaddr = kmap_local_page(page); ^ include/linux/highmem.h:291:8: warning: incompatible integer to pointer conversion initializing 'void *' with an expression of type 'int' [-Wint-conversion] void *kaddr = kmap_local_page(page); ^ ~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:301:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(kaddr); ^ include/linux/highmem.h:324:10: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] vfrom = kmap_local_page(from); ^ include/linux/highmem.h:324:8: warning: incompatible integer to pointer conversion assigning to 'char *' from 'int' [-Wint-conversion] vfrom = kmap_local_page(from); ^ ~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:325:6: warning: incompatible integer to pointer conversion assigning to 'char *' from 'int' [-Wint-conversion] vto = kmap_local_page(to); ^ ~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:327:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(vto); ^ include/linux/highmem.h:339:10: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] vfrom = kmap_local_page(from); ^ include/linux/highmem.h:339:8: warning: incompatible integer to pointer conversion assigning to 'char *' from 'int' [-Wint-conversion] vfrom = kmap_local_page(from); ^ ~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:340:6: warning: incompatible integer to pointer conversion assigning to 'char *' from 'int' [-Wint-conversion] vto = kmap_local_page(to); ^ ~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:342:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(vto); ^ include/linux/highmem.h:352:14: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] char *dst = kmap_local_page(dst_page); ^ char *dst = kmap_local_page(dst_page); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:353:8: warning: incompatible integer to pointer conversion initializing 'char *' with an expression of type 'int' [-Wint-conversion] char *src = kmap_local_page(src_page); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:357:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(src); ^ include/linux/highmem.h:365:14: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] char *dst = kmap_local_page(dst_page); ^ include/linux/highmem.h:365:8: warning: incompatible integer to pointer conversion initializing 'char *' with an expression of type 'int' [-Wint-conversion] char *dst = kmap_local_page(dst_page); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:366:8: warning: incompatible integer to pointer conversion initializing 'char *' with an expression of type 'int' [-Wint-conversion] char *src = kmap_local_page(src_page); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:370:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(src); ^ include/linux/highmem.h:376:15: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] char *from = kmap_local_page(page); ^ include/linux/highmem.h:376:8: warning: incompatible integer to pointer conversion initializing 'char *' with an expression of type 'int' [-Wint-conversion] char *from = kmap_local_page(page); ^ ~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:380:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(from); ^ include/linux/highmem.h:385:13: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] char *to = kmap_local_page(page); ^ include/linux/highmem.h:385:8: warning: incompatible integer to pointer conversion initializing 'char *' with an expression of type 'int' [-Wint-conversion] char *to = kmap_local_page(page); ^ ~~~~~~~~~~~~~~~~~~~~~ include/linux/highmem.h:389:2: error: implicit declaration of function 'kunmap_local' [-Werror,-Wimplicit-function-declaration] kunmap_local(to); ^ include/linux/highmem.h:394:15: error: implicit declaration of function 'kmap_local_page' [-Werror,-Wimplicit-function-declaration] char *addr = kmap_local_page(page); ^ include/linux/highmem.h:394:8: warning: incompatible integer to pointer conversion initializing 'char *' with an expression of type 'int' [-Wint-conversion] char *addr = kmap_local_page(page); ^ ~~~~~~~~~~~~~~~~~~~~~ fatal error: too many errors emitted, stopping now [-ferror-limit=] 14 warnings and 20 errors generated. make[2]: *** [scripts/Makefile.build:117: arch/x86/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1200: prepare0] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:185: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. vim +352 include/linux/highmem.h 347 348 static inline void memcpy_page(struct page *dst_page, size_t dst_off, 349 struct page *src_page, size_t src_off, 350 size_t len) 351 { 353 char *src = kmap_local_page(src_page); 354 355 BUG_ON(dst_off + len > PAGE_SIZE || src_off + len > PAGE_SIZE); 356 memcpy(dst + dst_off, src + src_off, len); 357 kunmap_local(src); 358 kunmap_local(dst); 359 } 360 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org